Despite -portable existing to make the codebase compile on platforms other than OpenBSD, there's nothing wrong with making -portable still compile on that platform as well.

When not using pkg-config on those systems where it isn't installed, libpanelw should be checked within ncursesw as well -- such is the case on OpenBSD for example.

This is included portably.

ok op@

was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers.

URLs are embedded as part of the HTML and, while it seems legal from RFC3986 to leave that character unquoted, we need it quoted to avoid breaking the HTML output. ok tracey@

ok tracey@

spotted by + "looks good" tracey@

binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske

ok jamsek

This should avoid involuntary use of bind(2) with arbitrary socket paths. ok op@

Now that anyone can connect to the socket, it is probably safer to expose information about currently connected clients only to root.

and drop unix_socket and unix_socket_path in server context. ok stsp@

Repository access is now controlled by access rules in gotd.conf, and concurrent connections to the gotd socket by local users are limited by the listen process. We should keep refining our anti-DoS measures in the future, but at least we have something in place now. ok jamsek, op

can now use got_object_blob_is_binary to simplify the logic. ok stsp@

needed for future use by gotwebd. ok stsp@

In some pages gotwebd shows horizontal scrollbars because the error message overflows the width. Remove the explicit width in the CSS, the message is still rendered fine and doesn't overflow the page. spotted by and ok tracey@

no need to duplicate what strtonum does; pass the *real* maximum value allowed to it directly. ok stsp@

it's a string, `const char *' is fine (and what all the callers use anyway.)

Since gotwebd serves the RSS from a path without a file name component, browsers just make up a random string to give the file a name which can be confusing. Furthermore, since it's served as application/rss+xml they try to render the XML (failing.) Use gotweb_render_content_type_file (which sets the Content-Disposition HTTP header) to fix both: the feed is now called <repo-name>.rss and set as attachment (thus saved and not rendered.) Change the function to take an optional filename suffix for the occasion. ok jamsek

This allows to use a suffix to indicate the unit of measure, such as "1h" for one hour or "30m" for 30 minutes. The suffix "s" for seconds is also accepted for completeness. ok stsp