Commit Diff

Commit:
7ddb9e12ddb8b4528b6db5c9105ad83adae17765
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
fix hmac error logging; suggestions by op@
Actions:
Patch | Tree
commit - 4615fe93f6be3799737f485f025f1ec9b89586f5
commit + 7ddb9e12ddb8b4528b6db5c9105ad83adae17765
blob - 30623ad273c8b91f084de562be5d81d2b510d315
blob + af6fa898b64f8cae67ec5dbd56fe5e7facc9cb1f
--- gotd/libexec/got-notify-http/got-notify-http.c
+++ gotd/libexec/got-notify-http/got-notify-http.c
@@ -859,12 +859,12 @@ compute_hmac_sha256(FILE *payload, off_t paylen, const
 
 	ctx = HMAC_CTX_new();
 	if (ctx == NULL) {
-		log_warn("HMAC_CTX_new");
+		log_warnx("HMAC_CTX_new failed");
 		return NULL;
 	}
 
 	if (!HMAC_Init_ex(ctx, hmac_secret, secret_len, EVP_sha256(), NULL)) {
-		log_warn("HMAC_Init_ex");
+		log_warnx("HMAC_Init_ex failed");
 		goto fail;
 	}
 
@@ -876,8 +876,7 @@ compute_hmac_sha256(FILE *payload, off_t paylen, const
 				log_warnx("HMAC payload truncated");
 				goto fail;
 			}
-			log_warnx("reading HMAC payload: %s",
-			    strerror(ferror(payload)));
+			log_warn("failed to read HMAC payload");
 			goto fail;
 		}
 		if (!HMAC_Update(ctx, buf, r)) {
@@ -888,7 +887,7 @@ compute_hmac_sha256(FILE *payload, off_t paylen, const
 	}
 
 	if (!HMAC_Final(ctx, hmac_sig_buf, hmac_siglen)) {
-		log_warn("HMAC_Final");
+		log_warnx("HMAC_Final failed");
 		goto fail;
 	}