commit 0adc4fa2d86b99cbb48d304a89cd7b5a81c94be6 from: Omar Polo date: Sun Jul 14 09:22:07 2024 UTC use memmove in got_fileinedx_entry_update Some callers, like worktree.c:/^sync_timestamps, are passing the commit sha1 itself as an argument, so we shouldn't use memcpy but rather memmove. commit - 92a090c68f0df4e43c9fd81f0a5e8df81b594b2b commit + 0adc4fa2d86b99cbb48d304a89cd7b5a81c94be6 blob - bd0bf8276ab597dc7ed38191a85fa2c472393a80 blob + 145e81afb23853a38e8678b9912d4d9f5510a5e3 --- lib/fileindex.c +++ lib/fileindex.c @@ -135,7 +135,7 @@ got_fileindex_entry_update(struct got_fileindex_entry ie->flags |= GOT_FILEIDX_F_NO_BLOB; if (commit_sha1) { - memcpy(ie->commit_sha1, commit_sha1, SHA1_DIGEST_LENGTH); + memmove(ie->commit_sha1, commit_sha1, SHA1_DIGEST_LENGTH); ie->flags &= ~GOT_FILEIDX_F_NO_COMMIT; } else ie->flags |= GOT_FILEIDX_F_NO_COMMIT;