commit a0c23862a7804dbba0e030bd78bf05ed4d1ffdfe
from: Omar Polo <op@omarpolo.com>
date: Mon Jul 08 16:23:50 2024 UTC

gotwebd: plug fd leak in error path

commit - fae3f56c90a8e133ab63a37fb266354f88fe4911
commit + a0c23862a7804dbba0e030bd78bf05ed4d1ffdfe
blob - 154a8ab843133cfba8b72ec5f8e9660d55e4d327
blob + 4e77f9bc4e3f7fbc28bdd7acab9f92f2309e4fd3
--- gotwebd/got_operations.c
+++ gotwebd/got_operations.c
@@ -1153,15 +1153,15 @@ got_open_diff_for_output(FILE **fp, struct request *c)
 
 	error = got_gotweb_openfile(&f1, &c->priv_fd[DIFF_FD_1]);
 	if (error)
-		return error;
+		goto done;
 
 	error = got_gotweb_openfile(&f2, &c->priv_fd[DIFF_FD_2]);
 	if (error)
-		return error;
+		goto done;
 
 	error = got_gotweb_openfile(&f3, &c->priv_fd[DIFF_FD_3]);
 	if (error)
-		return error;
+		goto done;
 
 	rc = TAILQ_FIRST(&t->repo_commits);