commit e82d0e1ce54259918e9100d0cf6c388ea60c64e4
from: Stefan Sperling <stsp@stsp.name>
date: Sat Feb 01 15:34:24 2025 UTC

avoid needless use of STAILQ_FOREACH_SAFE, we are not removing elements here

commit - 5ceaed1f0361f500855854af8014994720e38c1f
commit + e82d0e1ce54259918e9100d0cf6c388ea60c64e4
blob - d98276ebe73aad573bc05b47c0decf9d90f1963b
blob + 4ee1df9d2b9a64e0720103a3c135b0f98b40bf19
--- libexec/got-read-pack/got-read-pack.c
+++ libexec/got-read-pack/got-read-pack.c
@@ -1701,7 +1701,7 @@ repaint_parent_commits(struct got_object_id *commit_id
 		return err;
 
 	while (commit) {
-		struct got_object_qid *pid, *qid, *tmp;
+		struct got_object_qid *pid, *qid;
 		int idx;
 
 		parents = got_object_commit_get_parent_ids(commit);
@@ -1765,7 +1765,7 @@ repaint_parent_commits(struct got_object_id *commit_id
 		 * In case this commit is on the caller's list of
 		 * pending commits to traverse, repaint it there.
 		 */
-		STAILQ_FOREACH_SAFE(qid, ids, entry, tmp) {
+		STAILQ_FOREACH(qid, ids, entry) {
 			if (got_object_id_cmp(&qid->id, &pid->id) != 0)
 				continue;
 			err = paint_commit(qid, color);