1 /*
2  * Copyright (c) 2018 Stefan Sperling <stsp@openbsd.org>
3  *
4  * Permission to use, copy, modify, and distribute this software for any
5  * purpose with or without fee is hereby granted, provided that the above
6  * copyright notice and this permission notice appear in all copies.
7  *
8  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
9  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
10  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
11  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
12  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
13  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
14  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
15  */
16 
17 #include <sys/types.h>
18 #include <sys/stat.h>
19 #include <sys/queue.h>
20 
21 #include <dirent.h>
22 #include <fcntl.h>
23 #include <errno.h>
24 #include <stdio.h>
25 #include <stdint.h>
26 #include <stdlib.h>
27 #include <string.h>
28 #include <limits.h>
29 #include <sha1.h>
30 #include <endian.h>
31 #include <zlib.h>
32 
33 #include "got_error.h"
34 #include "got_object.h"
35 #include "got_repository.h"
36 
37 #include "got_lib_sha1.h"
38 #include "got_lib_pack.h"
39 #include "got_lib_path.h"
40 #include "got_lib_delta.h"
41 #include "got_lib_zbuf.h"
42 #include "got_lib_object.h"
43 #include "got_lib_repository.h"
44 
45 #ifndef nitems
46 #define nitems(_a) (sizeof(_a) / sizeof((_a)[0]))
47 #endif
48 
49 #define GOT_PACK_PREFIX		"pack-"
50 #define GOT_PACKFILE_SUFFIX	".pack"
51 #define GOT_PACKIDX_SUFFIX		".idx"
52 #define GOT_PACKFILE_NAMELEN	(strlen(GOT_PACK_PREFIX) + \
53 				SHA1_DIGEST_STRING_LENGTH - 1 + \
54 				strlen(GOT_PACKFILE_SUFFIX))
55 #define GOT_PACKIDX_NAMELEN	(strlen(GOT_PACK_PREFIX) + \
56 				SHA1_DIGEST_STRING_LENGTH - 1 + \
57 				strlen(GOT_PACKIDX_SUFFIX))
58 
59 #ifndef MIN
60 #define	MIN(_a,_b) ((_a) < (_b) ? (_a) : (_b))
61 #endif
62 
63 static const struct got_error *
64 verify_fanout_table(uint32_t *fanout_table)
65 {
66 	int i;
67 
68 	for (i = 0; i < 0xff - 1; i++) {
69 		if (be32toh(fanout_table[i]) > be32toh(fanout_table[i + 1]))
70 			return got_error(GOT_ERR_BAD_PACKIDX);
71 	}
72 
73 	return NULL;
74 }
75 
76 static const struct got_error *
77 get_packfile_size(size_t *size, const char *path)
78 {
79 	struct stat sb;
80 	char *dot;
81 
82 	dot = strrchr(path, '.');
83 	if (dot == NULL)
84 		return got_error(GOT_ERR_BAD_PATH);
85 
86 	/* Path must point to a pack index or to a pack file. */
87 	if (strcmp(dot, ".idx") == 0) {
88 		char *path_pack;
89 		char base_path[PATH_MAX];
90 
91 		/* Convert pack index path to pack file path. */
92 		if (strlcpy(base_path, path, PATH_MAX) > PATH_MAX)
93 			return got_error(GOT_ERR_NO_SPACE);
94 		dot = strrchr(base_path, '.');
95 		if (dot == NULL)
96 			return got_error(GOT_ERR_BAD_PATH);
97 		*dot = '\0';
98 		if (asprintf(&path_pack, "%s.pack", base_path) == -1)
99 			return got_error_from_errno();
100 
101 		if (stat(path_pack, &sb) != 0) {
102 			free(path_pack);
103 			return got_error_from_errno();
104 		}
105 		free(path_pack);
106 	} else if (strcmp(dot, ".pack") == 0) {
107 		if (stat(path, &sb) != 0)
108 			return got_error_from_errno();
109 	} else
110 		return got_error(GOT_ERR_BAD_PATH);
111 
112 	*size = sb.st_size;
113 	return 0;
114 }
115 
116 const struct got_error *
117 got_packidx_open(struct got_packidx_v2_hdr **packidx, const char *path)
118 {
119 	struct got_packidx_v2_hdr *p;
120 	FILE *f;
121 	const struct got_error *err = NULL;
122 	size_t n, nobj, packfile_size;
123 	SHA1_CTX ctx;
124 	uint8_t sha1[SHA1_DIGEST_LENGTH];
125 
126 	SHA1Init(&ctx);
127 
128 	f = fopen(path, "rb");
129 	if (f == NULL)
130 		return got_error_from_errno();
131 
132 	err = get_packfile_size(&packfile_size, path);
133 	if (err)
134 		return err;
135 
136 	p = calloc(1, sizeof(*p));
137 	if (p == NULL) {
138 		err = got_error_from_errno();
139 		goto done;
140 	}
141 
142 	n = fread(&p->magic, sizeof(p->magic), 1, f);
143 	if (n != 1) {
144 		err = got_ferror(f, GOT_ERR_BAD_PACKIDX);
145 		goto done;
146 	}
147 
148 	if (betoh32(p->magic) != GOT_PACKIDX_V2_MAGIC) {
149 		err = got_error(GOT_ERR_BAD_PACKIDX);
150 		goto done;
151 	}
152 
153 	SHA1Update(&ctx, (uint8_t *)&p->magic, sizeof(p->magic));
154 
155 	n = fread(&p->version, sizeof(p->version), 1, f);
156 	if (n != 1) {
157 		err = got_ferror(f, GOT_ERR_BAD_PACKIDX);
158 		goto done;
159 	}
160 
161 	if (betoh32(p->version) != GOT_PACKIDX_VERSION) {
162 		err = got_error(GOT_ERR_BAD_PACKIDX);
163 		goto done;
164 	}
165 
166 	SHA1Update(&ctx, (uint8_t *)&p->version, sizeof(p->version));
167 
168 	n = fread(&p->fanout_table, sizeof(p->fanout_table), 1, f);
169 	if (n != 1) {
170 		err = got_ferror(f, GOT_ERR_BAD_PACKIDX);
171 		goto done;
172 	}
173 
174 	err = verify_fanout_table(p->fanout_table);
175 	if (err)
176 		goto done;
177 
178 	SHA1Update(&ctx, (uint8_t *)p->fanout_table, sizeof(p->fanout_table));
179 
180 	nobj = betoh32(p->fanout_table[0xff]);
181 
182 	p->sorted_ids = calloc(nobj, sizeof(*p->sorted_ids));
183 	if (p->sorted_ids == NULL) {
184 		err = got_error_from_errno();
185 		goto done;
186 	}
187 
188 	n = fread(p->sorted_ids, sizeof(*p->sorted_ids), nobj, f);
189 	if (n != nobj) {
190 		err = got_ferror(f, GOT_ERR_BAD_PACKIDX);
191 		goto done;
192 	}
193 
194 	SHA1Update(&ctx, (uint8_t *)p->sorted_ids,
195 	    nobj * sizeof(*p->sorted_ids));
196 
197 	p->crc32 = calloc(nobj, sizeof(*p->crc32));
198 	if (p->crc32 == NULL) {
199 		err = got_error_from_errno();
200 		goto done;
201 	}
202 
203 	n = fread(p->crc32, sizeof(*p->crc32), nobj, f);
204 	if (n != nobj) {
205 		err = got_ferror(f, GOT_ERR_BAD_PACKIDX);
206 		goto done;
207 	}
208 
209 	SHA1Update(&ctx, (uint8_t *)p->crc32, nobj * sizeof(*p->crc32));
210 
211 	p->offsets = calloc(nobj, sizeof(*p->offsets));
212 	if (p->offsets == NULL) {
213 		err = got_error_from_errno();
214 		goto done;
215 	}
216 
217 	n = fread(p->offsets, sizeof(*p->offsets), nobj, f);
218 	if (n != nobj) {
219 		err = got_ferror(f, GOT_ERR_BAD_PACKIDX);
220 		goto done;
221 	}
222 
223 	SHA1Update(&ctx, (uint8_t *)p->offsets, nobj * sizeof(*p->offsets));
224 
225 	/* Large file offsets are contained only in files > 2GB. */
226 	if (packfile_size <= 0x80000000)
227 		goto checksum;
228 
229 	p->large_offsets = calloc(nobj, sizeof(*p->large_offsets));
230 	if (p->large_offsets == NULL) {
231 		err = got_error_from_errno();
232 		goto done;
233 	}
234 
235 	n = fread(p->large_offsets, sizeof(*p->large_offsets), nobj, f);
236 	if (n != nobj) {
237 		err = got_ferror(f, GOT_ERR_BAD_PACKIDX);
238 		goto done;
239 	}
240 
241 	SHA1Update(&ctx, (uint8_t*)p->large_offsets,
242 	    nobj * sizeof(*p->large_offsets));
243 
244 checksum:
245 	n = fread(&p->trailer, sizeof(p->trailer), 1, f);
246 	if (n != 1) {
247 		err = got_ferror(f, GOT_ERR_BAD_PACKIDX);
248 		goto done;
249 	}
250 
251 	SHA1Update(&ctx, p->trailer.packfile_sha1, SHA1_DIGEST_LENGTH);
252 	SHA1Final(sha1, &ctx);
253 	if (memcmp(p->trailer.packidx_sha1, sha1, SHA1_DIGEST_LENGTH) != 0)
254 		err = got_error(GOT_ERR_PACKIDX_CSUM);
255 done:
256 	fclose(f);
257 	if (err)
258 		got_packidx_close(p);
259 	else
260 		*packidx = p;
261 	return err;
262 }
263 
264 void
265 got_packidx_close(struct got_packidx_v2_hdr *packidx)
266 {
267 	free(packidx->sorted_ids);
268 	free(packidx->offsets);
269 	free(packidx->crc32);
270 	free(packidx->large_offsets);
271 	free(packidx);
272 }
273 
274 static int
275 is_packidx_filename(const char *name, size_t len)
276 {
277 	if (len != GOT_PACKIDX_NAMELEN)
278 		return 0;
279 
280 	if (strncmp(name, GOT_PACK_PREFIX, strlen(GOT_PACK_PREFIX)) != 0)
281 		return 0;
282 
283 	if (strcmp(name + strlen(GOT_PACK_PREFIX) +
284 	    SHA1_DIGEST_STRING_LENGTH - 1, GOT_PACKIDX_SUFFIX) != 0)
285 		return 0;
286 
287 	return 1;
288 }
289 
290 static off_t
291 get_object_offset(struct got_packidx_v2_hdr *packidx, int idx)
292 {
293 	uint32_t totobj = betoh32(packidx->fanout_table[0xff]);
294 	uint32_t offset = betoh32(packidx->offsets[idx]);
295 	if (offset & GOT_PACKIDX_OFFSET_VAL_IS_LARGE_IDX) {
296 		uint64_t loffset;
297 		idx = offset & GOT_PACKIDX_OFFSET_VAL_MASK;
298 		if (idx < 0 || idx > totobj || packidx->large_offsets == NULL)
299 			return -1;
300 		loffset = betoh64(packidx->large_offsets[idx]);
301 		return (loffset > INT64_MAX ? -1 : (off_t)loffset);
302 	}
303 	return (off_t)(offset & GOT_PACKIDX_OFFSET_VAL_MASK);
304 }
305 
306 static const struct got_error *
307 get_packfile_path(char **path_packfile, struct got_repository *repo,
308     struct got_packidx_v2_hdr *packidx);
309 
310 static int
311 get_object_idx(struct got_packidx_v2_hdr *packidx, struct got_object_id *id, struct got_repository *repo)
312 {
313 	u_int8_t id0 = id->sha1[0];
314 	uint32_t totobj = betoh32(packidx->fanout_table[0xff]);
315 	int i = 0;
316 
317 	if (id0 > 0)
318 		i = betoh32(packidx->fanout_table[id0 - 1]);
319 
320 	while (i < totobj) {
321 		struct got_object_id *oid = &packidx->sorted_ids[i];
322 		int cmp = got_object_id_cmp(id, oid);
323 
324 		if (cmp == 0)
325 			return i;
326 		i++;
327 	}
328 
329 	return -1;
330 }
331 
332 static struct got_packidx_v2_hdr *
333 dup_packidx(struct got_packidx_v2_hdr *packidx)
334 {
335 	struct got_packidx_v2_hdr *p;
336 	size_t nobj;
337 
338 	p = calloc(1, sizeof(*p));
339 	if (p == NULL)
340 		return NULL;
341 
342 	memcpy(p, packidx, sizeof(*p));
343 	p->sorted_ids = NULL;
344 	p->crc32 = NULL;
345 	p->offsets = NULL;
346 	p->large_offsets = NULL;
347 
348 	nobj = betoh32(p->fanout_table[0xff]);
349 
350 	p->sorted_ids = calloc(nobj, sizeof(*p->sorted_ids));
351 	if (p->sorted_ids == NULL)
352 		goto err;
353 	memcpy(p->sorted_ids, packidx->sorted_ids, nobj * sizeof(*p->sorted_ids));
354 
355 	p->crc32 = calloc(nobj, sizeof(*p->crc32));
356 	if (p->crc32 == NULL)
357 		goto err;
358 	memcpy(p->crc32, packidx->crc32, nobj * sizeof(*p->crc32));
359 
360 	p->offsets = calloc(nobj, sizeof(*p->offsets));
361 	if (p->offsets == NULL)
362 		goto err;
363 	memcpy(p->offsets, packidx->offsets, nobj * sizeof(*p->offsets));
364 
365 	if (p->large_offsets) {
366 		p->large_offsets = calloc(nobj, sizeof(*p->large_offsets));
367 		if (p->large_offsets == NULL)
368 			goto err;
369 		memcpy(p->large_offsets, packidx->large_offsets,
370 		    nobj * sizeof(*p->large_offsets));
371 	}
372 
373 	return p;
374 
375 err:
376 	free(p->large_offsets);
377 	free(p->offsets);
378 	free(p->crc32);
379 	free(p->sorted_ids);
380 	free(p);
381 	return NULL;
382 }
383 
384 static void
385 cache_packidx(struct got_packidx_v2_hdr *packidx, struct got_repository *repo)
386 {
387 	int i;
388 
389 	for (i = 0; i < nitems(repo->packidx_cache); i++) {
390 		if (repo->packidx_cache[i] == NULL)
391 			break;
392 	}
393 
394 	if (i == nitems(repo->packidx_cache)) {
395 		got_packidx_close(repo->packidx_cache[i - 1]);
396 		memmove(&repo->packidx_cache[1], &repo->packidx_cache[0],
397 		    sizeof(repo->packidx_cache) -
398 		    sizeof(repo->packidx_cache[0]));
399 		i = 0;
400 	}
401 
402 	repo->packidx_cache[i] = dup_packidx(packidx);
403 }
404 
405 static const struct got_error *
406 search_packidx(struct got_packidx_v2_hdr **packidx, int *idx,
407     struct got_repository *repo, struct got_object_id *id)
408 {
409 	const struct got_error *err;
410 	char *path_packdir;
411 	DIR *packdir;
412 	struct dirent *dent;
413 	char *path_packidx;
414 	int i;
415 
416 	/* Search pack index cache. */
417 	for (i = 0; i < nitems(repo->packidx_cache); i++) {
418 		if (repo->packidx_cache[i] == NULL)
419 			break;
420 		*idx = get_object_idx(repo->packidx_cache[i], id, repo);
421 		if (*idx != -1) {
422 			*packidx = repo->packidx_cache[i];
423 			return NULL;
424 		}
425 	}
426 	/* No luck. Search the filesystem. */
427 
428 	path_packdir = got_repo_get_path_objects_pack(repo);
429 	if (path_packdir == NULL)
430 		return got_error_from_errno();
431 
432 	packdir = opendir(path_packdir);
433 	if (packdir == NULL) {
434 		err = got_error_from_errno();
435 		goto done;
436 	}
437 
438 	while ((dent = readdir(packdir)) != NULL) {
439 		if (!is_packidx_filename(dent->d_name, dent->d_namlen))
440 			continue;
441 
442 		if (asprintf(&path_packidx, "%s/%s", path_packdir,
443 		    dent->d_name) == -1) {
444 			err = got_error_from_errno();
445 			goto done;
446 		}
447 
448 		err = got_packidx_open(packidx, path_packidx);
449 		free(path_packidx);
450 		if (err)
451 			goto done;
452 
453 		*idx = get_object_idx(*packidx, id, repo);
454 		if (*idx != -1) {
455 			err = NULL; /* found the object */
456 			cache_packidx(*packidx, repo);
457 			goto done;
458 		}
459 
460 		got_packidx_close(*packidx);
461 		*packidx = NULL;
462 	}
463 
464 	err = got_error(GOT_ERR_NO_OBJ);
465 done:
466 	free(path_packdir);
467 	if (packdir && closedir(packdir) != 0 && err == 0)
468 		err = got_error_from_errno();
469 	return err;
470 }
471 
472 static const struct got_error *
473 get_packfile_path(char **path_packfile, struct got_repository *repo,
474     struct got_packidx_v2_hdr *packidx)
475 {
476 	char *path_packdir;
477 	char hex[SHA1_DIGEST_STRING_LENGTH];
478 	char *sha1str;
479 
480 	path_packdir = got_repo_get_path_objects_pack(repo);
481 	if (path_packdir == NULL)
482 		return got_error_from_errno();
483 
484 	sha1str = got_sha1_digest_to_str(packidx->trailer.packfile_sha1,
485 	    hex, sizeof(hex));
486 	if (sha1str == NULL)
487 		return got_error(GOT_ERR_PACKIDX_CSUM);
488 
489 	if (asprintf(path_packfile, "%s/%s%s%s", path_packdir,
490 	    GOT_PACK_PREFIX, sha1str, GOT_PACKFILE_SUFFIX) == -1) {
491 		*path_packfile = NULL;
492 		return got_error_from_errno();
493 	}
494 
495 	return NULL;
496 }
497 
498 const struct got_error *
499 read_packfile_hdr(FILE *f, struct got_packidx_v2_hdr *packidx)
500 {
501 	const struct got_error *err = NULL;
502 	uint32_t totobj = betoh32(packidx->fanout_table[0xff]);
503 	struct got_packfile_hdr hdr;
504 	size_t n;
505 
506 	n = fread(&hdr, sizeof(hdr), 1, f);
507 	if (n != 1)
508 		return got_ferror(f, GOT_ERR_BAD_PACKIDX);
509 
510 	if (betoh32(hdr.signature) != GOT_PACKFILE_SIGNATURE ||
511 	    betoh32(hdr.version) != GOT_PACKFILE_VERSION ||
512 	    betoh32(hdr.nobjects) != totobj)
513 		err = got_error(GOT_ERR_BAD_PACKFILE);
514 
515 	return err;
516 }
517 
518 static const struct got_error *
519 open_packfile(FILE **packfile, const char *path_packfile,
520     struct got_repository *repo, struct got_packidx_v2_hdr *packidx)
521 {
522 	const struct got_error *err = NULL;
523 
524 	*packfile = NULL;
525 
526 	*packfile = fopen(path_packfile, "rb");
527 	if (*packfile == NULL) {
528 		err = got_error_from_errno();
529 		return err;
530 	}
531 
532 	if (packidx) {
533 		err = read_packfile_hdr(*packfile, packidx);
534 		if (err) {
535 			fclose(*packfile);
536 			*packfile = NULL;
537 		}
538 	}
539 	return err;
540 }
541 
542 void
543 got_pack_close(struct got_pack *pack)
544 {
545 	fclose(pack->packfile);
546 	pack->packfile = NULL;
547 	free(pack->path_packfile);
548 	pack->path_packfile = NULL;
549 	pack->filesize = 0;
550 }
551 
552 static const struct got_error *
553 cache_pack(struct got_pack **packp, const char *path_packfile,
554     struct got_packidx_v2_hdr *packidx, struct got_repository *repo)
555 {
556 	const struct got_error *err = NULL;
557 	struct got_pack *pack = NULL;
558 	int i;
559 
560 	if (packp)
561 		*packp = NULL;
562 
563 	for (i = 0; i < nitems(repo->packs); i++) {
564 		pack = &repo->packs[i];
565 		if (pack->path_packfile == NULL)
566 			break;
567 		if (strcmp(pack->path_packfile, path_packfile) == 0)
568 			return NULL;
569 	}
570 
571 	if (i == nitems(repo->packs) - 1) {
572 		got_pack_close(&repo->packs[i - 1]);
573 		memmove(&repo->packs[1], &repo->packs[0],
574 		    sizeof(repo->packs) - sizeof(repo->packs[0]));
575 		i = 0;
576 	}
577 
578 	pack = &repo->packs[i];
579 
580 	pack->path_packfile = strdup(path_packfile);
581 	if (pack->path_packfile == NULL) {
582 		err = got_error_from_errno();
583 		goto done;
584 	}
585 
586 	err = open_packfile(&pack->packfile, path_packfile, repo, packidx);
587 	if (err)
588 		goto done;
589 
590 	err = get_packfile_size(&pack->filesize, path_packfile);
591 done:
592 	if (err) {
593 		if (pack)
594 			free(pack->path_packfile);
595 		free(pack);
596 	} else if (packp)
597 		*packp = pack;
598 	return err;
599 }
600 
601 struct got_pack *
602 get_cached_pack(const char *path_packfile, struct got_repository *repo)
603 {
604 	struct got_pack *pack = NULL;
605 	int i;
606 
607 	for (i = 0; i < nitems(repo->packs); i++) {
608 		pack = &repo->packs[i];
609 		if (pack->path_packfile == NULL)
610 			break;
611 		if (strcmp(pack->path_packfile, path_packfile) == 0)
612 			return pack;
613 	}
614 
615 	return NULL;
616 }
617 
618 static const struct got_error *
619 parse_object_type_and_size(uint8_t *type, uint64_t *size, size_t *len,
620     FILE *packfile)
621 {
622 	uint8_t t = 0;
623 	uint64_t s = 0;
624 	uint8_t sizeN;
625 	size_t n;
626 	int i = 0;
627 
628 	do {
629 		/* We do not support size values which don't fit in 64 bit. */
630 		if (i > 9)
631 			return got_error(GOT_ERR_NO_SPACE);
632 
633 		n = fread(&sizeN, sizeof(sizeN), 1, packfile);
634 		if (n != 1)
635 			return got_ferror(packfile, GOT_ERR_BAD_PACKIDX);
636 
637 		if (i == 0) {
638 			t = (sizeN & GOT_PACK_OBJ_SIZE0_TYPE_MASK) >>
639 			    GOT_PACK_OBJ_SIZE0_TYPE_MASK_SHIFT;
640 			s = (sizeN & GOT_PACK_OBJ_SIZE0_VAL_MASK);
641 		} else {
642 			size_t shift = 4 + 7 * (i - 1);
643 			s |= ((sizeN & GOT_PACK_OBJ_SIZE_VAL_MASK) << shift);
644 		}
645 		i++;
646 	} while (sizeN & GOT_PACK_OBJ_SIZE_MORE);
647 
648 	*type = t;
649 	*size = s;
650 	*len = i * sizeof(sizeN);
651 	return NULL;
652 }
653 
654 static const struct got_error *
655 open_plain_object(struct got_object **obj, const char *path_packfile,
656     struct got_object_id *id, uint8_t type, off_t offset, size_t size)
657 {
658 	*obj = calloc(1, sizeof(**obj));
659 	if (*obj == NULL)
660 		return got_error_from_errno();
661 
662 	(*obj)->path_packfile = strdup(path_packfile);
663 	if ((*obj)->path_packfile == NULL) {
664 		const struct got_error *err = got_error_from_errno();
665 		free(*obj);
666 		*obj = NULL;
667 		return err;
668 	}
669 
670 	(*obj)->type = type;
671 	(*obj)->flags = GOT_OBJ_FLAG_PACKED;
672 	(*obj)->hdrlen = 0;
673 	(*obj)->size = size;
674 	memcpy(&(*obj)->id, id, sizeof((*obj)->id));
675 	(*obj)->pack_offset = offset;
676 
677 	return NULL;
678 }
679 
680 static const struct got_error *
681 parse_negative_offset(int64_t *offset, size_t *len, FILE *packfile)
682 {
683 	int64_t o = 0;
684 	uint8_t offN;
685 	size_t n;
686 	int i = 0;
687 
688 	do {
689 		/* We do not support offset values which don't fit in 64 bit. */
690 		if (i > 8)
691 			return got_error(GOT_ERR_NO_SPACE);
692 
693 		n = fread(&offN, sizeof(offN), 1, packfile);
694 		if (n != 1)
695 			return got_ferror(packfile, GOT_ERR_BAD_PACKIDX);
696 
697 		if (i == 0)
698 			o = (offN & GOT_PACK_OBJ_DELTA_OFF_VAL_MASK);
699 		else {
700 			o++;
701 			o <<= 7;
702 			o += (offN & GOT_PACK_OBJ_DELTA_OFF_VAL_MASK);
703 		}
704 		i++;
705 	} while (offN & GOT_PACK_OBJ_DELTA_OFF_MORE);
706 
707 	*offset = o;
708 	*len = i * sizeof(offN);
709 	return NULL;
710 }
711 
712 static const struct got_error *
713 parse_offset_delta(off_t *base_offset, FILE *packfile, off_t offset)
714 {
715 	const struct got_error *err;
716 	int64_t negoffset;
717 	size_t negofflen;
718 
719 	err = parse_negative_offset(&negoffset, &negofflen, packfile);
720 	if (err)
721 		return err;
722 
723 	/* Compute the base object's offset (must be in the same pack file). */
724 	*base_offset = (offset - negoffset);
725 	if (*base_offset <= 0)
726 		return got_error(GOT_ERR_BAD_PACKFILE);
727 
728 	return NULL;
729 }
730 
731 static const struct got_error *
732 resolve_delta_chain(struct got_delta_chain *, struct got_repository *,
733     FILE *, const char *, off_t, size_t, int, size_t);
734 
735 static const struct got_error *
736 add_delta(struct got_delta_chain *deltas, const char *path_packfile,
737     off_t delta_offset, size_t tslen, int delta_type, size_t delta_size,
738     size_t delta_data_offset, uint8_t *delta_buf, size_t delta_len)
739 {
740 	struct got_delta *delta;
741 
742 	delta = got_delta_open(path_packfile, delta_offset, tslen,
743 	    delta_type, delta_size, delta_data_offset, delta_buf,
744 	    delta_len);
745 	if (delta == NULL)
746 		return got_error_from_errno();
747 	/* delta is freed in got_object_close() */
748 	deltas->nentries++;
749 	SIMPLEQ_INSERT_HEAD(&deltas->entries, delta, entry);
750 	return NULL;
751 }
752 
753 static const struct got_error *
754 resolve_offset_delta(struct got_delta_chain *deltas,
755     struct got_repository *repo, FILE *packfile, const char *path_packfile,
756     off_t delta_offset,size_t tslen, int delta_type, size_t delta_size)
757 
758 {
759 	const struct got_error *err;
760 	off_t base_offset;
761 	uint8_t base_type;
762 	uint64_t base_size;
763 	size_t base_tslen;
764 	off_t delta_data_offset;
765 	uint8_t *delta_buf;
766 	size_t delta_len;
767 
768 	err = parse_offset_delta(&base_offset, packfile, delta_offset);
769 	if (err)
770 		return err;
771 
772 	delta_data_offset = ftello(packfile);
773 	if (delta_data_offset == -1)
774 		return got_error_from_errno();
775 
776 	err = got_inflate_to_mem(&delta_buf, &delta_len, packfile);
777 	if (err)
778 		return err;
779 
780 	err = add_delta(deltas, path_packfile, delta_offset, tslen,
781 	    delta_type, delta_size, delta_data_offset, delta_buf, delta_len);
782 	if (err)
783 		return err;
784 
785 	/* An offset delta must be in the same packfile. */
786 	if (fseeko(packfile, base_offset, SEEK_SET) != 0)
787 		return got_error_from_errno();
788 
789 	err = parse_object_type_and_size(&base_type, &base_size, &base_tslen,
790 	    packfile);
791 	if (err)
792 		return err;
793 
794 	return resolve_delta_chain(deltas, repo, packfile, path_packfile,
795 	    base_offset, base_tslen, base_type, base_size);
796 }
797 
798 static const struct got_error *
799 resolve_ref_delta(struct got_delta_chain *deltas, struct got_repository *repo,
800     FILE *packfile, const char *path_packfile, off_t delta_offset,
801     size_t tslen, int delta_type, size_t delta_size)
802 {
803 	const struct got_error *err;
804 	struct got_object_id id;
805 	struct got_packidx_v2_hdr *packidx;
806 	int idx;
807 	off_t base_offset;
808 	uint8_t base_type;
809 	uint64_t base_size;
810 	size_t base_tslen;
811 	size_t n;
812 	char *path_base_packfile;
813 	struct got_pack *base_pack;
814 	off_t delta_data_offset;
815 	uint8_t *delta_buf;
816 	size_t delta_len;
817 
818 	n = fread(&id, sizeof(id), 1, packfile);
819 	if (n != 1)
820 		return got_ferror(packfile, GOT_ERR_IO);
821 
822 	delta_data_offset = ftello(packfile);
823 	if (delta_data_offset == -1)
824 		return got_error_from_errno();
825 
826 	err = got_inflate_to_mem(&delta_buf, &delta_len, packfile);
827 	if (err)
828 		return err;
829 
830 	err = add_delta(deltas, path_packfile, delta_offset, tslen,
831 	    delta_type, delta_size, delta_data_offset, delta_buf, delta_len);
832 	if (err)
833 		return err;
834 
835 	err = search_packidx(&packidx, &idx, repo, &id);
836 	if (err)
837 		return err;
838 
839 	base_offset = get_object_offset(packidx, idx);
840 	if (base_offset == (uint64_t)-1) {
841 		return got_error(GOT_ERR_BAD_PACKIDX);
842 	}
843 
844 	err = get_packfile_path(&path_base_packfile, repo, packidx);
845 	if (err)
846 		return err;
847 
848 	base_pack = get_cached_pack(path_base_packfile, repo);
849 	if (base_pack == NULL) {
850 		err = cache_pack(&base_pack, path_base_packfile, NULL, repo);
851 		if (err)
852 			goto done;
853 	}
854 
855 	if (fseeko(base_pack->packfile, base_offset, SEEK_SET) != 0) {
856 		err = got_error_from_errno();
857 		goto done;
858 	}
859 
860 	err = parse_object_type_and_size(&base_type, &base_size, &base_tslen,
861 	    base_pack->packfile);
862 	if (err)
863 		goto done;
864 
865 	err = resolve_delta_chain(deltas, repo, base_pack->packfile,
866 	    path_base_packfile, base_offset, base_tslen, base_type,
867 	    base_size);
868 done:
869 	free(path_base_packfile);
870 	return err;
871 }
872 
873 static const struct got_error *
874 resolve_delta_chain(struct got_delta_chain *deltas, struct got_repository *repo,
875     FILE *packfile, const char *path_packfile, off_t delta_offset, size_t tslen,
876     int delta_type, size_t delta_size)
877 {
878 	const struct got_error *err = NULL;
879 
880 	switch (delta_type) {
881 	case GOT_OBJ_TYPE_COMMIT:
882 	case GOT_OBJ_TYPE_TREE:
883 	case GOT_OBJ_TYPE_BLOB:
884 	case GOT_OBJ_TYPE_TAG:
885 		/* Plain types are the final delta base. Recursion ends. */
886 		err = add_delta(deltas, path_packfile, delta_offset, tslen,
887 		    delta_type, delta_size, 0, NULL, 0);
888 		break;
889 	case GOT_OBJ_TYPE_OFFSET_DELTA:
890 		err = resolve_offset_delta(deltas, repo, packfile,
891 		    path_packfile, delta_offset, tslen, delta_type,
892 		    delta_size);
893 		break;
894 	case GOT_OBJ_TYPE_REF_DELTA:
895 		err = resolve_ref_delta(deltas, repo, packfile,
896 		    path_packfile, delta_offset, tslen, delta_type,
897 		    delta_size);
898 		break;
899 	default:
900 		return got_error(GOT_ERR_OBJ_TYPE);
901 	}
902 
903 	return err;
904 }
905 
906 static const struct got_error *
907 open_delta_object(struct got_object **obj, struct got_repository *repo,
908     struct got_packidx_v2_hdr *packidx, const char *path_packfile,
909     FILE *packfile, struct got_object_id *id, off_t offset, size_t tslen,
910     int delta_type, size_t delta_size)
911 {
912 	const struct got_error *err = NULL;
913 	int resolved_type;
914 
915 	*obj = calloc(1, sizeof(**obj));
916 	if (*obj == NULL)
917 		return got_error_from_errno();
918 
919 	(*obj)->flags = 0;
920 	(*obj)->hdrlen = 0;
921 	(*obj)->size = 0; /* Not known because deltas aren't applied yet. */
922 	memcpy(&(*obj)->id, id, sizeof((*obj)->id));
923 	(*obj)->pack_offset = offset + tslen;
924 
925 	(*obj)->path_packfile = strdup(path_packfile);
926 	if ((*obj)->path_packfile == NULL) {
927 		err = got_error_from_errno();
928 		goto done;
929 	}
930 	(*obj)->flags |= GOT_OBJ_FLAG_PACKED;
931 
932 	SIMPLEQ_INIT(&(*obj)->deltas.entries);
933 	(*obj)->flags |= GOT_OBJ_FLAG_DELTIFIED;
934 
935 	err = resolve_delta_chain(&(*obj)->deltas, repo, packfile,
936 	    path_packfile, offset, tslen, delta_type, delta_size);
937 	if (err)
938 		goto done;
939 
940 	err = got_delta_chain_get_base_type(&resolved_type, &(*obj)->deltas);
941 	if (err)
942 		goto done;
943 	(*obj)->type = resolved_type;
944 
945 done:
946 	if (err) {
947 		got_object_close(*obj);
948 		*obj = NULL;
949 	}
950 	return err;
951 }
952 
953 static const struct got_error *
954 open_packed_object(struct got_object **obj, struct got_repository *repo,
955     struct got_packidx_v2_hdr *packidx, int idx, struct got_object_id *id)
956 {
957 	const struct got_error *err = NULL;
958 	off_t offset;
959 	char *path_packfile;
960 	struct got_pack *pack;
961 	uint8_t type;
962 	uint64_t size;
963 	size_t tslen;
964 
965 	*obj = NULL;
966 
967 	offset = get_object_offset(packidx, idx);
968 	if (offset == (uint64_t)-1)
969 		return got_error(GOT_ERR_BAD_PACKIDX);
970 
971 	err = get_packfile_path(&path_packfile, repo, packidx);
972 	if (err)
973 		return err;
974 
975 	pack = get_cached_pack(path_packfile, repo);
976 	if (pack == NULL) {
977 		err = cache_pack(&pack, path_packfile, packidx, repo);
978 		if (err)
979 			goto done;
980 	}
981 
982 	if (fseeko(pack->packfile, offset, SEEK_SET) != 0) {
983 		err = got_error_from_errno();
984 		goto done;
985 	}
986 
987 	err = parse_object_type_and_size(&type, &size, &tslen, pack->packfile);
988 	if (err)
989 		goto done;
990 
991 	switch (type) {
992 	case GOT_OBJ_TYPE_COMMIT:
993 	case GOT_OBJ_TYPE_TREE:
994 	case GOT_OBJ_TYPE_BLOB:
995 	case GOT_OBJ_TYPE_TAG:
996 		err = open_plain_object(obj, path_packfile, id, type,
997 		    offset + tslen, size);
998 		break;
999 
1000 	case GOT_OBJ_TYPE_OFFSET_DELTA:
1001 	case GOT_OBJ_TYPE_REF_DELTA:
1002 		err = open_delta_object(obj, repo, packidx, path_packfile,
1003 		    pack->packfile, id, offset, tslen, type, size);
1004 		break;
1005 
1006 	default:
1007 		err = got_error(GOT_ERR_OBJ_TYPE);
1008 		goto done;
1009 	}
1010 done:
1011 	free(path_packfile);
1012 	return err;
1013 }
1014 
1015 const struct got_error *
1016 got_packfile_open_object(struct got_object **obj, struct got_object_id *id,
1017     struct got_repository *repo)
1018 {
1019 	const struct got_error *err = NULL;
1020 	struct got_packidx_v2_hdr *packidx = NULL;
1021 	int idx;
1022 
1023 	err = search_packidx(&packidx, &idx, repo, id);
1024 	if (err)
1025 		return err;
1026 
1027 	err = open_packed_object(obj, repo, packidx, idx, id);
1028 	if (err)
1029 		return err;
1030 
1031 	err = cache_pack(NULL, (*obj)->path_packfile, packidx, repo);
1032 	return err;
1033 }
1034 
1035 static const struct got_error *
1036 get_delta_chain_max_size(uint64_t *max_size, struct got_delta_chain *deltas)
1037 {
1038 	struct got_delta *delta;
1039 	uint64_t base_size = 0, result_size = 0;
1040 
1041 	*max_size = 0;
1042 	SIMPLEQ_FOREACH(delta, &deltas->entries, entry) {
1043 		/* Plain object types are the delta base. */
1044 		if (delta->type != GOT_OBJ_TYPE_COMMIT &&
1045 		    delta->type != GOT_OBJ_TYPE_TREE &&
1046 		    delta->type != GOT_OBJ_TYPE_BLOB &&
1047 		    delta->type != GOT_OBJ_TYPE_TAG) {
1048 			const struct got_error *err;
1049 			err = got_delta_get_sizes(&base_size, &result_size,
1050 			    delta->delta_buf, delta->delta_len);
1051 			if (err)
1052 				return err;
1053 		} else
1054 			base_size = delta->size;
1055 		if (base_size > *max_size)
1056 			*max_size = base_size;
1057 		if (result_size > *max_size)
1058 			*max_size = result_size;
1059 	}
1060 
1061 	return NULL;
1062 }
1063 
1064 static const struct got_error *
1065 dump_delta_chain_to_file(size_t *result_size, struct got_delta_chain *deltas,
1066     FILE *outfile, struct got_repository *repo)
1067 {
1068 	const struct got_error *err = NULL;
1069 	struct got_delta *delta;
1070 	FILE *base_file = NULL, *accum_file = NULL;
1071 	uint8_t *base_buf = NULL, *accum_buf = NULL;
1072 	size_t accum_size = 0;
1073 	uint64_t max_size;
1074 	int n = 0;
1075 
1076 	*result_size = 0;
1077 
1078 	if (SIMPLEQ_EMPTY(&deltas->entries))
1079 		return got_error(GOT_ERR_BAD_DELTA_CHAIN);
1080 
1081 	/* We process small enough files entirely in memory for speed. */
1082 	err = get_delta_chain_max_size(&max_size, deltas);
1083 	if (err)
1084 		return err;
1085 	if (max_size < GOT_DELTA_RESULT_SIZE_CACHED_MAX) {
1086 		accum_buf = malloc(max_size);
1087 		if (accum_buf == NULL)
1088 			return got_error_from_errno();
1089 	} else {
1090 		base_file = got_opentemp();
1091 		if (base_file == NULL)
1092 			return got_error_from_errno();
1093 
1094 		accum_file = got_opentemp();
1095 		if (accum_file == NULL) {
1096 			err = got_error_from_errno();
1097 			fclose(base_file);
1098 			return err;
1099 		}
1100 	}
1101 
1102 	/* Deltas are ordered in ascending order. */
1103 	SIMPLEQ_FOREACH(delta, &deltas->entries, entry) {
1104 		if (n == 0) {
1105 			struct got_pack *pack;
1106 			size_t base_len;
1107 
1108 			/* Plain object types are the delta base. */
1109 			if (delta->type != GOT_OBJ_TYPE_COMMIT &&
1110 			    delta->type != GOT_OBJ_TYPE_TREE &&
1111 			    delta->type != GOT_OBJ_TYPE_BLOB &&
1112 			    delta->type != GOT_OBJ_TYPE_TAG) {
1113 				err = got_error(GOT_ERR_BAD_DELTA_CHAIN);
1114 				goto done;
1115 			}
1116 
1117 			pack = get_cached_pack(delta->path_packfile, repo);
1118 			if (pack == NULL) {
1119 				err = got_error(GOT_ERR_BAD_DELTA_CHAIN);
1120 				goto done;
1121 			}
1122 
1123 			if (fseeko(pack->packfile, delta->offset + delta->tslen,
1124 			    SEEK_SET) != 0) {
1125 				err = got_error_from_errno();
1126 				goto done;
1127 			}
1128 			if (base_file)
1129 				err = got_inflate_to_file(&base_len,
1130 				    pack->packfile, base_file);
1131 			else {
1132 				err = got_inflate_to_mem(&base_buf, &base_len,
1133 				    pack->packfile);
1134 				if (base_len < max_size) {
1135 					uint8_t *p;
1136 					p = reallocarray(base_buf, 1, max_size);
1137 					if (p == NULL) {
1138 						err = got_error_from_errno();
1139 						goto done;
1140 					}
1141 					base_buf = p;
1142 				}
1143 			}
1144 			if (err)
1145 				goto done;
1146 			n++;
1147 			if (base_file)
1148 				rewind(base_file);
1149 			continue;
1150 		}
1151 
1152 		if (base_buf) {
1153 			err = got_delta_apply_in_mem(base_buf, delta->delta_buf,
1154 			    delta->delta_len, accum_buf, &accum_size);
1155 			n++;
1156 		} else {
1157 			err = got_delta_apply(base_file, delta->delta_buf,
1158 			    delta->delta_len,
1159 			    /* Final delta application writes to output file. */
1160 			    ++n < deltas->nentries ? accum_file : outfile,
1161 			    &accum_size);
1162 		}
1163 		if (err)
1164 			goto done;
1165 
1166 		if (n < deltas->nentries) {
1167 			/* Accumulated delta becomes the new base. */
1168 			if (base_buf) {
1169 				uint8_t *tmp = accum_buf;
1170 				accum_buf = base_buf;
1171 				base_buf = tmp;
1172 			} else {
1173 				FILE *tmp = accum_file;
1174 				accum_file = base_file;
1175 				base_file = tmp;
1176 				rewind(base_file);
1177 				rewind(accum_file);
1178 			}
1179 		}
1180 	}
1181 
1182 done:
1183 	free(base_buf);
1184 	if (accum_buf) {
1185 		size_t len = fwrite(accum_buf, 1, accum_size, outfile);
1186 		free(accum_buf);
1187 		if (len != accum_size)
1188 			return got_ferror(outfile, GOT_ERR_IO);
1189 	}
1190 	if (base_file)
1191 		fclose(base_file);
1192 	if (accum_file)
1193 		fclose(accum_file);
1194 	rewind(outfile);
1195 	if (err == NULL)
1196 		*result_size = accum_size;
1197 	return err;
1198 }
1199 
1200 static const struct got_error *
1201 dump_delta_chain_to_mem(uint8_t **outbuf, size_t *outlen,
1202     struct got_delta_chain *deltas, struct got_repository *repo)
1203 {
1204 	const struct got_error *err = NULL;
1205 	struct got_delta *delta;
1206 	uint8_t *base_buf = NULL, *accum_buf = NULL;
1207 	size_t accum_size;
1208 	uint64_t max_size;
1209 	int n = 0;
1210 
1211 	*outbuf = NULL;
1212 	*outlen = 0;
1213 
1214 	if (SIMPLEQ_EMPTY(&deltas->entries))
1215 		return got_error(GOT_ERR_BAD_DELTA_CHAIN);
1216 
1217 	err = get_delta_chain_max_size(&max_size, deltas);
1218 	if (err)
1219 		return err;
1220 	accum_buf = malloc(max_size);
1221 	if (accum_buf == NULL)
1222 		return got_error_from_errno();
1223 
1224 	/* Deltas are ordered in ascending order. */
1225 	SIMPLEQ_FOREACH(delta, &deltas->entries, entry) {
1226 		if (n == 0) {
1227 			struct got_pack *pack;
1228 			size_t base_len;
1229 
1230 			/* Plain object types are the delta base. */
1231 			if (delta->type != GOT_OBJ_TYPE_COMMIT &&
1232 			    delta->type != GOT_OBJ_TYPE_TREE &&
1233 			    delta->type != GOT_OBJ_TYPE_BLOB &&
1234 			    delta->type != GOT_OBJ_TYPE_TAG) {
1235 				err = got_error(GOT_ERR_BAD_DELTA_CHAIN);
1236 				goto done;
1237 			}
1238 
1239 			pack = get_cached_pack(delta->path_packfile, repo);
1240 			if (pack == NULL) {
1241 				err = got_error(GOT_ERR_BAD_DELTA_CHAIN);
1242 				goto done;
1243 			}
1244 
1245 			if (fseeko(pack->packfile, delta->offset + delta->tslen,
1246 			    SEEK_SET) != 0) {
1247 				err = got_error_from_errno();
1248 				goto done;
1249 			}
1250 			err = got_inflate_to_mem(&base_buf, &base_len,
1251 			    pack->packfile);
1252 			if (base_len < max_size) {
1253 				uint8_t *p;
1254 				p = reallocarray(base_buf, 1, max_size);
1255 				if (p == NULL) {
1256 					err = got_error_from_errno();
1257 					goto done;
1258 				}
1259 				base_buf = p;
1260 			}
1261 			if (err)
1262 				goto done;
1263 			n++;
1264 			continue;
1265 		}
1266 
1267 		err = got_delta_apply_in_mem(base_buf, delta->delta_buf,
1268 		    delta->delta_len, accum_buf, &accum_size);
1269 		n++;
1270 		if (err)
1271 			goto done;
1272 
1273 		if (n < deltas->nentries) {
1274 			/* Accumulated delta becomes the new base. */
1275 			uint8_t *tmp = accum_buf;
1276 			accum_buf = base_buf;
1277 			base_buf = tmp;
1278 		}
1279 	}
1280 
1281 done:
1282 	free(base_buf);
1283 	if (err) {
1284 		free(accum_buf);
1285 		*outbuf = NULL;
1286 		*outlen = 0;
1287 	} else {
1288 		*outbuf = accum_buf;
1289 		*outlen = accum_size;
1290 	}
1291 	return err;
1292 }
1293 
1294 const struct got_error *
1295 got_packfile_extract_object(FILE **f, struct got_object *obj,
1296     struct got_repository *repo)
1297 {
1298 	const struct got_error *err = NULL;
1299 
1300 	if ((obj->flags & GOT_OBJ_FLAG_PACKED) == 0)
1301 		return got_error(GOT_ERR_OBJ_NOT_PACKED);
1302 
1303 	*f = got_opentemp();
1304 	if (*f == NULL) {
1305 		err = got_error(GOT_ERR_FILE_OPEN);
1306 		goto done;
1307 	}
1308 
1309 	if ((obj->flags & GOT_OBJ_FLAG_DELTIFIED) == 0) {
1310 		struct got_pack *pack;
1311 
1312 		pack = get_cached_pack(obj->path_packfile, repo);
1313 		if (pack == NULL) {
1314 			err = cache_pack(&pack, obj->path_packfile, NULL, repo);
1315 			if (err)
1316 				goto done;
1317 		}
1318 
1319 		if (fseeko(pack->packfile, obj->pack_offset, SEEK_SET) != 0) {
1320 			err = got_error_from_errno();
1321 			goto done;
1322 		}
1323 
1324 		err = got_inflate_to_file(&obj->size, pack->packfile, *f);
1325 	} else
1326 		err = dump_delta_chain_to_file(&obj->size, &obj->deltas, *f,
1327 		    repo);
1328 done:
1329 	if (err && *f) {
1330 		fclose(*f);
1331 		*f = NULL;
1332 	}
1333 	return err;
1334 }
1335 
1336 const struct got_error *
1337 got_packfile_extract_object_to_mem(uint8_t **buf, size_t *len,
1338     struct got_object *obj, struct got_repository *repo)
1339 {
1340 	const struct got_error *err = NULL;
1341 
1342 	if ((obj->flags & GOT_OBJ_FLAG_PACKED) == 0)
1343 		return got_error(GOT_ERR_OBJ_NOT_PACKED);
1344 
1345 	if ((obj->flags & GOT_OBJ_FLAG_DELTIFIED) == 0) {
1346 		struct got_pack *pack;
1347 
1348 		pack = get_cached_pack(obj->path_packfile, repo);
1349 		if (pack == NULL) {
1350 			err = cache_pack(&pack, obj->path_packfile, NULL, repo);
1351 			if (err)
1352 				goto done;
1353 		}
1354 
1355 		if (fseeko(pack->packfile, obj->pack_offset, SEEK_SET) != 0) {
1356 			err = got_error_from_errno();
1357 			goto done;
1358 		}
1359 
1360 		err = got_inflate_to_mem(buf, len, pack->packfile);
1361 	} else
1362 		err = dump_delta_chain_to_mem(buf, len, &obj->deltas, repo);
1363 done:
1364 	return err;
1365 }