Commit Briefs

41861f2b47 Thomas Adam

avoid a pointless malloc/free in got_reflist_insert() in my previous fix

suggested by op@


21de8138fe Thomas Adam

detect packed vs. on-disk reference collision when listing refs

ok op@


3bfa5a0662 Thomas Adam

Prevent use-after-free of packed_refs_path in error path.

Found by llvm's scan-build. OK stsp


8b925c6ccd Thomas Adam

portable: add back sys/queue.h

Now that the handling of including sys/queue.h is better, there's no need to remove those lines from the source. Copy the location of those original sys/queue.h lines from upstream at the same line number, so as to avoid any conflicts in the future.


0c6f49baf2 Thomas Adam

build with -Wwrite-strings

Throwing this into the mix for a while, we can always get rid of it again if it becomes annoying. No objections from stsp@



48b4f23903 Thomas Adam

wrap overlong lines


c56c5d8a20 Thomas Adam

add "e" (close-on-exec) flag to fopen(3) calls

suggested by millert ok thomas_adam


a729e2888f Thomas Adam

fall back to comparison by name when refs have the same timestamp

This fixes an issue where some references were missing from lists of references sorted by timestamp.




3bfadbd404 Thomas Adam

allow sorting references by timestamp in tog


fd3a2fe6d4 Thomas Adam

speed up 'got histedit -l' and 'got rebase -l'

Cache commit timestamps in struct got_reference in case we are sorting references by commit timestamp. This avoids opening and closing commits every time we compare two references with each other. ok thomas.adam


b3dc731fef Thomas Adam

got_sha1_digest_to_str() writes to char *

ok stsp


92a9e85d28 Thomas Adam

portable: add FreeBSD support

This adds the capability to compile got-portable on FreeBSD.


dd038bc6ec Thomas Adam

portable: initial Linux compilation

This commit modifies the GoT main branch to be able to compile it under linux.


abc59930d5 Christian Weisgerber

indentation fixes


63e5aa5c34 Stefan Sperling

Expose got_ref_name_is_valid() for general purpose use.

This will be needed for a future 'got send' command.


cce2f4851e Stefan Sperling

expose got_ref_resolve_symbolic() at the public library API

This will be needed by a future 'got send' command.


72acb3d8f4 Stefan Sperling

remove unused 'repo' argument from got_reflist_insert()


3f338f0a09 Stefan Sperling

track the last modification time of references



779e1159b2 Stefan Sperling

expose the reflist_insert() helper function as got_reflist_insert()

This will be needed by 'gotadmin pack'.


57c1819858 Stefan Sperling

validate reference names in open_ref()

This catches invalid reference names passed to 'got ref -l' and will also be needed to validate reference names passed to a future 'gotadmin pack' command. ok naddy@


af8a5c4afb Stefan Sperling

plug a memory leak in got_ref_list_free()

Code which inserts a reference into a reflist passes ownership of this reference to the list. However, got_ref_list_free() never closed such references, which resulted in a memory leak. ok tracey