Commit Briefs

3d8e0c5ede Stefan Sperling

avoid a pointless malloc/free in got_reflist_insert() in my previous fix

suggested by op@


7db2b0ddc6 Stefan Sperling

detect packed vs. on-disk reference collision when listing refs

ok op@


c3821befbe Florian Obser

Prevent use-after-free of packed_refs_path in error path.

Found by llvm's scan-build. OK stsp


58e31a80da Omar Polo

build with -Wwrite-strings

Throwing this into the mix for a while, we can always get rid of it again if it becomes annoying. No objections from stsp@


bb6672b6ab Theo Buehler

make sure callers of got_object_idset_add() free data.


c0df59665d Stefan Sperling

wrap overlong lines


00fe21f262 Stefan Sperling

add "e" (close-on-exec) flag to fopen(3) calls

suggested by millert ok thomas_adam


428649877c Stefan Sperling

fall back to comparison by name when refs have the same timestamp

This fixes an issue where some references were missing from lists of references sorted by timestamp.




7f66531d28 Stefan Sperling

allow sorting references by timestamp in tog


2c9e323b3e Stefan Sperling

speed up 'got histedit -l' and 'got rebase -l'

Cache commit timestamps in struct got_reference in case we are sorting references by commit timestamp. This avoids opening and closing commits every time we compare two references with each other. ok thomas.adam


9dd14b990b Christian Weisgerber

got_sha1_digest_to_str() writes to char *

ok stsp


abc59930d5 Christian Weisgerber

indentation fixes


63e5aa5c34 Stefan Sperling

Expose got_ref_name_is_valid() for general purpose use.

This will be needed for a future 'got send' command.


cce2f4851e Stefan Sperling

expose got_ref_resolve_symbolic() at the public library API

This will be needed by a future 'got send' command.


72acb3d8f4 Stefan Sperling

remove unused 'repo' argument from got_reflist_insert()


3f338f0a09 Stefan Sperling

track the last modification time of references



779e1159b2 Stefan Sperling

expose the reflist_insert() helper function as got_reflist_insert()

This will be needed by 'gotadmin pack'.


57c1819858 Stefan Sperling

validate reference names in open_ref()

This catches invalid reference names passed to 'got ref -l' and will also be needed to validate reference names passed to a future 'gotadmin pack' command. ok naddy@


af8a5c4afb Stefan Sperling

plug a memory leak in got_ref_list_free()

Code which inserts a reference into a reflist passes ownership of this reference to the list. However, got_ref_list_free() never closed such references, which resulted in a memory leak. ok tracey


e600f1246e Stefan Sperling

ensure that old commits remain referenced after rebase and histedit

Create automatic "backup" references which ensure that objects from the pre-rebase or pre-histedit state remain in the repository. A new -l option for 'got rebase' and 'got histedit' lists old commits. This makes it easier to recover from botched rebase or histedit operations. Removal of such objects currently requires got ref -d and git-gc. This will be made more convenient in the future. testing and ok jrick


56b63ca4ab Stefan Sperling

make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere

ok millert, naddy


7a90b6809c Christian Weisgerber

oops, initialize linesize before calling getline(3); from millert