Commit Briefs

Omar Polo

dial: fix quoting for git-shell

Escape the path to the repository when connecting via SSH. This is needed if the path contains spaces, quotes or other "funny" characters, but also by git-shell which requires the argument to be surrounded by single-quote characters. Issue with git-shell reported by James Cook, fix based on an initial diff by stsp@. ok stsp@

diff | patch | tree

Omar Polo

add missing freaddrinfo

also spotted by valgrind. ok stsp@

diff | patch | tree

Omar Polo

build with -Wwrite-strings

Throwing this into the mix for a while, we can always get rid of it again if it becomes annoying. No objections from stsp@

diff | patch | tree

Omar Polo

build with -Wmissing-prototypes

ok stsp@

diff | patch | tree

Christian Weisgerber

fix level of indirection

ok stsp

diff | patch | tree

Stefan Sperling

make the URI parser tolerate trailing slashes at the end of the input URI

ok naddy

diff | patch | tree

Christian Weisgerber

assert against accidentally overflowing argv[] in got_dial_ssh()

ok stsp

diff | patch | tree

Stefan Sperling

rename got_fetch_parse_uri() to got_dial_parse_uri()

This function is now being used by both 'got fetch' and 'got send' so its former name was misleading.

diff | patch | tree

Stefan Sperling

move duplicated dial_ssh() and dial_git() functions into a common file

These functions are used by 'got send' and 'got fetch' in order to open network connections to a server. Move them into new file lib/dial.c and declare relevant functions in got_dial.h and lib/got_lib_dial.h. No functional change.

diff | patch | tree