Commit Briefs

Thomas Adam

gotwebd: minor tweaks

drop: - a tautological s[strlen(s)] == '\0' - a few duplicates checks - a lone if (error) when it's always NULL - an extra NULL check part of a bigger diff that's ok stsp@


Thomas Adam

gotwebd: plug leak in fcgi_parse_params

fcgi_parse_params parses fastcgi parameters into a list. (This is a leftover from slowcgi where that list is later used to populate the environment of the CGI process.) However, this list is never looked at and its memory never released, so just drop it. Make the matching on fastcgi parameters name strictier by checking also that the length is the one we expect; otherwise we might pick up parameters with the same prefix string (i.e. FOO vs FOO_WITH_SUFFIX) While here turn some bcopy into memcpy and simplify some if-nesting too. Fix the reading from an un-initialized pointer that I introduced in a previous commit. ok stsp@



Thomas Adam

gotwebd: refactor gotweb_load_got_path

- don't special case ".got": if it's a work-tree gotwebd will just fail soon enough. Suggested by stsp@ - avoid an strdup. - drop `opened' to make it easier to follow what's going on. ok stsp@


Thomas Adam

make gotwebd cache open repository handles in struct server

ok op@


Thomas Adam

indent


Thomas Adam

gotwebd: plug two memory leak and drop unneeded ternary

ok tracey@



Thomas Adam

tog: remove gcc ternary if extension

ok stsp@


Thomas Adam

add a gotwebd todo item


Thomas Adam

remove gotwebd TODO items that are done


Thomas Adam

gotwebd: drop the x bit from assets in-tree and also when installing

ok stsp@


Thomas Adam

wrap overlong line in diff.sh


Thomas Adam

fix NULL deref in the object cache debug code; ok stsp@

it's not in code compiled by default as it's under GOT_OBJ_CACHE_DEBUG.






Thomas Adam

mark check_refcount as static

needed because of -Wmissig-prototypes; ok stsp@





Thomas Adam

gotwebd: use SCRIPT_NAME to derive URLs

This makes gotwebd use SCRIPT_NAME instead of the DOCUMENT_ROOT fastcgi param to generate the links to the assets and changes some links so every page is consistently linked with a relative URL. It allows to drop the `root "/"' in the location for fastcgi and, as a bonus, also makes possible to run gotwebd on non "/" paths. ok stsp@


Thomas Adam

gotwebd: garbage collect %token FCGI_SOCKET

ok stsp@