Commit Briefs
gotwebd: render all the datetimes in a time tag
fixes an unused variable that should have been dropped in previous commit too. ok stsp@
gotwebd: don't loose track of the file in commit listing
When browsing the history of a file, the more button should generate a link containing the file= parameter, otherwise we switch back to the 'global' history. Spotted by stsp@
gotweb: style improvements
First round of polishing, css simplification and responsiveness for gotwebd. The new HTML is now actually usable on text-only browsers and the fonts are bigger on smaller screens; close to no changes for "normal" desktop usage. A few regressions were spotted by Lucas on IRC, thanks! No objections from stsp@
bubble up got_repo_commits()
now that got_get_repo_commits() doesn't look at `action' we can stop fetching the commits during the rendering and bubble up the call. This yields better error messages and better replies codes on failure.
gotwebd: lower log priority of unexpected disconnections
no need to be so loud when a client disconnects earlier than expected, log it only in verbose mode. Don't log GOT_ERR_CANCELLED too since that is only used to communicate the callers that we need to stop. ok stsp@
gotwebd: provide gotweb_render_page() entrypoint for all pages
simplify gotweb_process_request more, handling all the pages inside the big switch. There's only one entrypoint for rendering the templates gotweb_render_page() that takes the page' content as argument. The only real difference is that gotweb_render_index() now skips directory entries which fails to handle. ok tracey@
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done mechanically with find . -iname \*.[cy] -exec sam {} + X ,x/<sha1\.h>/i/\n#include <sha2.h>
gotwebd: add missing colon after 'Message' in diff view
Patch by Josiah Frentsos, thanks!
gotwebd: fix briefs/tags navigation overlap
Introduces a separate field for the "next" button (now called "More") and adjusted the CSS/HTML so it's used. Finally, drops the old code used to handle the pagination for the BRIEFS/COMMITS cases. Needs a small hack for the time being, setting the action to TAGS. This is due how qs->action is changed in gotweb.c while handling the request. ok jamsek
gotwebd: templateify gotweb_render_blame
ok and tweak from jamsek
gotwebd: bubble up got_get_repo_tags
This bubbles up the call to got_get_repo_tags from gotweb_render_tags to its caller, gotweb_process_request and gotweb_render_summary. It helps simplifying gotweb_render_summary and making it easier to templateify, but also helps in untangling a bit the code. At this point gotweb_render_tags becomes just a wrapper to gotweb_render_tags_tmpl so switch completely to it. ok jamsek
gotwebd: templateify gotweb_render_branches
no functional change intended. Bubble up the allocation of the reflist from gotweb_render_branches to gotweb_render_summary (its only caller) and rewrite it as a template. ok tracey@
gotwebd: use from/via in gotweb_render_commits too
like the previous, show also the committer if different from the author.
gotwebd: make commit page more like `got log' / tog
- drop the "diff commit1 commit2" header; it's already showed in the body of the diff. - hide the tree id (not that useful to show.) - show the committer if different from the author. - use From/Via for Committer/Author. discussed with jamsek, stsp, tracey ok jamsek tracey
gotwebd: templateify gotweb_render_diff
ok tracey@; rebased after recent changes.
gotwebd: templateify gotweb_render_tag
ok tracey@
gotwebd: templateify gotweb_render_tags
ok tracey@