Commit Briefs

Thomas Adam

move comment

it describes bump_base_commit_id_everywhere, not its per-entry callback bump_base_commit_id.


Thomas Adam

zap double empty line


Thomas Adam

typo


Thomas Adam

got-read-gitconfig: send key-value pairs for extensions

Most extension allow only for a boolean value so the current behaviour of just sending the extension with a trueish value is fine. However, some extensions that we could eventually support (like "objectformat") have a string value. This is a preparatory step towards that. ok stsp@


Thomas Adam

replace got_repo_get_gitconfig_extensions with got_repo_has_extension

got_repo_get_gitconfig_extensions is only used in gotadmin to check if the preciousObjects extension is active; let's replace it with a function that just checks whether a certain extension is active. It simplifies future changes to the extensions handling. ok stsp@


Thomas Adam

fix building of few regress

after got_object_id_hex was introduced and used in error.c, the building of delta, deltify and path failed due to missing symbols. Spotted by stsp and tracey, ok stsp


Thomas Adam

got_object_open: copy whole id not just the sha1

ok stsp@


Thomas Adam

introduce got_error_checksum

ok stsp@


Thomas Adam

introduce got_object_id_hex to replace some got_sha1_digest_to_str()

It's an analogous to got_object_id_str but writes to the given buffer. ok + improvements by stsp@


Thomas Adam

rename a function for clarity



Thomas Adam

typo and style(9): do not use function calls in initialisers.

ok stsp@


Thomas Adam

fix mistaken instances returning NULL instead of err

While here, for consistency, check dup() return value for -1 rather than < 0. ok stsp@


Thomas Adam

fix missed doc update of new 'got fetch' behaviour

ok stsp@


Thomas Adam

delete unused code

serializes an id to a local buffer before before returning. ok stsp


Thomas Adam

yet another gotwebd TODO

writing everything down to avoid forgetting stuff...


Thomas Adam

one more TODO for gotwebd



Thomas Adam

gotwebd: fix briefs/tags navigation overlap

Introduces a separate field for the "next" button (now called "More") and adjusted the CSS/HTML so it's used. Finally, drops the old code used to handle the pagination for the BRIEFS/COMMITS cases. Needs a small hack for the time being, setting the action to TAGS. This is due how qs->action is changed in gotweb.c while handling the request. ok jamsek


Thomas Adam

zap trailing whitespace


Thomas Adam

another memcmp -> got_object_id_cmp



Thomas Adam

typo in comment

it serializes the struct got_imsg_tree_entry, not tree_object. grep aid.



Thomas Adam

got: make fetch default to the work tree's current branch

As per stsp's todo item, if invoked in a work tree, make 'got fetch' default to fetching the work tree's current branch instead of the branch pointed to by the remote repository's HEAD. ok stsp@ and op@