Commit Briefs


Thomas Adam

portable: remove imsg.h

Allow imsg.h to be checked for portably.


Thomas Adam

mark got_error_fmt as printf-like and fix the arisen errors

ok stsp@


Thomas Adam

portable: add back sys/queue.h

Now that the handling of including sys/queue.h is better, there's no need to remove those lines from the source. Copy the location of those original sys/queue.h lines from upstream at the same line number, so as to avoid any conflicts in the future.


Thomas Adam

implement support for commit coloring in got-read-pack for speed

ok op, tracey


Thomas Adam

build with -Wwrite-strings

Throwing this into the mix for a while, we can always get rid of it again if it becomes annoying. No objections from stsp@



Thomas Adam

build with -Wmissing-prototypes

ok stsp@


Thomas Adam

let got-read-pack be explicit about whether it could enumerate all objects

This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@



Thomas Adam

Bring back object enumeration inside got-read-pack as a fast path.

The problem that was found in the earlier version has been fixed. ok op@


Thomas Adam

portable: remove endian.h

This is included portably.


Thomas Adam

revert object enumeration in got-read-pack for now; needs more work

This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@


Thomas Adam

free id and path in load_packed_tree_ids() on error, else they would leak

pointed out by op@


Thomas Adam

implement object enumeration support in got-read-pack

ok op@


Thomas Adam

map delta cache file into memory if possible while writing a pack file

with a fix from + ok op@


Thomas Adam

fix a bug in findwixt() which caused pack files with missing parent commits

The 'nskip' variable is supposed to reflect commits which are waiting on the queue and have the 'skip' color. Only increment 'nskip' when adding such commits to the queue. Problem observed with got send -T and a tag pointing to a deleted branch. Test to reproduce the bug written by op@.


Thomas Adam

use random seeds for murmurhash2

change the three hardcoded seeds to fresh ones generated on demand via arc4random. Suggested/fixed by and ok stsp@


Thomas Adam

include header


Thomas Adam

shrink struct got_pack_meta a bit by removing the have_reused_delta flag

This flag can be expressed as m->reused_delta_offset != 0 because all deltas in valid pack files will be written at a non-zero offset. We allocate a huge number of these structs during packing, so every little bit helps.


Thomas Adam

reduce the amount of memory used for caching deltas during deltification

With files sorted properly for deltification we produce better deltas but end up consuming more memory and risk running into OpenBSD ulimits during packing. To compensate, reduce the threshold for the amount of delta data we store in memory, spooling more deltas into the cache file. ok op@


Thomas Adam

store a path hash instead of a verbatim path in pack meta data

This reduces memory use by gotadmin pack. The goal is to sort files which share a path next to each other for deltification. A hash of the path is good enough for this purpose and consumes less memory than a verbatim copy of the path. Git does something similar. ok op@


Thomas Adam

fix paths stored in pack meta data, improving file deltification

The old code was broken and stored an empty path or filenames, instead of a repository-relative path. Which means we didn't sort files for deltification as was intended. Fixing this provides much better deltas in large pack files written by gotadmin pack -a. In my test case, pack size changed from 2GB to 1.5GB. ok op@



Thomas Adam

map delta cache file into memory if possible while writing a pack file

with a fix from + ok op@