pack_fds_tmp is not always free'd. However, while here, simplify it to not use a temporary array. ok stsp@

in the loop of match_loose_object we allocate a string per directory entry that in some case it was free(3)'d before `continue' or `goto', but not always. Instead, use a more common idiom. ok stsp@

ok op@

set gitconfig_remotes to NULL to avoid a double-free, and reset the global author name/email fields too. ok stsp@

ok op@

got_repo_pack_fds_close will try to close all of the GOT_PACK_NUM_TEMPFILES fds, even the ones that didn't manage to get a value from got_opentempfd(), which would result in a close(0) if we do not initialize to -1 here.

Found by llvm's scan-build (bad free). OK stsp

Found by llvm's scan-build (dead store). OK stsp

It seems as though a merge from some time ago had left some stale changes in place. This brings the two files between upstream and portable back in-line. Noticed by stsp@

Now that the handling of including sys/queue.h is better, there's no need to remove those lines from the source. Copy the location of those original sys/queue.h lines from upstream at the same line number, so as to avoid any conflicts in the future.

ok op, tracey

thanks for all the help massaging this diff

Avoids clobbering open files for delta base/accumulation, leaking file descriptors, and triggering errors from close(2) during got_repo_close() as we try to close the same file descriptor more than once.

found by tracey

This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey

Saves us from doing a malloc/free call for every item on the list. ok op@

otherwise we call got_repo_close with repo being NULL and segfault there. ok stsp

Avoids overhead due to readdir calls while searching a pack index. ok op@