Commit Briefs

Thomas Adam

regress: make cmdline tests sh compatible

Ensure shell scripts can run under more POSIX-restricted shells. OK op@


Thomas Adam

portable: remove ln(1) wrapper

GNU Coreutils is wrapped for some commands which don't offer a portable means to run those commands on non-BSD systems. ln(1) was being used with a non-portable option (-h) which has now been replaced upstream. Therefore, we can remove this wrapper. Patch from Christian "naddy" Weisgerber.


Thomas Adam

regress: replace unportable ln -h option with rm && ln

ok stsp


Thomas Adam

guard MIN() macro against redefinition


Thomas Adam

gotd requires a config file; don't fail silently when gotd.conf cannot be read

Fixes an issue encountered by mlarkin@ where the auth process was working with an empty list of repositories and kept saying it could not find a repository which was obviously listed in gotd.conf. Now we can see errors from fopen() in the logs instead. Old code was copied from gotwebd where the config file is optional.


Thomas Adam

add got_repo_get_object_format()

and use it to avoid hardcoding the digest type in a few places. ok stsp@


Thomas Adam

add xfail test for "got diff" when a commit changed a file to a directory

git diff: diff --git a/alpha b/alpha deleted file mode 100644 index 4a58007..0000000 --- a/alpha +++ /dev/null @@ -1 +0,0 @@ -alpha diff --git a/alpha/beta b/alpha/beta new file mode 100644 index 0000000..65b2df8 --- /dev/null +++ b/alpha/beta @@ -0,0 +1 @@ +beta got diff: diff d973bf45ce9b2b437b5d6352368e8406f9e256e2 34413d01304800f99058a1a42769e92afc534199 commit - d973bf45ce9b2b437b5d6352368e8406f9e256e2 commit + 34413d01304800f99058a1a42769e92afc534199


Thomas Adam

add missed `size' initialization for use with getline(3)

ok tb@



Thomas Adam

make gotd repo_read store want/have commit IDs in ID sets rather than arrays

Currently only used to detect and avoid storing duplicate IDs sent in want and have lines by the client. If in the future we ever wanted to check which IDs the client has already sent us we could now do O(1) hash table lookups rather than iterating arrays. ok op@



Thomas Adam

histedit_parse_list: avoid needless free(line)

getline(3) allows to safely re-use the storage. While here rename `size' to `linesize', `len' to `linelen', and properly initialize `linesize' to zero; suggested by tb@ ok tb@


Thomas Adam

in got.1, clarify what users are expected to do during 'histedit -e'

Gap in the documentation pointed out by James Cook.


Thomas Adam

fall back to vi(1) instead of ed(1) if neither EDITOR nor VISUAL are set

ed users are reading files with their minds rather then their eyes, and might therefore be missing important visual clues we write into files before the user gets to edit them. Use of vi(1) ensures that such clues will not be missed.


Thomas Adam

fix GOT_IMSG_COMMIT_TRAVERSAL_REQUEST

The sending and receiving side are sending the data differently. It works now by chance since a struct got_object_id is "just" a SHA1_DIGEST_LENGTH sized buffer, but will break in the future. Furthermore, the structure of the data as described in got_lib_privsep.h is not respected, as the path_len field is not transmitted. Change it to send/receive a whole struct got_object_id, the path without the NUL and the proper length. (The path is also actually mandatory, so assert it too.) improvements + ok stsp@


Thomas Adam

remove now unused sha1 handling from inflate and deflate

both were changed to use the new got_hash APIs.


Thomas Adam

add xfail test for "got update" replacing a file with a directory

ok stsp


Thomas Adam

portable: configure: remove unused variable

found_libbsd isn't used any more.


Thomas Adam

portable: update PLATFORM display

Fixes openbsd.



Thomas Adam

portable: improve SHA detection

Original patch from Omar Polo. Tweak by me.


Thomas Adam

portable: remove compat/xmalloc.[ch]

These wrappers aren't used in -portable. From Omar Polo.


Thomas Adam

portable: add LICENCE util/got-portable-ver.sh to dist

Update EXTRA_DIST to include these two files.


Thomas Adam

portable: add missing copyright headers