Commit Briefs

Thomas Adam

enforce gotd request timeout > 0; the code doesn't handle zero right now

spotted by + ok op@


Thomas Adam

gotwebd: tweak gotweb_render_content_type_file parameters type

`type' and `file' are strings so use `const char *' for both.


Thomas Adam

add conf_limit_user_connection prototype at the top of parse.y

different yacc implementations (e.g. GNU bison) may put the various parts in a different order, and so the definition of the function may not be visible in the generated code.


Thomas Adam

introduce connection options to gotd.conf

Allow administrators to tweak the default authentication and request timeouts if needed, and to tweak the limit of concurrent connections for specific user accounts. with several tweaks from and ok op@



Thomas Adam

portable: move tmpl.h to EXTRA_DIST

This header isn't needed for direct compilation, but should be included as part of the main tarball.


Omar Polo

portable: gotwebd: add tmpl.h to gotwebd_SOURCES

unbreaks `make dist'


Omar Polo

portable: template: don't install the binary template and its manpages

it's only needed at build time to generate a source file.


Omar Polo

portable: template: drop tmpl.c from SOURCES

was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers. see also 1dec34dfda7ccb3caadab65aca907251ab8fd72e


Thomas Adam

make 'tog log' display the committer handle by default, '@' switches to author

People coming from CVS might not expect names of patch contributers to show up in commit history listings, so make things easy for them. discussed with op@





Thomas Adam

gotd.conf: treat repositories without any parameters as a syntax error

Because gotd expects some parameters to be present they must not be optional at the syntax level.



Thomas Adam

fmt


Thomas Adam

adjust the first gotwebd.8 httpd.conf example to work out of the box

gotwebd defaults to listening on a unix socket, and this man page aims to provide an appropriate configuration snippet in EXAMPLES. suggested by Paul Wrankin via gameoftrees IRC


Thomas Adam

fix previous; name must be initialized

otherwise if binaryfilename fails to match the line, `name' may be left pointing to free'd memory.


Thomas Adam

got patch: handle the removal of binary files

Diffs that remove binary files don't have hunks so got patch would skip over them, treating that part of the diff as "noise". Different programs outputs a slightly different diff for this kind of patches, but the "Binary files ... and /dev/null differ" is usually shown, so try to match it. The adedd regress test covers got diff, git diff, and OpenBSD' /usr/bin/diff. CVS diffs will currently fail because the guessed file name will be wrong. CVS prints the file name in the Index and RCS lines which got patch currently ignores, and shows an useless path in the "Binary files /tmp/cvs... and /dev/null differ" line. Discussed with and ok stsp@


Thomas Adam

gotwebd: print commit message too in gotweb_render_commits

Regression from 156a1144 spotted by stsp, thanks!


Thomas Adam

gotwebd is a Web daemon



Thomas Adam

enforce a per-uid connection limit in the gotd listen process

For now the limit is set at compile-time. It will become configurable via gotd.conf soon. ok op@


Thomas Adam

gotwebd: drop redundant NULL check

qs is guaranteed to be not NULL reached that point.


Thomas Adam

gotwebd: remove useless comment

should be placed further down, after BLOB and RSS are handled, but the call to `gotweb_render_header' is successfully clear on its own.