Commit Briefs

bf2e865dbd Thomas Adam

fix an off-by-one in got_serve_parse_command() canonpath allocation

ok op@, tracey@


da1b528cac Thomas Adam

fix gotd sending too large pack files in some cases (linux)

Make gotsh pass all have-lines sent by clients onwards to gotd, reducing size of pack files generated by the repo_read process. Problem reported by naddy@ ok jamsek


98670ba726 Thomas Adam

portable: rework SHA detection

Simply the SHA detection by not predicating on libcrypto, but instead checking individual header files.


4680f70435 Thomas Adam

portable: remove sha1.h; found portably

Remove sha1.h as this is found portably across systems.


c8ae092d07 Thomas Adam

provide functions to parse/serialize different hashes

it abstracts over the hash type and ensures that object ids are zero'ed before their sha1 digest is written. Needed by the incoming sha256 support. ok stsp@


be288a59f4 Thomas Adam

rename lib/sha1.c to lib/hash.c

It will soon grow functions to deal with sha256 too. stsp@ agrees.


588a8092bc Thomas Adam

include sha2.h too where sha1.h is included

In preparation for wide sha256 support; stsp@ agrees. Change done mechanically with find . -iname \*.[cy] -exec sam {} + X ,x/<sha1\.h>/i/\n#include <sha2.h>


4c4f6843eb Thomas Adam

tweak send_zero_refs; use GOT_SHA1_STRING_ZERO

ok stsp@


49563dfbdb Thomas Adam

gotd: implement the delete-refs capability

Allow clients to run "got send -d" against gotd. Clients will send a zero-id as new id for a reference and, in the special but more common case of just deleting and not updating, no pack file will be sent. ok and tweaks by stsp@


0df2f4da54 Thomas Adam

delete trailing whitespaces



214d733a8e Thomas Adam

gotsh: validate with parse_command before connecting

Export parse_command (now got_serve_parse_command) from lib/serve.c and use it to validate the command line in gotsh instead of just checking that the -c argument starts with 'git-receive-pack' or 'git-upload-pack'. Invalid usage now always fails before opening the socket, while before it wasn't always the case. This also means that invalid usage doesn't count towards the limits. ok jamsek, stsp


8efb3dc0bc Thomas Adam

fmt; fold long line


113392cfbd Thomas Adam

make read errors in gotsh serve_read() fatal and adjust tests accordingly

ok jamsek


94a71055f4 Thomas Adam

only "forward" implicit flush packets in serve_read() if they are expected

ok jamsek


895484c861 Thomas Adam

fix spurious "gotsh: unexpected flush packet" error when client is up-to-date

ok op@


6110f5ef4a Thomas Adam

fix an issue where gotd fails to accept multiple have-lines from clients

ok op, jamsek


fcbb06bf69 Thomas Adam

replace malloc+memcpy with strndup. no functional change intended

ok stsp@


911f5cd53e Thomas Adam

remove bogus abort() call from gotsh echo_error()


2a0fb198ea Thomas Adam

fix capabilities announced by gotsh when no reference exist in repository

ok op@



946e0798ea Thomas Adam

remove trailing whitespace; patch by Josiah Frentsos



cc4cc677bd Thomas Adam

remove sendfd pledge promise from gotd repo_read process

Have the parent process send one end of the pipe directly to gotsh(1), such that repo_write can run without "sendfd". Combining "sendfd" and "recvfd" in the same process is frowned upon. ok tracey


3efd8e3122 Thomas Adam

introduce gotd(8), a Git repository server reachable via ssh(1)

This is an initial barebones implementation which provides the absolute minimum of functionality required to serve got(1) and git(1) clients. Basic fetch/send functionality has been tested and seems to work here, but this server is not yet expected to be stable. More testing is welcome. See the man pages for setup instructions. The current design uses one reader and one writer process per repository, which will have to be extended to N readers and N writers in the future. At startup, each process will chroot(2) into its assigned repository. This works because gotd(8) can only be started as root, and will then fork+exec, chroot, and privdrop. At present the parent process runs with the following pledge(2) promises: "stdio rpath wpath cpath proc getpw sendfd recvfd fattr flock unix unveil" The parent is the only process able to modify the repository in a way that becomes visible to Git clients. The parent uses unveil(2) to restrict its view of the filesystem to /tmp and the repositories listed in the configuration file gotd.conf(5). Per-repository chroot(2) processes use "stdio rpath sendfd recvfd". The writer defers to the parent for modifying references in the repository to point at newly uploaded commits. The reader is fine without such help, because Git repositories can be read without having to create any lock-files. gotd(8) requires a dedicated user ID, which should own repositories on the filesystem, and a separate secondary group, which should not have filesystem-level repository access, and must be allowed access to the gotd(8) socket. To obtain Git repository access, users must be members of this secondary group, and must have their login shell set to gotsh(1). gotsh(1) connects to the gotd(8) socket and speaks Git-protocol towards the client on the other end of the SSH connection. gotsh(1) is not an interactive command shell. At present, authenticated clients are granted read/write access to all repositories and all references (except for the "refs/got/" and the "refs/remotes/" namespaces, which are already being protected from modification). While complicated access control mechanism are not a design goal, making it possible to safely offer anonymous Git repository access over ssh(1) is on the road map.