Gotweb

Theo says unveil(2) is supposed to traverse exec(2) (though this seems to be broken or not implemented at present). In which case the commmit message editor would find itself without access to files it needs (startup config files, shared libs, user's home dir, etc.) Apply unveil after the log message has been written.

diff | patch | tree

5 years ago Stefan Sperling

make 'got commit' look up EDITOR in PATH

The previous code only worked if EDITOR contained an absolute path.

diff | patch | tree

5 years ago Stefan Sperling

apply_unveil() doesn't call err(3) so rename 'error' to 'err'

diff | patch | tree

5 years ago Stefan Sperling

missing error check in apply_unveil()

diff | patch | tree

5 years ago Stefan Sperling

rename got_error_prefix_errno() to got_error_from_errno()

diff | patch | tree

5 years ago Stefan Sperling

store commit message in work tree and leave it there in case of error

diff | patch | tree

5 years ago Stefan Sperling

reenable unveil for 'got commit'; keep spawn_editor() working

diff | patch | tree

5 years ago Stefan Sperling

remove pointless goto in collect_commit_logmsg()

diff | patch | tree

5 years ago Stefan Sperling

another malloc failure check in collect_commit_msg()

diff | patch | tree

5 years ago Stefan Sperling

use got_opentemp_named_fd() in collect_commit_logmsg()

diff | patch | tree

5 years ago Stefan Sperling

check malloc failure in collect_commit_logmsg()

diff | patch | tree

5 years ago Stefan Sperling

fix linear ancestry verification check for 'got update'

diff | patch | tree

5 years ago joshua stein

implement spawning an editor to collect a commit message

bails on empty messages, trims leading and trailing newlines this currently disables the unveil in the commit process because it's not compatible with spawning the editor also prevent commits when there are no changes

diff | patch | tree

More ↓