Commit Briefs
fix a bug in got_privsep_send_object_idlist() exposed by recent changes
The old code did not work correctly if only a single object Id was to be sent to got-read-pack. Make got-read-pack error out if the list of commits for object enumeration is empty to catch this problem if it occurs again. Found by the send_basic test, which was failing with GOT_TEST_PACK=1 ok tracey
let got-read-pack be explicit about whether it could enumerate all objects
This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@
compute object size, not pointer size
in this case they're luckily the same; got_imsg_object_idlist and got_imsg_reused_delta only have one size_t long field. ok stsp@
strictier validation for data received from libexec helpers
use correct error code and ok stsp@
use strndup instead of malloc+memcpy
Simplifies the reading of the author/committer string and makes also the code shorter. ok stsp@
don't check datalen when calling recv_imsg_error
recv_imsg_error already checks the size of the message, and it does so more precisely than the removed code. ok stsp@
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed. ok op@
revert object enumeration in got-read-pack for now; needs more work
This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@
revert "Skip poll(2) if an imsgbuf has a non-empty read buffer"
imsg_read() will call recvmsg() on the file descriptor regardless of the read buffer's state, so we should ensure that data is ready. The read buffer is used by imsg_get(), not imsg_read(). We already call imsg_get() before imsg_read(), and call the latter only if imsg_get() returns zero.
batch up tree entries in imsg instead of sending one imsg per tree entry
This speeds up loading of trees significantly. ok op@
parse tree entries into an array instead of a pathlist
Avoids some extra malloc/free in a performance-critical path. ok op@
rework logic in got_privsep_recv_tree() to avoid an ugly 'goto'
no functional change
run the search for deltas to reuse in got-read-pack
This significantly speeds up the deltification step of packing by avoiding imsg traffic. gotadmin no longer requests individual raw deltas from got-read-pack to check whether it can reuse them. Instead, got-read-pack obtains a list of objects we want to pack, and hands back the list of all deltas in its pack file which can be reused. Messages are now batched such that imsg buffers are filled as much as possible. Another advantage is that deltas we are not going to reuse will no longer be written to the delta cache file, saving disk space. Before this patch, any raw delta candidate was written to the delta cache file by got-read-pack, and the decision whether to reuse the delta happened afterwards in the gotadmin process. Code for reading individual raw deltas is now unused and could be removed at some point. ok op@
store deltas in compressed form while packing, both in memory and cache file
This reduces memory and disk space consumption during packing. with tweaks + memleak on error fix from op@ ok op@
inline struct got_object_id in struct got_object_qid
Saves us from doing a malloc/free call for every item on the list. ok op@