Commit Briefs

Thomas Adam

gotwebd: reply with non-200 HTTP status code on error

ok tracey@


Thomas Adam

gotwebd: provide gotweb_render_page() entrypoint for all pages

simplify gotweb_process_request more, handling all the pages inside the big switch. There's only one entrypoint for rendering the templates gotweb_render_page() that takes the page' content as argument. The only real difference is that gotweb_render_index() now skips directory entries which fails to handle. ok tracey@


Thomas Adam

portable: configure: split out dependencies

Rather than assume all dependencies are required for all programs, split them out. This will make packaging easier, as well as splitting the code to use subprojects. Note that due to the use of config.h semantics, in most cases the got_compat.h header file is now at the top of the .c file it is included in, so that it can handle the system header inclusion properly.


Thomas Adam

portable: rework SHA detection

Simply the SHA detection by not predicating on libcrypto, but instead checking individual header files.


Thomas Adam

include sha2.h too where sha1.h is included

In preparation for wide sha256 support; stsp@ agrees. Change done mechanically with find . -iname \*.[cy] -exec sam {} + X ,x/<sha1\.h>/i/\n#include <sha2.h>


Thomas Adam

gotwebd: add missing colon after 'Message' in diff view

Patch by Josiah Frentsos, thanks!



Thomas Adam

gotwebd: fix briefs/tags navigation overlap

Introduces a separate field for the "next" button (now called "More") and adjusted the CSS/HTML so it's used. Finally, drops the old code used to handle the pagination for the BRIEFS/COMMITS cases. Needs a small hack for the time being, setting the action to TAGS. This is due how qs->action is changed in gotweb.c while handling the request. ok jamsek


Thomas Adam

gotwebd: turn gotweb_get_time_str into gotweb_render_age

ok jamsek


Thomas Adam

gotwebd: templateify gotweb_render_blame

ok and tweak from jamsek


Thomas Adam

gotwebd: templateify gotweb_render_summary

ok jamsek


Thomas Adam

gotwebd: bubble up got_get_repo_tags

This bubbles up the call to got_get_repo_tags from gotweb_render_tags to its caller, gotweb_process_request and gotweb_render_summary. It helps simplifying gotweb_render_summary and making it easier to templateify, but also helps in untangling a bit the code. At this point gotweb_render_tags becomes just a wrapper to gotweb_render_tags_tmpl so switch completely to it. ok jamsek


Thomas Adam

gotwebd: templateify gotweb_render_branches

no functional change intended. Bubble up the allocation of the reflist from gotweb_render_branches to gotweb_render_summary (its only caller) and rewrite it as a template. ok tracey@



Thomas Adam

gotwebd: use from/via in gotweb_render_commits too

like the previous, show also the committer if different from the author.


Thomas Adam

gotwebd: make commit page more like `got log' / tog

- drop the "diff commit1 commit2" header; it's already showed in the body of the diff. - hide the tree id (not that useful to show.) - show the committer if different from the author. - use From/Via for Committer/Author. discussed with jamsek, stsp, tracey ok jamsek tracey


Thomas Adam

gotwebd: templateify gotweb_render_diff

ok tracey@; rebased after recent changes.


Thomas Adam

gotwebd: templateify gotweb_render_tag

ok tracey@


Thomas Adam

gotwebd: templateify gotweb_render_tags

ok tracey@


Thomas Adam

backout 169b163113a6db9878c9166aa05fbd30d05eb832

pushed by mistake, wasn't reviewed.


Thomas Adam

gotwebd: templateify gotweb_render_diff

To avoid calling functions from got_operations.c directly from a template (which would hide the error), change got_output_repo_diff into got_open_diff_for_output that returns a file with the diff in it, to be then rendered by the template. got_gotweb_flushfile needs to be exposed then. It also bundles a smaller change: the `label' argument of got_repo_match_object_id is optional and not used, so just pass NULL there.


Thomas Adam

portable: sha1.h

This is included portably.


Thomas Adam

gotwebd: templateify gotweb_render_tree

ok tracey@


Thomas Adam

gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs

binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske


Thomas Adam

gotwebd: print commit message too in gotweb_render_commits

Regression from 156a1144 spotted by stsp, thanks!