Commit Briefs

f4ae6ddb59 Thomas Adam

move got_opentempfd out of open_blob. ok stsp@


ef20f54204 Thomas Adam

build with -Wmissing-prototypes

ok stsp@


f289c82c68 Thomas Adam

got stage: implicitly unstage when staging the reverse of the staged diff

otherwise we end up with a staged empty edit for that file. ok stsp@


a0f32f336e Thomas Adam

move creation of tempfiles outside of lib/diff.c

ok tracey


36832a8e24 Thomas Adam

refactor got_patch / got_worktree_patch_complete

let got_patch own fileindex_path and call got_worktree_patch_complete only if got_wokrtree_patch_prepare hasn't failed. suggested by stsp@


5e22b7375b Thomas Adam

got patch: avoid open/sync/close the fileindex over and over again

Instead of flushing the fileindex after every patch in the patchfile just reuse the same fileindex and sync it only at the end of the patch operation. This speeds up 'got patch' on large repositories by quite a lot.


12de5570c0 Thomas Adam

don't pass relative paths to get_file_status


945f922947 Thomas Adam

stop relying on commit cache for good performance of got_object_id_by_path()

Instead of internally opening and closing the same commit object over and over again, require callers to pass an open commit object in. Avoids an inherent dependency on the commit object cache for reasonable performance. ok op@


814624e72d Thomas Adam

move got_patch file status checking in worktree.c

check_file_status used got_worktree_status to check if the file was in an allowed state, but it's wrong since the callback is not invoked on unchanged files. While here also fix a relate bug: unlink(newpath) is in the wrong spot and ends up removing files even when it shouldn't, so move it early in the got_worktree_schedule_* error handling. Finally, update the appropriate test case. It was passing before because got_worktree_schedule_add returned GOT_ERR_FILE_STATUS, not because check_file_status failed. ok stsp@



9d70a0bf72 Thomas Adam

portable: make UUID includes generic

Move the detection of UUID header files to be included portably. This will have no functional effect until MacOS detection is put in place.



84bf00a657 Thomas Adam

improve 'got add' error message if file does not exist; reported by Timo Myyrä

ok tracey


d5a18aced0 Thomas Adam

make 'got rm' report an "unexpected status" error for unversioned files

ok millert@


d64cc78a32 Thomas Adam

make 'got rm' behave like rm(1) for paths found missing on disk

ok millert@




48b4f23903 Thomas Adam

wrap overlong lines


fc63f50d9b Thomas Adam

add O_CLOEXEC (close-on-exec) to openat(2) calls

suggested by millert ok thomas_adam


0634062147 Thomas Adam

add O_CLOEXEC (close-on-exec) flag to open(2) calls

suggested by millert ok thomas_adam


c56c5d8a20 Thomas Adam

add "e" (close-on-exec) flag to fopen(3) calls

suggested by millert ok thomas_adam


24f136e0f9 Thomas Adam

preverse binary files during updates and merges


1ea7ccc6f3 Thomas Adam

let gotadmin find the repository automatically if invoked in a work tree

Move a small amount of code from worktree.c to a new file worktree_open.c, which contains everything required to open and close a work tree and inspect some of its basic parameters. This can be used by gotadmin. ok tracey



ae1e948a31 Thomas Adam

show commit progress output when 'got merge -c' is used

Otherwise no progress output is shown at all with this command. Commit progress output will also display any additional changes which resulted from conflict resolution. ok millert@