it's a string, `const char *' is fine (and what all the callers use anyway.)

Since gotwebd serves the RSS from a path without a file name component, browsers just make up a random string to give the file a name which can be confusing. Furthermore, since it's served as application/rss+xml they try to render the XML (failing.) Use gotweb_render_content_type_file (which sets the Content-Disposition HTTP header) to fix both: the feed is now called <repo-name>.rss and set as attachment (thus saved and not rendered.) Change the function to take an optional filename suffix for the occasion. ok jamsek

`type' and `file' are strings so use `const char *' for both.

qs is guaranteed to be not NULL reached that point.

should be placed further down, after BLOB and RSS are handled, but the call to `gotweb_render_header' is successfully clear on its own.

This updates -portable's gotwebd instance to make use of the new templating engine.

ok tracey@

ok tracey@

ok tracey@

gotwebd uses sprintf to update index_page_str and page_str if they were negative. While this specific usage is safe, let's drop it. Since the index_page_str and page_str fields are never read from, remove them. This saves two allocations per request too. ok tracey@

ok tracey@

ok tracey@

ok tracey

ok stsp@

- use openat(2) since we've already opened the containing dir - use fstat(2) instead of multiple seeks - don't special case len == 0 ok and improvements by stsp

ok jamsek

- drops the double loop; paginate in one go - avoid lstat + got_path_dir_is_empty for each entry: use dt_type if provided by the underlying filesystem - fixes a memleak: before `continue' we need to call gotweb_free_repo_dir ok stsp

instead of hardcoding d_i - 2 and so expecting only "." and ".." as skipped entries, use t->prev_disp that is the number of repositories traversed until now (both skipped due to the pagination and the ones actually rendered.) ok jamsek

ok stsp@

allows to hide repositories if they have the magic git-daemon-export-ok file ok op@ tracey@ stsp@

otherwise, the webserver might complain: 'upstream sent invalid header: "gotwebd\x20..." while reading response header from upstream' ok stsp@

We can assume that the querystring was initialized when we reach gotweb_render_header. ok tracey@

This adds a new helper function `gotweb_link' that outputs an HTML link with the parameter correctly escaped. ok stsp@

reported by the W3C validator.