Commit Briefs


Stefan Sperling

expose the reflist_insert() helper function as got_reflist_insert()

This will be needed by 'gotadmin pack'.


Stefan Sperling

validate reference names in open_ref()

This catches invalid reference names passed to 'got ref -l' and will also be needed to validate reference names passed to a future 'gotadmin pack' command. ok naddy@


Stefan Sperling

plug a memory leak in got_ref_list_free()

Code which inserts a reference into a reflist passes ownership of this reference to the list. However, got_ref_list_free() never closed such references, which resulted in a memory leak. ok tracey


Stefan Sperling

ensure that old commits remain referenced after rebase and histedit

Create automatic "backup" references which ensure that objects from the pre-rebase or pre-histedit state remain in the repository. A new -l option for 'got rebase' and 'got histedit' lists old commits. This makes it easier to recover from botched rebase or histedit operations. Removal of such objects currently requires got ref -d and git-gc. This will be made more convenient in the future. testing and ok jrick


Stefan Sperling

make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere

ok millert, naddy



Christian Weisgerber

replace fparseln(3) with getline(3), for better portability

ok stsp



Stefan Sperling

add tagged object IDs to reference list object ID map

Fixes display of "/tags/..." commit ID decorators in tog which was broken in previous commits.





Stefan Sperling

implement an object ID map for reference lists

ok naddy


Stefan Sperling

fix assignment to wrong pointer in got_ref_dup()

ok naddy



Christian Weisgerber

convert all remaining instances of chmod(2) to fchmod(2)

ok stsp



Stefan Sperling

make dangling symbolic references show up in 'got ref -l'

Storing a resolved ID for each reference list item was a bad idea. This ID cannot be resolved if a symbolic references points to a reference which does not exist. Such symrefs were skipped by got ref -l as a result. Just let users of reference lists resolve the IDs as needed.



Christian Weisgerber

do not rely on <zlib.h> to pull in <unistd.h>

ok stsp


Stefan Sperling

cope with directory entries returned from readdir(3) with type DT_UNKNOWN

Such directory entries need special handling to make our directory traversal code work on filesystems that do not support the d_type optimization. I found this problem because references stored in the refs/ directory were not shown by 'got log' and 'tog log' when a repository is mounted over NFS. helpful feedback + ok millert@