Commit Briefs
close parent's end of imsg pipe before waiting for a child process to exit
Prevents a dead-lock in 'tog log' where tog wants to exit (e.g. because the user pressed Ctrl-C) while a got-read-pack child process wants to send more commits. Closing the parent's pipe descriptor makes writes to the pipe fail in the child process. The child then unwinds via an ERR_EOF error and exits, instead of forever polling its end of the pipe in order to write more data. ok jamsek
fix off_t type mismatches
off_t is a signed type and depending on the platform, it can be "long" or "long long", so cast to long long for printf(). ok stsp
open temporary files needed for delta application in got_repo_open()
This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey
store deltas in compressed form while packing, both in memory and cache file
This reduces memory and disk space consumption during packing. with tweaks + memleak on error fix from op@ ok op@
inline struct got_object_id in struct got_object_qid
Saves us from doing a malloc/free call for every item on the list. ok op@
factorize imsg_clear calls after imsg_flush failures
imsg_clear frees and closes resources allocated as part of enqueueing imsgs so it's a no-op after reads. discussed with and ok stsp@
reuse existing deltas when creating pack files
tested by thomas, naddy, and myself
fix file corruption regression in 'got checkout' caused by commit db696021
got-read-pack must rewind its files temporary files before reusing them. Problem reported by naddy ok tracey naddy
add O_CLOEXEC (close-on-exec) to openat(2) calls
suggested by millert ok thomas_adam
don't scan pack index offsets for large values if pack file is < 2GB
This saves an iteration over the entire h->offsets array when opening a pack index which should not contain large offsets in the first place. ok millert@
switch from SIMPLEQ to equivalent STAILQ macros
The singly-linked tail queue macros were added to OpenBSD 6.9 and are more widely available on other systems. ok stsp
expose got_pack_parse_ref_delta() for library-internal use
This will be needed by a future 'gotadmin listpack' command.
expose got_packidx_get_object_offset() for library-internal use
This will be needed by a future 'gotadmin listpack' command.