Commit Briefs

Omar Polo

use capsicum on FreeBSD

Thanks to the design of Got, the libexec helpers don't need any resource (in fact they run under pledge "stdio recvfd" on OpenBSD) and so using cap_enter(2) on FreeBSD is dead-easy. While the main process can't be sandboxed on FreeBSD (needs to exec the helpers), all the tough work is done by these small libexec helpers which is also the biggest attack surface. tested by naddy, ok thomas

diff | patch | tree

Thomas Adam

portable: add support for landlock

landlock is a new set of linux APIs that is conceptually similar to unveil(2): the idea is to restrict what a process can do on a specified part of the filesystem. There are some differences in the behaviour: the major one being that the landlock ruleset is inherited across execve(2). This just restricts the libexec helpers by completely revoking ANY filesystem access; after all they are the biggest attack surface. got send/fetch/clone *may* end up spawning ssh(1), so at the moment is not possible to landlock the main process. From Omar Polo.

diff | patch | tree

Thomas Adam

portable: add FreeBSD support

This adds the capability to compile got-portable on FreeBSD.

diff | patch | tree

Thomas Adam

portable: initial Linux compilation

This commit modifies the GoT main branch to be able to compile it under linux.

diff | patch | tree

Stefan Sperling

verify object ID checksums while loose objects are being accessed

diff | patch | tree

Stefan Sperling

add checksum parameters to got_inflate functions which did not provide them yet

diff | patch | tree

Stefan Sperling

make close(2) failure checks consistent; check 'close() == -1' everywhere

ok millert, naddy

diff | patch | tree

Stefan Sperling

make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere

ok millert, naddy

diff | patch | tree

Christian Weisgerber

Stop including <sys/syslimits.h> directly.

POSIX says the limits defined there are available from <limits.h>, which almost all affected source files already included anyway. ok millert stsp

diff | patch | tree

Christian Weisgerber

do not rely on <zlib.h> to pull in <unistd.h>

ok stsp

diff | patch | tree

Stefan Sperling

add optional 'consumed' output parameter to got_inflate_to_mem()

diff | patch | tree

Stefan Sperling

add copyright year for files already touched in 2020

diff | patch | tree

Stefan Sperling

plug a memory leak: got-read-commit forgot to close commits

diff | patch | tree

Stefan Sperling

fix memleak in error case of got-read-commit

diff | patch | tree

Stefan Sperling

include <limits.h> instead of <sys/limits.h>; patch by Thomas Klausner

diff | patch | tree

Stefan Sperling

rename got_error_prefix_errno() to got_error_from_errno()

diff | patch | tree

joshua stein

while (1) -> for (;;)

diff | patch | tree

joshua stein

got_error_from_errno -> got_error_prefix_errno

also add got_error_prefix_errno2 and got_error_prefix_errno3 which should hopefully all be merged into a single function with variadic args (but can't alloc mem)

diff | patch | tree

Stefan Sperling

check for errors from close(2)

diff | patch | tree

Stefan Sperling

check for errors from fclose()

diff | patch | tree

Stefan Sperling

there's no point in embedding the object header in commits

diff | patch | tree

Stefan Sperling

eliminate got_object_open() round-trip when opening commits

diff | patch | tree

Stefan Sperling

don't be noisy on stderr when Ctrl-C is hit

diff | patch | tree

Stefan Sperling

abort checkout operations cleanly when Ctrl-C is hit

diff | patch | tree

Stefan Sperling

back out mini-commits; no significant performance difference

diff | patch | tree