Commit Briefs

Thomas Adam

Do not ignore error from format_author().

Found by llvm's scan-build (dead store). OK stsp


Thomas Adam

Dot not ignore error from got_object_id_str().

Found by llvm's scan-build (dead store). OK stsp


Thomas Adam

path_got is unused and never assigned, no need to free it

OK stsp


Thomas Adam

Do not ignore I/O errors.

Found by llvm's scan-build (dead store). OK stsp


Thomas Adam

Don't chug along if repo format version is unsupported.

Found by llvm's scan-build (dead store). OK stsp



Thomas Adam

tog: blame view keymap to open log of annotated line

As per stsp's TODO item: open a log view of the selected line with 'L'. helped by and ok stsp@



Thomas Adam

document pull request workflow in got.1 man page

With permission from Jelmer Vernooij to use my pull request config for Dulwich, and Jelmer's name, as a real-life example. ok tracey, jamsek


Thomas Adam

typo in cat_commit

otherwise prints the author instead of the committer


Thomas Adam

tog: alias J and K to > and < keybindings for diff view

Use J and K to move to the next and previous commits, respectively, when the diff is loaded from the log or blame views. Patch by Mikhail ok stsp@


Thomas Adam

got commit: add flag to specify the author

This adds a new flag, `got commit -A', that allows to specify the commit author but retains the "committer" (which is obtained as usual via GOT_AUTHOR, got.conf or git config.) with lots of help from and ok stsp


Thomas Adam

portable: remove imsg.h

Allow imsg.h to be checked for portably.



Thomas Adam

fix email address parsing

we were both too strict and too lose. To avoid breaking got object parser (and to some extent ours too) we need to ensure that there aren't any line feeds, extra < or > and no trailing gibberish. The '@' is not actually required in the email. various tweaks and ok stsp


Thomas Adam

tog: add key to toggle author/committer in log view

improvements and ok by jamsek and stsp


Thomas Adam

mark got_error_fmt as printf-like and fix the arisen errors

ok stsp@


Thomas Adam

portable: README: mention shortlog format

When writing -portable patches, mention the format of the commit's shortlog.


Thomas Adam

portable: update gitignore for gotwebd

Add gotwebd and parse.c which are compiled/generated and should not be tracked.


Thomas Adam

add another TODO idea for tog


Thomas Adam

tog: always request commits if log height is increased

Includes style improvements prompted by stsp. Previously, we would only call request_log_commits() when terminal height is increased in a splitscreen view. This fixes the case when a log view with no children is resized that can lead to empty lines: $ tog # 80x24 23j # move down to the last commit *increase terminal height to ~30 lines then reduce back to 80x24* ~5j # move down to the _last_ commit *increase terminal height to ~33 lines* *new lines are empty* ok stsp@





Thomas Adam

add more TODO items for tog