Commit Briefs

da1b528cac Thomas Adam

fix gotd sending too large pack files in some cases (linux)

Make gotsh pass all have-lines sent by clients onwards to gotd, reducing size of pack files generated by the repo_read process. Problem reported by naddy@ ok jamsek


67fdb8a7a3 Thomas Adam

Close the message template file before calling edit_logmsg().

Fixes a race condition on NFS where the file's modify time may change while the file is being edited, causing the editor to complain. OK stsp


5713faaf58 Thomas Adam

portable: update READMEs


e6d0edca5f Thomas Adam

portable: set next version


00d6d36174 Thomas Adam

portable: release 0.85 (tags/0.85)


8cff5e95a3 Thomas Adam

portable: OpenBSD compilation fixes (ta/configh)


68069cf601 Thomas Adam

portable: fixes for NetBSD

* Move the main incldue/got_compat.h to the top of the files they're included in. * Define SHA256Init and friends to the system equivalents.


d3f1e38b5d Thomas Adam

portable: curses: improve detection

When checking for ncurses, don't clobber previous checks for libpanel.


7ef51333b7 Thomas Adam

portable: cleanup headers

Remove useless headers which don't need to be included any longer.


206be139b5 Thomas Adam

portable: improve b64_ntop detection

When looking for base64 functions, check -lresolv and/or -lnetwork, and only build those in compat if required. Some of the detection code was modified from tmux's configure.ac script.


d9b944c72d Thomas Adam

portable: add missing header checks

Some code in compat/ has #defines which were not being checked for in configure.ac, which could have lead to compilation failures were those files to be included on systems which needed them. In doing so, we can now remove libmd and libcrypto as these are no longer needed.


40d5394383 Thomas Adam

portable: configure: use SHA_2{,56}_H

Don't use a custom variable when the header checks for these are already available. From Christian "naddy" Weisgerber.


c2417a8ec6 Thomas Adam

portable: alpine: include stdlib.h

Because musl is less forgiving about header-ordering, explicitly include this before stdio.h -- this won't affect existing files as the include guards elsewhere prevent this.


09e05ed50d Thomas Adam

portable: regress: imply compat

When building tests, compat needs to be built. Do this prior to running any tests. This ensures tests can be run from a clean tree. Furthermore, add got_compat.h to all test headers. This wasn't necessary before as this was implicitly being included, but now isn't.


943e9ed21c Thomas Adam

portable: configure: flatten LIBS

Set LIBS to the empty string so that only the specific dependencies are included where needed, rather than relying on autotools to do this for us. This will make splitting out got into different subprojects easier, as well as allow for multi-packing on those systems which support it.


1ef7c68a19 Thomas Adam

portable: extend got_compat2 include guard

Extend the include guard to the whole file.


4fccd2fe0f Thomas Adam

portable: configure: split out dependencies

Rather than assume all dependencies are required for all programs, split them out. This will make packaging easier, as well as splitting the code to use subprojects. Note that due to the use of config.h semantics, in most cases the got_compat.h header file is now at the top of the .c file it is included in, so that it can handle the system header inclusion properly.


b49d4941c8 Thomas Adam

portable: Makefile: add -Wno-pointer-sign

Ignore warnings about pointer-signedness. This may well get fixed upstream, but won't hurt to be left here, regardless.


47dc83f5be Thomas Adam

portable: configure: use config.h

So that the command-line flags to CC don't get drowned out with copious -D flags, move this detection to config.h instead. Note that to reduce the code churn, the existing include/got_compat.h header file has been renamed, and the generated file replaces it, but with the contents of the original header file included. Eventually, we might want to move some od the logic in include/got_compat2.h into AH_VERBATIM() blocks, but for now, this is a good compromise.


7f0ff4a55b Thomas Adam

bump version number


8f8b8c0017 Thomas Adam

CHANGES for 0.85


bc3b59da2e Thomas Adam

sync distfile list



046f76c30e Thomas Adam

fix gotd sometimes reading reused deltas from wrong pack file

The reuse-pack is pinned but may change its cache slot while objects are being deltified. Refresh the pointer to the pinned reuse-pack before writing out the pack file, ensuring that reused deltas will in fact be read from the reuse-pack and not some other pack. Otherwise gotd may send a broken pack file, or hit an ERR_RANGE condition if the pack file which now occupies the pinned-pack's old cache slot is shorter. Which can trigger attempts to read beyond end-of-file which show up in the logs like this: gotd[37311]: repo_read /var/git/got.git: sending packfile: value out of range gotd[43877]: uid 1002: value out of range gotd[43877]: uid 1002: disconnecting


99fe3033f2 Thomas Adam

add xfail test for histedit folding of delete followed by add

If a file is deleted, then in modified form added again, folding should restore the file with its new contents. ok stsp