Commits
- Commit:
7c67cf56d3e4bab38eebe16a51f0ffb790694738
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix occasional test failure in test_log_show_base_commit
Patch by jamsek with a request to commit. Thanks!
- Commit:
48bfa43b34c38fcf5e33c1e63dbe5dbd8c5865ce
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent ncurses signal handlers from being installed while using mock-io
Aborting tog regress with Ctrl-C would trigger a "tty" pledge violation
via the built-in ncurses handler for SIGINT, installed by newterm().
Install tog's own signal handlers earlier to fix this.
- Commit:
cdbfe5d2325bd7ae7a197ce5e7a93fcdba9097cb
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add cancellation support to the mixed-commits checker in worktree.c
- Commit:
99301cec42290cd26b9757c17eaaab5d70781bf1
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
load tog's worktree base commit marker in the log thread for startup speed
Walking the whole file index can take some time. Avoid delaying the perceived
start-up time of tog by reading the file index in the background log thread.
Problem pointed out by op@
with fixes from + ok jamsek
- Commit:
9e0b562498af93589bef778858099a8a1a33e252
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: change base commit marker to the commit colour
The marker annotates the commit, so it makes more sense to visually tie it
to the log message than the author. Patch by stsp, I just removed a block.
ok stsp@
- Commit:
6ed9ffec8b7318ac6f69a138854afefc48bca2c0
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: plug leak in cmd_log() error path
ok op@
- Commit:
c935fd512b9937ffefdd248a3a840d0530011a1e
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: show work tree base commit marker in log view
If tog is invoked in a work tree, prefix the base commit log message summary
line with a '*' if the work tree is up-to-date, and with a '~' if the base
commit is not up-to-date with respect to the branch tip or it contains mixed
commits. While here, plug a couple worktree leaks in cmd_ref() and cmd_tree().
ok stsp@
- Commit:
c4df265ebabf6993a1c217bb2bb59d5aeb3fe5e5
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: add support for commit keywords
Allow keywords as arguments to options and operands for the blame, diff, log,
and tree commands. Also, return 1 when exiting tog with error rather than 0
so regress can discern success from failure.
ok stsp@
- Commit:
df6221c7df42758252c508006201c3f66e6ae831
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
use a separate .cvg meta data directory for cvg(1) work trees
This prevents mixing the use of got and cvg clients in the same work tree.
Avoids confusion going forward while cvg differentiates itself further.
tog(1) and gotadmin(1) remain compatible with both work tree formats.
These tools only read work trees to locate the corresponding repository.
- Commit:
6efe6ea96a3b926e024566b15a6c0bb9f5ce0c79
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: fix double-free in blame view error path
open_diff_view() has already called view_close() on error.
Patch by Josiah Frentsos.
- Commit:
eef262f386912f13169c1d74b77732bce4524cfd
- From:
- Tracey Emery <tracey@traceyemery.net>
- Date:
Fix for cc1: warnings being treated as errors
/home/got/src/got/tog/tog.c: In function 'draw_tree_entries':
/home/got/src/got/tog/tog.c:7307: warning: comparisons like X<=3DY<=3DZ do =
not have their mathematical meaning
- Commit:
39c864a48b9d156c8b748725f5f89b3bd3f65038
- From:
- Omar Polo <op@omarpolo.com>
- Date:
avoid strlen in for(;;)
ok jamsek, stsp
- Commit:
563ffc1b6d823b71bab79a0a75c67524f3d0f447
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got, tog: correctly skip HEAD in build_refs_str()
s[strlen(s)] == '\0' is banally always true, the intent was to not skip
refs that starts with "HEAD".
style nit / ok stsp@
- Commit:
6c685612338950f89dc47cd0ef36bcd65fe6404f
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix refs_str memory leaks
Pointed out by op@
- Commit:
cc3ce05962c0e173176dd8fa1a545daded616853
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rework how reference labels are rendered in the tog log view
Draw reference labels and log message as separate strings. The previous
code contained calculations mixing variables which represent an amount
of wide characters in a string vs the display width of the string. We
can avoid such nonsense by keeping the strings separate, though we have
to be a bit careful about keeping horizontal scrolling intact.
Also fix a bug where we failed to account for reference labels while
setting view->maxx which made the $ key not scroll far enough.
ok op@
- Commit:
6046ddd508ce0449329423278b8686eb8e6880a2
- From:
- Omar Polo <op@omarpolo.com>
- Date:
typo: character -> characters
- Commit:
675a8e0a79a845b3bbb8dafcc4f8ee2ddf210f53
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
stop showing backup references in the tog log and diff views
Backup references clutter the log view too much now that we display
labels next to commit messages.
They were accidentally added to the log and diffs view by me, via
build_refs_str(), when support for listing backup references was
added to the ref view.
- Commit:
77fc0a255189c6c18e1ea0d6ea82ae1d0ddb4ea7
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix 'tog log' display regression with long reference lists
When the terminal becomes smaller horizontally we did not properly
account for remaining columns and the log message of a commit could
overflow into the next line, garbling the display.
- Commit:
9cd447eb681a736f222bbe134ca37c1fb30cfa89
- From:
- Omar Polo <op@omarpolo.com>
- Date:
relax build_refs_str to allow a NULL reflist, simplifes the callers
ok stsp@
- Commit:
0b570e72a9d79d0b3b0927c99cdbaff8cea86f37
- From:
- Omar Polo <op@omarpolo.com>
- Date:
tog: fix segfault in draw_commit
build_refs_str() can succeed returning a NULL string if a commit
has some refs pointing to it but that were all filtered out, resulting
in a NULL-deref.
ok stsp@
- Commit:
f9ba221e8cb752b2dc0bdefd29108cff8ab31799
- From:
- Omar Polo <op@omarpolo.com>
- Date:
simplify previous; avoid temporary string
blind ok stsp@
- Commit:
689555c9e29b71a739b43324c7639a4803744bdf
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
show reference labels next to commit messages in tog log view
requested by mpi@
ok op@
- Commit:
c671dc6587800c66e8cbbeaab9336234eec88f69
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog regress: TAB instruction + test for diff J keymap
Add the TAB instruction to the test harness, and a test case for the previous
commit: scroll down the log from the diff view with the J keymap when on the
last loaded commit.
ok stsp@
- Commit:
e56a17962a1ed2ed7530c92097d09bde36c57383
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: resize log view if toggling fullscreen from child view
We call resize_log_view() when toggling 'F'ullscreen from the log view, but
forgot to do this when toggling fullscreen from a child view if its parent
is the log view. This fixes a bug that prevents scrolling down the log view
from the diff view with the J keymap if already on the last loaded commit.
Regress test in the following commit.
ok stsp@
- Commit:
91db220264b6d9be6d44223dd76ae8eb9bea3641
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Omar Polo <op@omarpolo.com>
- Date:
tog: mark HSPLIT_SCALE as float; unbreak regress on i386
On i386 view_split_begin_y() computed a value slightly different
than on other arches, breaking the regress. Casting HSPLIT_SCALE
as float unbreaks it.
Diff from jamsek, committing on his behalf. Thanks!