Commits
- Commit:
c9b75c7bd7036a6895bbc3eba2ed0369238ebab4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert "Skip poll(2) if an imsgbuf has a non-empty read buffer"
imsg_read() will call recvmsg() on the file descriptor regardless
of the read buffer's state, so we should ensure that data is ready.
The read buffer is used by imsg_get(), not imsg_read().
We already call imsg_get() before imsg_read(), and call the latter
only if imsg_get() returns zero.
- Commit:
2ab714554f1fd2273c9705450cf192dabb4f6b9d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
Skip poll(2) if an imsgbuf has a non-empty read buffer.
- Commit:
1453347d2463ce1b2700dd9fa810f30f2a443e5e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
imsg_add() frees its msg argument on error; avoid double-free in error paths
- Commit:
33fd69c2e53ffe1f0a7e1184293f6918a377376d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
batch up tree entries in imsg instead of sending one imsg per tree entry
This speeds up loading of trees significantly.
ok op@
- Commit:
9985f404ff5dc911b6186e5fa6233fa36848a19a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
parse tree entries into an array instead of a pathlist
Avoids some extra malloc/free in a performance-critical path.
ok op@
- Commit:
3483a4da364d64c5b630cec74a97fab5b5035c65
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent an out-of-bounds access in got_privsep_recv_tree()
- Commit:
baef4d750d80fcf0fddce409470150e73ae120d3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug memory leak in an error path of got_privsep_recv_tree()
- Commit:
13fcf1bf305bb86f5bbe5da661f8811846b79d61
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make got_privsep_recv_tree() reject trees with less than zero entries
- Commit:
7429ae85e5dff2953bced09c774ea43f501e8929
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rework logic in got_privsep_recv_tree() to avoid an ugly 'goto'
no functional change
- Commit:
fae7e03842e8618973f4d4910a86a52d881ab2ab
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
run the search for deltas to reuse in got-read-pack
This significantly speeds up the deltification step of packing by
avoiding imsg traffic. gotadmin no longer requests individual raw
deltas from got-read-pack to check whether it can reuse them.
Instead, got-read-pack obtains a list of objects we want to pack,
and hands back the list of all deltas in its pack file which can be
reused. Messages are now batched such that imsg buffers are filled
as much as possible.
Another advantage is that deltas we are not going to reuse will
no longer be written to the delta cache file, saving disk space.
Before this patch, any raw delta candidate was written to the
delta cache file by got-read-pack, and the decision whether to
reuse the delta happened afterwards in the gotadmin process.
Code for reading individual raw deltas is now unused and could be
removed at some point.
ok op@
- Commit:
2d9e6abf243a0a1895786fa9002b28d69a0f6fea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
store deltas in compressed form while packing, both in memory and cache file
This reduces memory and disk space consumption during packing.
with tweaks + memleak on error fix from op@
ok op@
- Commit:
d7b5a0e827bb38e5c8502f0ba8d7838fedaba19b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
inline struct got_object_id in struct got_object_qid
Saves us from doing a malloc/free call for every item on the list.
ok op@
- Commit:
e9ce266e31923cc339954b331d273d9bba543f6f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add `got patch' command for applying unified diffs
- Commit:
8934ea8b1b31166ea1f3f857e6f51f8dd6a999a2
- From:
- Omar Polo <op@omarpolo.com>
- Date:
factorize imsg_clear calls after imsg_flush failures
imsg_clear frees and closes resources allocated as part of enqueueing
imsgs so it's a no-op after reads.
discussed with and ok stsp@
- Commit:
67fd68496517d3103b130a1085efdd4591bd7416
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reuse existing deltas when creating pack files
tested by thomas, naddy, and myself
- Commit:
8264d9ee0f0935e0f351d70a93e489ef02b1531e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix wrong imsg name in errors raised by got_privsep_send_tree_req()
- Commit:
9296b03b686828afd019e202e6d6b31d392d66b2
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove unnecessary local variable from got_privsep_get_imsg_obj()
- Commit:
d1b988e317a93820f57ce18e68035a6799e20583
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add missing initialization of delta list in got_privsep_get_imsg_obj()
- Commit:
4a55b231883da25896fe302c04b11284bad0e125
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
ignore the return value of closefrom(2); patch by Anna a.k.a. CyberTailor
millert@ suggests that this check is not needed, and that ideally we
should be using close-on-exec instead. I will look into this, but in the
meantime this change will help -portable: https://bugs.gentoo.org/828003
- Commit:
abc59930d57a2d46c310e1b0c758c948554bc1af
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
indentation fixes
- Commit:
6480c871c8f9ffdce90c10e7a7313e1187de019a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
provide separate send {} and fetch {} configuration blocks in got.conf
Feature requested by naddy.
ok naddy, who also suggested some tweaks that will arrive shortly
- Commit:
f8a36e221091eb68b439ebe4eb07a5d03b335c28
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add 'got send' command for sending changes to remote repositories
Known to work against git-daemon and github Git server implementations.
Tests by abieber, naddy, jrick, and myself.
Man page additions reviewed by Lucas.
- Commit:
c3564dfafd6bf9ca36c049cf02a1432ce3e66c3f
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
don't scan pack index offsets for large values if pack file is < 2GB
This saves an iteration over the entire h->offsets array when opening
a pack index which should not contain large offsets in the first place.
ok millert@
- Commit:
d5c81d448ae4eec21053152e1c82c66eb11ca7a4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
verify object ID checksums while loose objects are being accessed
- Commit:
dbdddfee1482b50ca8c4a0be06e4fec6a59fb9f4
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
switch from SIMPLEQ to equivalent STAILQ macros
The singly-linked tail queue macros were added to OpenBSD 6.9 and
are more widely available on other systems.
ok stsp