Commits
- Commit:
f9ba221e8cb752b2dc0bdefd29108cff8ab31799
- From:
- Omar Polo <op@omarpolo.com>
- Date:
simplify previous; avoid temporary string
blind ok stsp@
- Commit:
689555c9e29b71a739b43324c7639a4803744bdf
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
show reference labels next to commit messages in tog log view
requested by mpi@
ok op@
- Commit:
c671dc6587800c66e8cbbeaab9336234eec88f69
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog regress: TAB instruction + test for diff J keymap
Add the TAB instruction to the test harness, and a test case for the previous
commit: scroll down the log from the diff view with the J keymap when on the
last loaded commit.
ok stsp@
- Commit:
e56a17962a1ed2ed7530c92097d09bde36c57383
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: resize log view if toggling fullscreen from child view
We call resize_log_view() when toggling 'F'ullscreen from the log view, but
forgot to do this when toggling fullscreen from a child view if its parent
is the log view. This fixes a bug that prevents scrolling down the log view
from the diff view with the J keymap if already on the last loaded commit.
Regress test in the following commit.
ok stsp@
- Commit:
91db220264b6d9be6d44223dd76ae8eb9bea3641
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Omar Polo <op@omarpolo.com>
- Date:
tog: mark HSPLIT_SCALE as float; unbreak regress on i386
On i386 view_split_begin_y() computed a value slightly different
than on other arches, breaking the regress. Casting HSPLIT_SCALE
as float unbreaks it.
Diff from jamsek, committing on his behalf. Thanks!
- Commit:
3aa652eff930e9f4d878f8d4a7d01ffd3e95e096
- From:
- Omar Polo <op@omarpolo.com>
- Date:
tog: open screendump file early during regress
we can't open arbitrary files after unveil(), and that's a feature!
So, open it early and truncate it before use just in case screendump()
ends up being called more than once.
ok/tweak stsp, ok jamsek
- Commit:
69b9e75f5436338a9b5cddd5b8462929def12e8c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
tog: don't check whether stdin is a tty during regress
ok stsp, jamsek
- Commit:
906c73f69f5ab088561e8f1378c27d852a022e37
- From:
- Omar Polo <op@omarpolo.com>
- Date:
tog: don't open /dev/tty during regress
as it might not be there (for e.g. if ran under cron). Reuse instead
/dev/null since it's not expected to get input from stdin.
ok jamsek
- Commit:
c62d44e73cce01c980cbf186d5872b9be259028a
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
tog: always use alternate charset for vertical/horizontal line
ncurses(3) will use the line drawing characters from the VT100
alternate graphics character set if the terminal supports this as
indicated by termcap/terminfo, otherwise it will fall back to ASCII
replacement characters.
ok jamsek stsp
- Commit:
d9bb8469b460e6d63787980c7a28c41184986c5d
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: teach test harness to count and basic tree tests
Add count instruction to the test harness to simulate count modifier
compound keys (e.g., 11j), and add basic tests for the tree view.
ok stsp@
- Commit:
81641b410b1170a048a3b6994268ddf78515aad6
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog regress: zap needless defines and use "vt220" TERM
Also, overwrite - and | unconditionally when capturing screen dumps,
and unset TOG_COLORS and TOG_DIFF_ALGORITHM in regress setup.
All tweaks suggested by naddy@
ok stsp@
- Commit:
8496bf63db31d4c4e433fa8e5fddf5719038aa32
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog regress: use pthread conditions for wait instruction
As suggested by stsp, rather than busy wait in the view loop, use pthread
conditions to wait for the blame thread to signal completion before drawing
the screen. We can add more conditions for other views when needed, but by
keeping the general WAIT_FOR_UI instruction and flag, this should make their
use context-dependent so we won't need more test harness WAIT_* instructions.
ok stsp@
- Commit:
c736b84ab8efb53399d58afe57a2e40c4c7dd1b5
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: lock mutex if leaving view_loop() on a script read error
ok stsp@
- Commit:
e08111f29f40db6013de92a2f63265255d647ee8
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: tweak blame tog_view deallocation fix from 2ca2f982
Both view_close() and close_blame_view() are called from view_loop()
irrespective of error, so only call these from cmd_blame() to ensure
the tog_view structure is not leaked when open_blame_view() errors.
ok stsp@
- Commit:
8d212112582e612c39aa399858bc0b10c74782d0
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: blame regress and new test framework wait instruction
Basic blame view test required adding the WAIT_FOR_UI instruction to delay
screen dumps till the ui has been completely rendered. This will also apply
to future test cases such as limited log views and further blame test cases.
ok stsp@
- Commit:
5bde47590bc2803fac92ad9b3362511f427d3c6a
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: rename regress test script envvar
As per stsp's idea: use a more descriptive name, and use the
TOG_TEST_SCRIPT envvar both in tog.c and the test scripts.
ok stsp@
- Commit:
132d524727bc488554836990bad88e0208b85843
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
document the S key in tog's online help screen
- Commit:
2ca2f982e80d0ff52e0a2990b60912bedb9e23eb
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: plug tog_view structure leak on open_*_view() error
ok stsp@
- Commit:
7483826edb3332b2f49e9dfa9515a2a097f61d60
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
release tog_io regress mock term resources in main()
ok stsp@
- Commit:
098596c5bf9520ed39f9a34e4733b6256d2ab453
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make tog regress run with pledge active
ok jamsek
- Commit:
af21bb7e28a5a337eb50bfd364a1e1640c6f97b1
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: implement automated test harness
Add framework for scripting tog tests by capturing screen dumps to compare
with expected output. Includes some preliminary log view tests but lots more
tests are needed to cover diff, blame, tree, ref, and help views.
ok stsp@
- Commit:
8c28a2abbc4aeeb588826ad0010267d507e71ff8
- From:
- Mikhail <mp39590@gmail.com>
- Via:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: resume blame and diff search from the first line
In diff and blame views, if the user scrolls up during a search, resume
search from the first displayed line--not the current match. This makes
sense in these views as the "cursor" or current line is the first line.
Patch by Mikhail.
ok op@
- Commit:
5822e79e39a8777984e08b5d89a8c55d6aa0356d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done
mechanically with
find . -iname \*.[cy] -exec sam {} +
X ,x/<sha1\.h>/i/\n#include <sha2.h>
- Commit:
5afebbd1b6bcfecf69d25e367e95c9906245fcf5
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Mark Jamsek <mark@jamsek.dev>
- Date:
fix tog diff between arbitrary commits
Don't assume commit info is always written. This is only true when diffing a
commit against (one of) its direct parent(s). Otherwise we perform an invalid
read on a tmp got_diff_line array and end up passing bogus offsets to fseeko().
Bug found and fixed by stsp with a minor tweak by me.
ok jamsek for stsp's initial diff
ok stsp@
- Commit:
1fa0d17d767f8e443af3b4493f3f2af0e759dda9
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got/tog/gotadmin: pledge earlier
In the case of tog move setlocale(3) before pledge(2), as suggested by
stsp.
ok stsp@