Commits
- Commit:
0701e66c20d0558f1f7c72d7fb700be6fe376d3f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got_imsg_fetch_ref: use struct instead of buffer for id
ok stsp@
- Commit:
4b4da3bbc7a791ba0d7d9d369dfe1e7b65f7eed4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got_imsg_fetch_have_ref: use struct instead of buffer for id
ok stsp@
- Commit:
00b3e9ae14f04a45f1ca7445bade6b41a6e8a1c5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
replace malloc+memcpy with strndup. no functional change intended
ok stsp@
- Commit:
d8bacb933720b8819f0c4e76b004775aa1885b9b
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: minor refactor of got_pathlist_free() API
Accept flag parameter to optionally specify which pointers to free. This saves
callers looping through the list to free pointers.
ok + fix stsp@
- Commit:
9114dd430297e408815019c3bc1df29ba10a9fb8
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
fix uninitialised fildes variables in libexec helpers
Reviewed and uncovered as part of the diff in the forthcoming commit
(pathlist API refactor).
ok stsp@
- Commit:
99fd9ff4bf6d3bee4a29f13ef4ae81aa36fdd4d5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
always cast ctype' is*() arguments to unsigned char
ok stsp@
- Commit:
c9f1ac46710e3ac672c769862ae51b838c3c8e46
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make 'got clone -b' work for repositories which lack a HEAD reference
ok op@
- Commit:
74737945d01fa40a64535be8018c8dc44859b524
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid looping over SHA1Update() in got-fetch-pack; suggested by millert@
- Commit:
dd4ea8bd9bd04c88bb85c1b7f67a7f7b3e43b94e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
got-fetch-pack: fix wrong memmove length leading to dubious checksum failures
ok millert tracey
- Commit:
5e91dae4dd43b8024731223110ab18f505f453ac
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove trailing whitespace; patch by Josiah Frentsos
- Commit:
438d0cc30baf8e97fd870f5e620833e0a45401aa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix snprintf error handling
follow the "proper secure idiom" described in the CAVEATS section of
printf(3). reminded by tb@ and millert@
- Commit:
ea8d9c76cc8fdc1dacfcc1cb952769fcd0930b10
- From:
- Omar Polo <op@omarpolo.com>
- Date:
convert two snprintf to strlcpy
"looks good to me" millert@
- Commit:
1453347d2463ce1b2700dd9fa810f30f2a443e5e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
imsg_add() frees its msg argument on error; avoid double-free in error paths
- Commit:
dcb64fea5fbc0fb5f5cd1947bef3b5d09e266a79
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
apply time-based rate-limiting to got-fetch-pack download progress output
- Commit:
e99d9267c8cc287a60f768d4282c01b9f5f6c975
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug memory leaks in got-fetch-pack and got-send-pack
ok naddy
- Commit:
dd088d9503d8e7cebbb30c535d8e4d11556c8d30
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
let 'got fetch' send all references to the server to avoid redundant downloads
Problem reported by naddy.
ok naddy
- Commit:
030daac821622c8495676bc5210fb7784c7ae78f
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix some integers that had a slightly wrong type; patch by Omar Polo
- Commit:
77d7d3bb1aabafae6c020c8a07a6e9f4f7885c9b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
de-duplicate a constant used by both 'got fetch' and 'got send'
Both GOT_FETCH_PKTMAX and GOT_SEND_PKTMAX had the same value.
Declare this value as GOT_PKT_MAX in got_lib_pkt.h instead.
- Commit:
bd3d9e54cb422cb58d52b267c6a8afc3376842d2
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move more code used by got-send-pack and got-fetch-pack to a common file
Move functions and data structures which implement Git protocol features
required for fetching and sending pack files to new files lib/gitproto.c
and lib/got_lib_gitproto.h.
This code was duplicated in got-fetch-pack and got-send-pack.
No functional change.
- Commit:
f024663dea0dea05a0d4c17d2314f38f73e85bc6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move pkt code used by got-fetch-pack and got-send-pack to a common file
The Git protocol uses a simple packet framing format. The got-fetch-pack
and got-send-pack programs contained identical copies of functions to
support this format. Move related functions to new file lib/pkt.c and
link both programs against this common implementation.
No functional change.
- Commit:
8991a328535f89f3f2257269f5c2d3fcec8bda69
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add a missing bounds-check in got-fetch-pack when parsing server response
The tokenize_refline() function could end up reading past the end of
the buffer if the refline is not terminated with whitespace or \0.
- Commit:
a90356f7c470563a35922c4cbb01824558dcf207
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent NULL deref in got-fetch-pack if server does not announce capabilities
The my_capabilities pointer may remain NULL. Check for NULL before use.
- Commit:
14d2b281dd2fafec8beebfca6b5911b0ff21d676
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix the error message shown when the server sends a bad ref line
Exposed by trying to run got clone -l against shithub.us over git://
found by abieber@
- Commit:
9ca26ac322eae778bdfe032617ce9f6af859bb7a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
style fix: avoid comparison of pointer variable against 0 in got-fetch-pack
- Commit:
98f64f14c3dc52ec6afc00acc53dc9f42399d363
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
work around spurious ACK responses from git servers in got-fetch-pack
The Git server can apparently send duplicate ACK responses even though we
do not enable the multi_ack capability. According to the Git protocol docs
the server should only send ACKs after receiving 'done' from the client if
multi_ack has been enabled.
However, a duplicate ACK response can be triggered by running 'got fetch -a'
in our fetch_update_tag test. This resulted in the following error:
got-fetch-pack: unknown side-band received from server
got: bad packet received