Commits
- Commit:
18441876c29142bdeb5910e372da1200c1b7bc20
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotsh handle poll timeouts when checking for gotd closing the pack pipe
This will hopefully fix issues seen on servers where gotsh exits early
for no good reason.
- Commit:
beb5455b68cf2c6513db813b7e36635a5685f95e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotsh: do not set POLLOUT flag when there is no data to send
Prevent an endless polling loop on Linux where POLLOUT and POLLHUP
can both be reported via pollfd revents.
- Commit:
baaae61518bf323d22055a3b02fc9e129ee6d567
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd avoid a "failed to push some refs" error from no-op 'git push'
gotsh was sending errors such as "unexpected end of file" and
"unexpected flush-pkt" to the client when the client disconnected
immediately after receiving reference announcements from the server.
As a result, 'git push' with both sides up-to-date would show an
obscure error message:
= [up to date] main -> main
error: failed to push some refs to 'ssh://example.com/git/repo.git
Now we see:
= [up to date] main -> main
Everything up-to-date
ok jamsek
- Commit:
1eb3899277955a87d80eef900b6ea458ff73bd6c
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
significantly reduce the amount of code linked into gitwrapper
By moving got_serve_parse_command() from lib/serve.c into lib/dial.c
as got_dial_parse_command(), we can significantly reduce the amount
of symbols gitwrapper depends on indirectly.
As a downside, gotsh now needs to link to dial.c. But it only uses the
same parsing routine, and any other routines in dial.c would likely
cause pledge violations in gotsh if used.
No functional change.
- Commit:
fd39115905268f01383ad19aee3aabb772854b68
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix an off-by-one in got_serve_parse_command() canonpath allocation
ok op@, tracey@
- Commit:
8d98a775225f31c6c2c71c5d40f1d323a6f552bd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix gotd sending too large pack files in some cases
Make gotsh pass all have-lines sent by clients onwards to gotd, reducing
size of pack files generated by the repo_read process.
Problem reported by naddy@
ok jamsek
- Commit:
87a3ab84d3eb87b790e3d34aeec2c344a8d7375b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
provide functions to parse/serialize different hashes
it abstracts over the hash type and ensures that object ids are zero'ed
before their sha1 digest is written. Needed by the incoming sha256
support.
ok stsp@
- Commit:
53bf0b541977b66862040d4b633fb6b5d3a3c6c8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
rename lib/sha1.c to lib/hash.c
It will soon grow functions to deal with sha256 too. stsp@ agrees.
- Commit:
5822e79e39a8777984e08b5d89a8c55d6aa0356d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done
mechanically with
find . -iname \*.[cy] -exec sam {} +
X ,x/<sha1\.h>/i/\n#include <sha2.h>
- Commit:
53e553e8ded01524f60c018b2266acc39af30669
- From:
- Omar Polo <op@omarpolo.com>
- Date:
tweak send_zero_refs; use GOT_SHA1_STRING_ZERO
ok stsp@
- Commit:
9a8e357c727600cb61ac6ec4c83259fa6d9a3081
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotd: implement the delete-refs capability
Allow clients to run "got send -d" against gotd. Clients will send a
zero-id as new id for a reference and, in the special but more common
case of just deleting and not updating, no pack file will be sent.
ok and tweaks by stsp@
- Commit:
a2c12f7b814f145ba507667dbf640253c87c3460
- From:
- Omar Polo <op@omarpolo.com>
- Date:
delete trailing whitespaces
- Commit:
f3dfebfc3bdd798342b4e7bde241e613af75efd8
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make read errors in gotsh serve_write() fatal, as was done for serve_read()
- Commit:
9aeaf23a7e94501bdcb20d18427620cf70b87995
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotsh: validate with parse_command before connecting
Export parse_command (now got_serve_parse_command) from lib/serve.c and
use it to validate the command line in gotsh instead of just checking
that the -c argument starts with 'git-receive-pack' or 'git-upload-pack'.
Invalid usage now always fails before opening the socket, while before
it wasn't always the case. This also means that invalid usage doesn't
count towards the limits.
ok jamsek, stsp
- Commit:
c808f450905feb2890b615ba1aeedb565e3fdd57
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fmt; fold long line
- Commit:
96afb0d62311dd459395b8eba2216094c18dfb67
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make read errors in gotsh serve_read() fatal and adjust tests accordingly
ok jamsek
- Commit:
f91b5c433d4c2fb2e80053859b6f15c9239b3231
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
only "forward" implicit flush packets in serve_read() if they are expected
ok jamsek
- Commit:
fecfd5bc4d412263e1178f9b6edf69709ea6e273
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix spurious "gotsh: unexpected flush packet" error when client is up-to-date
ok op@
- Commit:
f9550d472ec2151070b5bef2bd3b950d9f8e7949
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix an issue where gotd fails to accept multiple have-lines from clients
ok op, jamsek
- Commit:
00b3e9ae14f04a45f1ca7445bade6b41a6e8a1c5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
replace malloc+memcpy with strndup. no functional change intended
ok stsp@
- Commit:
d10629e6628f13c08f5b6013d0f1b68630acc383
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove bogus abort() call from gotsh echo_error()
- Commit:
2ff9f0818d453fcbfcf4843b368604f277cf4458
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix capabilities announced by gotsh when no reference exist in repository
ok op@
- Commit:
c6b5adb85da13d21aa8937805dce16fedb07272b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix sending of capabilities from gotsh(1) in case repository has no refs
- Commit:
758dc042e8fc2399dc58d96ce6d80b4a0adf4705
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove trailing whitespace; patch by Josiah Frentsos
- Commit:
1c9d898d6c7c6c8681e8e191ebe2c01b8d066f6e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid incomplete writes of buffered pack file chunks in gotsh