Commits
- Commit:
be97ab03efd83aac37b83f2df2dea936213b456c
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
refactor got log -d and tog diffstat to compute diff once
This eliminates the previous performance cost by making 'got log -d' and tog
diff view compute the diffstat while building the diff in a temp file like we
do with 'got diff -d'. Also, keep the current 'got log -d' UI as per stsp's
suggestion.
ok stsp@
- Commit:
5c24b9c1a40292f6b5b88d32a9945dd3440b2ed2
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
don't use plural noun after 1 in diffstat total
Use singular form when appropriate; for example, turn the top into the bottom:
1 file changed, 1 insertions(+), 1 deletions(-)
1 file changed, 1 insertion(+), 1 deletion(-)
ok op@
- Commit:
0e762e67cef9321f74d4fcec9f27811c9a7fbd9d
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: fix {first,last}_displayed_line dead store
Both are already assigned just above in open_diff_view()
ok op@
- Commit:
1a0805676b811f75437d3194775020a0341ace96
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
typo: zap double semi-colon
- Commit:
21c2d8be42605670e7037d011fea06c5efd5f725
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got: minor refactor of got_pathlist_free() API
Accept flag parameter to optionally specify which pointers to free. This saves
callers looping through the list to free pointers.
ok + fix stsp@
- Commit:
53d03f970a594ed205147f847c825c9b4752c3fd
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got: expand diffstat -d option to 'got diff'
Like got log -d, add the switch to 'got diff' to display a diffstat of changes;
as per stsp's suggestion, we always include diff output with the diffstat.
Disabled in gotwebd (for now :) Includes tweaks from op@
ok stsp@
- Commit:
aa7a1117140efb46d2d3c82fa22087ea65ec6697
- From:
- Mikhail <mp39590@gmail.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: add mutt-like =/* keymaps as home/end aliases
Also, separate g/G from home/end in the manual and runtime help text as only
the former accept a prefixed count modifier. Based on initial diff from Mikhail.
ok stsp@
- Commit:
48830929110975bbf1aeab8dff472d33f50fa548
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
show from: and via: headers on consecutive lines in 'got log' and 'tog log'
ok jamsek
- Commit:
772fcad51433f2ecbfaea38a78e02d07ed1eef7f
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got: implement diffstat for got log and tog diff view
Add new got_diff_blob_cb() implementation to compute added/removed line metrics
for a given diff. This enables displaying a diffstat with 'got log -d'. As per
suggestion from stsp, change tog diff view to display the diffstat by default.
ok stsp@
- Commit:
8eca0bdb19386799f23e248e19627d62eeb65c50
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make 'tog log' display the committer handle by default, '@' switches to author
People coming from CVS might not expect names of patch contributers to
show up in commit history listings, so make things easy for them.
discussed with op@
- Commit:
d07291c6a134e3b3b58ac871c332d7b472008f5d
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: always echo input prompt to bottom left of screen
Irrespective of the active view, always echo to the bottom left of the parent
view.
ok op@
- Commit:
85fbc3608c5e4a2ca0657106c056a784ef712ffe
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: fix typo that breaks log search when in hsplit
Ironically, the typo "blocks" log search when in hsplit because we block input
on the wrong view! Pass the proper "v" view to nodelay() calls.
ok op@
- Commit:
466429a10acdc69e2e92b490782f474e3971d5b0
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
cope with deleted references when reloading the tog log view
ok op jamsek
- Commit:
27a7eb2334fa33dee50546dc3b0d8cd4eb770923
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
avoid printing harmless errors that can occur when tog exits due to Ctrl-C
ok jamsek
- Commit:
47cc6e779191771a207495fd7e4d1cbe915f71d7
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix detection of SIGTERM in tog; this signal was accidentally being ignored
ok jamsek
- Commit:
0a58e7222f591acd7479040f317f1e0e0e9d132e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
sync usage with reality
The -h and -V/--version flags must be given before the command; with
those flags the command is actually optional, but don't over-complicate
the usage string with these nitpicks.
ok/improvements stsp@
- Commit:
ba5cc5fa6d3cb2de42937287ae932026dbf967ad
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
backout Make & command in tog's log view display "searching..."
The limit feature is more than just a search operation, tog's man page
has been updated accordingly.
- Commit:
d0d3e7a4b8abe052820792c09bcdbd763b6be711
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tweak view name display in the help screen for clarity
- Commit:
d2c172746f7e32f0649b60375e77ec77363ca7df
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
Make & command in tog's log view display "searching..." while loading commits.
This command acts like a search operation, and the display should reflect that.
- Commit:
850265be5c1846c742ea6b6413d52a8c3118cadf
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix indentation; from jamsek
- Commit:
06ff88bb4fd24d28eac73efe33f3a92ad5369a5b
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make exiting tog's help screen easier for new users
ok jamsek
- Commit:
a7dd23ad257cf5f2f45268ad73afb49be16ae110
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: open help in fullscreen irrespective of view configuration
Prompted by a suggestion from stsp to make the help view distinct rather than
follow the default behaviour of established views. Occupying the fullscreen
seems to be a somewhat established convention for TUI apps.
ok stsp@
- Commit:
6f6c25d65e82e60c44877d2aa05bcbdbc48e65b3
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
drop unconventional got_object_commit_dup() routine
Replace with got_object_commit_retain() to increment commit object
reference counter.
suggested by and ok stsp@
- Commit:
30e77f6ad14985d6db8d179b7ed73dc4c8cab68a
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: don't embed utf8 glyphs into tog.c source code
Reported by stsp: Embedded utf8 precludes developers running C locales
from browsing the code. Fix was suggested by stsp with hints from the
tmux(1) codebase.
ok stsp@
- Commit:
2a7d3cd7fd18be5657ca71a452a73ba70a8530e5
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: refactor search setup into tog_view function pointers
Suggested by stsp. While here, add declarations for new help view routines.
ok stsp@