Commits


preverse binary files during updates and merges


set oldo.to in diff3.c's duplicate() even if the file contains no newlines


always initialize output parameter "n" of get_line() in diff3.c


fix another segfault in edscript() Same problem as fixed in 90de04bc7f1b85b9c491bcd124f6178fad005de1. ok stsp


fix a segfault in edscript() introduced by my previous commit Found by our cherrypick regression tests.


fix merging of files which contain a dot on a line by itself Annoying bug which we inherited from OpenRCS which inherited it from OpenBSD's diff3 program. ok tracey millert


portable: initial Linux compilation This commit modifies the GoT main branch to be able to compile it under linux.


indentation fixes


use Patience diff for merging during cherrypick/backout/histedit/rebase This has been shown to prevent mis-merges in some cases. It's probably not a final solution. We should look at what Git's "recursive merge" is doing and implement something similar. Keep using Myers during update/unstage. The advantage of Myers is that it produces smaller conflict chunks, and there are no known cases of mis-merges which affect update/unstage.


make merge_file() accept FILEs instead of paths for orig and deriv inputs


fix 3-way merge of files which lack a final \n problem found by jrick ok millert


use Myers diff instead of Patience diff when merging files with diff3 Myers diff tends to divide files into smaller diff chunks, while Patience diff attemps to maximize the size of diff chunks. Smaller diffs chunks generally result in a more managable presentation of merge conflicts.


make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere ok millert, naddy


use size_t for loop indices to avoid signedness warnings; from emaste@freebsd


consistently label removed files as "/dev/null" in diff headers


handle binary files in got/tog diff commands; add -a options to force text


merge new diff implementation from the git.gameoftrees.org diff.git repository This new diff implementation was started by Neels Hofmeyr during the u2k20 hackathon and now replaces diffreg.c code lifted from the OpenBSD base system. The integration of this code into Got was done by me. Got now uses the patience diff algorithm by default. The diff.git repository will remain the primary repository for the diff code, which already compiles and runs on other operating systems such as Linux. Any fixes and improvements for files inherited from the diff.git repository should be written against that repository and synced to got.git afterwards.


fix merging with files that do not contain a newline character; ok millert@


make tmp dir location a compile-time setting and change gotweb's tmp dir We are not sure whether a gotweb package can own /var/www/tmp on OpenBSD. Moving gotweb's tmp dir to /var/www/got/tmp sidesteps that issue.


fix build on sparc64 (uninitialized variable)


show base commit hash and omit filenames in conflict markers


show original file content in conflict markers


improve use of mixed size_t/off_t types in diff3.c's edscript()


diff3.c: do not use the same variables for both line numbers and byte offsets


diff3.c's skip() returns number of bytes skipped so switch from int to size_t