Commits
- Commit:
80ca8b0f888ae433e7e8e39317ab5647687e2c23
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: add missing closing for div tags_content
reported by the W3C validator.
- Commit:
66ca6940e6deb73fc261872c44f4d17c62edc01b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
free the return of got_repo_get_path_objects{,_pack}
- Commit:
12e242cc147359760295ebf3098d829c208aa52a
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: plug leak in got_output_repo_tree
- Commit:
686a711704036333d33dca7a63fa3501d4d6acdd
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix page title
due to an error in the order of the arguments to fcgi_printf that I've
introduced last time I touched gotweb_render_header the title is now
"/" (or SCRIPT_NAME) and one assets (the safari pinned tab svg) is a
funny URL :)
- Commit:
cacf16907d60b1450a87868913052cb6dd375b24
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: ensure stdin is a tty
This guards against {mis,ab}use such as `tog < /dev/null`.
ok plus fix from op@
- Commit:
a004b24a97cfaa2be171871f42cdc15e24fa8682
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: shrink struct server
keeping GOTWEBD_REPO_CACHESIZE * sizeof(struct cache_repo) inside the
struct server makes it too large for imsg on some platforms (linux at
least.) Instead, store a pointer and allocate the array when it's
received on the child processes.
ok stsp@
- Commit:
5baa5fe241b3b9bb4bc6f68b06d18ea4094ad579
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: MacOS: harden homebrew checks
When building got-portable for MacOS, don't assume the toolchain
programs are in /usr/local. This used to be true before Apple silicon
existed, but since then the paths have changed.
Instead, ask brew(1) for its prefix (if it's installed), or default to
/usr/local if not.
Noticed by Lucas.
- Commit:
43be1edb0aebe761af9941921b0d17db40d98979
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix crash handling -D
Avoid crashing by corrupting the pointer instead of writing to it and
fix how sym is generated: it shouldn't include the '=' sign.
ok / improvement tb@
- Commit:
41861f2b47879010d252aa5a6d8a7f8f734041f0
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
avoid a pointless malloc/free in got_reflist_insert() in my previous fix
suggested by op@
- Commit:
21de8138fee88f812099d8b0b71d8280f4f6ba4e
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
detect packed vs. on-disk reference collision when listing refs
ok op@
- Commit:
d68b973725ce0a2c7b1f5094448a444d4f2effdc
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
plug leak in the commit graph iterator
We fail to release the memory for the nodes. To fix it however, we some
consumer of the commit graph iterator need to be corrected: the returned
pointer is safe to be used only up until the next iter_next call;
save a copy it if it's needed afterwards too.
ok stsp@
- Commit:
95326260eb5a3786dbd04e735b6c8c9313523ff2
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix usage of the commit graph iter
got_get_repo_commits mixes ids allocated on the heap and the one
returned by the iter_next in the same variable, and then even attemp to
free it.
This is both a leak (we loose the pointer to the previously allocated
id) and a possible invalid free since the object id pointer returned by
the graph iterator is not to be passed to free(3).
part of a bigger diff that's ok stsp@
- Commit:
7ee8c11a1c0b35faced7b53a32b5a43b0f45b764
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add missing freaddrinfo
also spotted by valgrind. ok stsp@
- Commit:
e476ee5e274eada26700de434b1500a7d8f71b97
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
release the memory used by the object cache
Leak spotted by valgrind. ok stsp@
- Commit:
99c6f580a3ccd12811e726f6773d468eb0952427
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
replace an indirect call to idset_add(), via add_node(), with a direct call
Avoids leaking the node structure returned from add_node().
ok op@
- Commit:
e4ca14132ba73f03dbfbdc465d31619781b465f3
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got: fflush(stdout) after asking questions
Not everywhere getline does an implicit fflush, so we might end up not
showing the prompt to the user. Spotted on alpine with muslc.
ok Thomas Adams
- Commit:
07894e99b111edc91d20565e0982344b52b32095
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
free commit on error path
while here drop the ternary too: if add_node succeeds `new_node' is
non-NULL. ok stsp@
- Commit:
f3933be66b2ab372f0f0b48b3dec7bc6d21b170a
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
plug leak: release nodes not added to the iter list
ok stsp@
- Commit:
599785e85d854563801d9640012f93e799ff87ea
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got_commit_graph_close: free tailq contents
The tailq should ideally be empty when we reach got_commit_graph_close,
but consumer code may exit the commit graph loop earlier.
spotted by and ok stsp@
- Commit:
8dbcf3885ae920e0fd38a455e7577824989a605f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
forbid rebase of references outside the refs/heads/ namespace
ok jrick
- Commit:
35eabca99227d5245619972d35e5229c63c248db
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
plug leak in resolve_symlink
ok stsp@
- Commit:
2ac684a4e1b8a971689edc8c5543832dd1b9db0e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: percent-decode the received query string
ok stsp@
- Commit:
a6fd182ad357eeabb88cffe83d799b412e4cdab7
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
plug mem leak in got_repo_pack_fds_open
pack_fds_tmp is not always free'd. However, while here, simplify it to
not use a temporary array.
ok stsp@
- Commit:
aefd24c9f8aab7588c262b45581331004a959717
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: free obj_id and reflist in got_output_file_blame
ok stsp@
- Commit:
d38635a394cab631d6a100b34ae0bd6f9b651bba
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: got_output_file_blame: free lines on error path
ok stsp@