Commits
- Commit:
c13168e4b762e0d3808d1c60190a7eb70e27ee8a
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
refactor gotweb_load_got_path; no functional change
ok tracey@
- Commit:
ab5bda7ecb7748b16898b3af71948dc94ce96296
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove the gotwebd repository cache
It only had 4 slots so was never quite useful, and sharing of sock->pack_fds
across cached repositories seems problematic.
with help from + ok op@
- Commit:
aea518b5677939b97a7c9068389ec98a00dc0ffc
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
whitespace fix
- Commit:
f85c939fb7758c7cad91e0705b4d932d52597867
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: get rid of proc.[ch]
proc.c really shines when there's a network of different types of
processes, potentially with a various number of instances each,
that needs to exchange messages. Gotwebd instead has a much simpler
design, and using proc.c causes more overhead (/headaches) than it
solves.
So, this attempts to provide the same functionalities but with a
much simpler implementation that fits gotwebd better.
ok stsp@
- Commit:
b38e9a2a1732c7dd3d16d76facf977f5a4c4a454
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: improve gotwebd_assign_querystring()
This prevents the issues that we just hit with forgetting to remove
PREVID: instead of relying on the enum value to yield the size of
a table, use nitems(). Also, quit as soon as the matching key was
found, no need to iterate further.
ok stsp@
- Commit:
4cc0851e23123ddf7f312ece3b974f652d01c6b9
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: render all the datetimes in a time tag
fixes an unused variable that should have been dropped in previous
commit too.
ok stsp@
- Commit:
10fa70e266dcd8539efd48ef30628e48068cb5b4
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: inline the only use of TM_RFC822
- Commit:
d8bf4f258cbea84e319b0ed044224aaac37a085c
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: move the buffering from the fastcgi layer to the template
Reduces the indirection in fcgi.c, starts to make the struct template
opaque, simplifies the template usage. All with a net negative :-)
reads fine to stsp@ (thanks!)
- Commit:
b38bef130a0b3f87cc472394f280940bd4e72238
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix branches modification time with show_repo_age off
If show_repo_age is set to off, got_get_repo_age() returns without
setting the timestamp. got_get_repo_age() is also used by the
branch listing to show how old they are however, and we end up
rendering the stack garbage.
Instead, respect `show_repo_age off' one layer above, and always
return a timestamp in got_get_repo_age(). While here, initialize
the timestamp to zero so it's set also in case of failures.
Issue reported on IRC by xs, thanks!
- Commit:
b2251e6e28d03b19582a716bf2b3e20bb663d037
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
bubble up got_repo_commits()
now that got_get_repo_commits() doesn't look at `action' we can stop
fetching the commits during the rendering and bubble up the call.
This yields better error messages and better replies codes on failure.
- Commit:
b95d1cf6b000a7750270aced50dba0807da41467
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
simplify gotwebd' server matching
Currently, if there is not a match on the server name, it attempts
to match the "subdomain" against the server names, and fall back
to the first server defined.
The server name is taken from the SERVER_NAME fastcgi' parameter,
the subdomain extracted from HTTP_HOST.
Keep only the SERVER_NAME matching, but still use the first server
defined if there's no match.
Fix the manpage documenting how matching works and drop the lie
about SNI as gotwebd doesn't do TLS but just looks at what the
upstream http server decided.
ok stsp@
- Commit:
b2b363b2f464c849ea73a94e6b2be46339b06275
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
retire GOT_ERR_QUERYSTRING
it's redundant with GOT_ERR_BAD_QUERYSTRING; convert its only use
to the latter.
- Commit:
102d840de78061d9f313aaa557ef64f586932143
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
dropping unnecessary strlen()s
ok jamsek, stsp
- Commit:
d8edcc947b59de53c551373983750441a33bbe02
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix some got_error_from_errno2/3 calls
it's not printf-like so %s don't make sense. Tweak the order of
the arguments to obtain the intended output.
- Commit:
ba77389f9f3a659ebd77c8a4b4974c645e0530fd
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
don't zero fields of a calloc()-allocated struct
- Commit:
d00235d81cec70db37ca306ea1db137a5464982e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@
- Commit:
54ca6e2b432edddabc0fca60a74968e6ef4bf790
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
log close() failure in gotweb_free_transport
- Commit:
04b2c111f2cee68f0aa07855fcb7329a4913050b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
simplify got_gotweb_openfile/flushfile
Return only the FILE *, and require only that to close subsequently.
Having to manage the file descriptor too makes using these functions
unnecessary complex.
millert@ agrees
- Commit:
f5af6dbdad26b33fb5531b4a06f3b48f77a7db31
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix logic error and skip again some entries in the index
logic error introduced in df2d3cd25
ok stsp@
- Commit:
44f2135acadb53e3cdc7d9029b48fea665cf7e4f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: don't special case BLOB, BLOBRAW and RSS
shuffle some code to handle all the page types in the switch.
ok tracey@
- Commit:
164b5ddc668e203c83442bd6cd0860eba648e885
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: reply with non-200 HTTP status code on error
ok tracey@
- Commit:
161663e7ebf5aa10caf7b4048f013d5e45db5fe3
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: provide gotweb_render_page() entrypoint for all pages
simplify gotweb_process_request more, handling all the pages
inside the big switch. There's only one entrypoint for rendering
the templates gotweb_render_page() that takes the page' content
as argument.
The only real difference is that gotweb_render_index() now skips
directory entries which fails to handle.
ok tracey@
- Commit:
4fccd2fe0ffbbc668b66abe63614470635f92f1b
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: configure: split out dependencies
Rather than assume all dependencies are required for all programs, split
them out.
This will make packaging easier, as well as splitting the code to use
subprojects.
Note that due to the use of config.h semantics, in most cases the
got_compat.h header file is now at the top of the .c file it is included
in, so that it can handle the system header inclusion properly.
- Commit:
98670ba726486c39efff220ab1e074c62023aae7
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: rework SHA detection
Simply the SHA detection by not predicating on libcrypto, but instead
checking individual header files.
- Commit:
4680f704353811c8bb6ce65eac3714d1bd200c26
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: remove sha1.h; found portably
Remove sha1.h as this is found portably across systems.