Commits
- Commit:
8ec7352a93a3c62a7786b92e4183aa7cb0b34869
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
only delete empty directories appearing in arguments to 'got rm'
Make 'got rm' keep empty directories which are not explicitly listed for
deletion. Deleting such directories is problematic in several use cases.
Avoids deleting the current working directory when the user runs "got rm *"
(pointed out by Mikhail), and avoids deletion of an empty directory "foo/"
after 'got rm foo/a foo/b' (pointed out by op@).
ok jamsek, op
- Commit:
00580e07010e9d6aab00f67b628381ca81f19def
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix refs_str memory leaks
Pointed out by op@
- Commit:
cabb4cfd832114dd19f9e48a7640a7527dc4f755
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rework how reference labels are rendered in the tog log view
Draw reference labels and log message as separate strings. The previous
code contained calculations mixing variables which represent an amount
of wide characters in a string vs the display width of the string. We
can avoid such nonsense by keeping the strings separate, though we have
to be a bit careful about keeping horizontal scrolling intact.
Also fix a bug where we failed to account for reference labels while
setting view->maxx which made the $ key not scroll far enough.
ok op@
- Commit:
d8edcc947b59de53c551373983750441a33bbe02
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix some got_error_from_errno2/3 calls
it's not printf-like so %s don't make sense. Tweak the order of
the arguments to obtain the intended output.
- Commit:
d6e785550aafeec2ec66d26c39b8453268c9d657
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
consistently use ten Xs in mkstemp(3) templates
patch from Josiah Frentsos, thanks!
- Commit:
201812127e27ef2aa4827752e229d8f5251f6ff6
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
typo: character -> characters
- Commit:
0d095295f9c0504bf7b11611b530becd27f34ee1
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
stop showing backup references in the tog log and diff views
Backup references clutter the log view too much now that we display
labels next to commit messages.
They were accidentally added to the log and diffs view by me, via
build_refs_str(), when support for listing backup references was
added to the ref view.
- Commit:
fcfb26c37e218d01b0cfb8b960b7b186f9ee285e
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix 'tog log' display regression with long reference lists
When the terminal becomes smaller horizontally we did not properly
account for remaining columns and the log message of a commit could
overflow into the next line, garbling the display.
- Commit:
3785c9e59d01b1954a7478be06382ca98f097bb4
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add a gotd todo item
- Commit:
d22dbfabbce4e24cff123667640468944483a30f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
trim trailing whitespace in TODO file
- Commit:
768236a07f62e0df2ee0a9c5bc7c2107dd970d51
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make gitwrapper not fail if programs it wants to run do not exist on disk
- Commit:
a4c8ed779e07ca691ec6ad2651d059dc673403bc
- From:
- James Cook <falsifian@falsifian.org>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
simplify ancestry checks in checkout, update, rebase, and merge
No behaviour change as the end result of the rewritten checks should
be the same as before. We are just doing less work where possible.
Patch by James Cook
- Commit:
61f9965eb408b8f749dbbcb42d49b88c9d23788e
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix the size of gotwebd's array of tempfiles used for deltas
Prevents ftruncate() errors due to bogus file descriptors passed from
gotwebd once the repository layer runs out of temporary files to use
for deltas. Have gotwebd open the maximum amount of required temporary
files for now. A proper fix which scales to lower ulimit -n settings can
be implemented later.
Problem reported by patrick@
- Commit:
e18312d9b6e6e3f6c78f904238ceaae3b8d4ccac
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
reword misleading comment in struct got_repository WRT struct got_pack
- Commit:
8e839f3b4912a02438523ac7256908a8f4ec252f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotd no longer uses chroot; remove comments suggesting otherwise
- Commit:
72f5a11aff98b21aafaf38400707411549e7c12b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: avoid needless double fseek()
got_gotweb_closefile() already takes care of rewinding before
truncating and closing, so no need to replicate here.
ok stsp@
- Commit:
aa2aecab69ed4f6ff9ab2a5bb7e32109cf95aefc
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: lower log priority of unexpected disconnections
no need to be so loud when a client disconnects earlier than expected,
log it only in verbose mode. Don't log GOT_ERR_CANCELLED too since
that is only used to communicate the callers that we need to stop.
ok stsp@
- Commit:
00ddec2f20c1ce1b0136a7ae54efb790069126ec
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
relax build_refs_str to allow a NULL reflist, simplifes the callers
ok stsp@
- Commit:
5e43aca66f1762b7612d9efb4b000575f1b7a3ab
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
oops, one was missing
- Commit:
a97a7b2d0f3aef38c682073294822e88e1c2ef1c
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got_operations.c: use consistently a space before labels
makes diff prettier and easier to read; instead of the label we
have the function name in the hunk line.
- Commit:
2a18388f44a486d45efd0594e4cfa3d7ddeaebdf
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix indent; touches only `return 0;' lines
- Commit:
61dc16bb64b935a7b13342b8bc47db282d10e676
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: fix segfault in draw_commit
build_refs_str() can succeed returning a NULL string if a commit
has some refs pointing to it but that were all filtered out, resulting
in a NULL-deref.
ok stsp@
- Commit:
ba77389f9f3a659ebd77c8a4b4974c645e0530fd
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
don't zero fields of a calloc()-allocated struct
- Commit:
c4c6774f44148ea66dc566dfdcf36f531f9e5291
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove fsync() from got_gotweb_closefile()
discussed with millert@
- Commit:
d00235d81cec70db37ca306ea1db137a5464982e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@