Commits
- Commit:
936239010f884c916c0f8680490fea91813b5334
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got-notify-http: add a type:commit field in the json
will help to differentiate these notification objects from the
others.
- Commit:
a4656c38219b986dc7919a9c5c36195b9dd0acee
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
small man page fix, spotted by op@
- Commit:
f4ab0e5770b96257cb1a43cfe292daa54f2b402e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make 'got status' display interrupted rebase, histedit, and merge operations
When an operation is interrupted add a trailing message to status output
which displays the operation and branches involved.
This information will be useful when diagnosing problem reports and it
helps new users with contextualizing multi-operation work tree state.
ok op@
- Commit:
a397e3fbad25f5da2f4a33e1d2ac8248f32aa24b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
man nits; found with mandoc -Tlint
- Commit:
8af456a9cc91eb4cba92e455baf06e679fe9ced6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
forgot to unveil the log message file passed to got commit -F
found by op's regress builder
- Commit:
a854b8c994a1381e4c6f2ba45bef9c22da0ec956
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
initialize and tidy up *branch_ref in got_worktree_histedit_continue()
- Commit:
ec405b99414136a277c6d2bc223a538d9d701ccc
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got-notify-http: refactor jsonify()
To support the other types of notifications, we can't just peek at
the first byte and decide wether it's a short or long format.
Refactor the parsing so that there's one main entrypoint, jsonify(),
that calls jsonify_comment() or jsonify_comment_short() depending
on the format of the line. Other "line types" will be added as a
follow-up to support the other notification types.
- Commit:
efcfe9187f7bcd4faecb4eabda86f3a921c62387
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fold some long lines
- Commit:
ac0a4dfc3547f38c3fe0544f329f3c7bded24010
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got-notify-http: change the layout of the json
Split the author/committer in sub-fields, rename author -> committer
in the short format parser and cache the author for the long format
in case it's the same user as the committer. Put a copy of the
first line of the commit message in the "short_message" field.
There's some redundancy now, but it's to make consuming easier.
ok stsp@
- Commit:
909ef56bac18cdc0d889412542697be574acfe6b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
call unveil earlier in 'got tag'
We now know that unveil(2) will never traverse exec.
No need to wait with unveil until the editor has been run.
ok op@
- Commit:
b56c985f97e99640c7e2f2f48dccabbc05526069
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
call unveil earlier in 'got histedit'
We now know that unveil(2) will never traverse exec.
No need to wait with unveil until the editor has been run.
ok op@
- Commit:
aaa8879b1ecf56fbe7d69e69a6e951db4d8cb806
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
call unveil earlier in 'got commit'
We now know that unveil(2) will never traverse exec.
No need to wait with unveil until the editor has been run.
ok op@
- Commit:
2f40f7d278bccb8402479f25d13145bdc199bfb7
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
call unveil earlier in 'got import'
We now know that unveil(2) will never traverse exec.
No need to wait with unveil until the editor has been run.
ok op@
- Commit:
cdaefb15ec98f4140621e87d6e7a2526ce29c495
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix typo in a comment
- Commit:
ea5e974da9b1047689411a00ecc0a9c1fb101d73
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got-notify-http: fix unicode handling
JSON strings are made of UNICODE codepoints, of which only \, " and
control characters have to be escaped, and the whole document MUST
be encoded in UTF-8. The current code generates invalid strings
for non-ASCII characters, so it has to be made UTF-8 aware.
tedu' isu8cont() can't be used since it allows surrogate pairs and
overlong sequences which will cause decoding errors on the receiving
side. Similarly, mbtowc() depends on the current locale and could
cause issues in -portable.
Instead, bundle Björn Höhrmann's "Flexible and Economical UTF-8
Decoder" and use it to parse the text. Decoding errors results in
the replacement character U+FFFD being emitted and the bytes
considered so far to be discarded; the decoder is then restarted
with the next byte.
Git commit messages don't carry the notion of the encoding, but
it's reasonable to expect UTF-8 (which is a superset of ASCII).
For other more esotic encodings, the commit id can be used to
manually extract the data.
ok stsp@
- Commit:
87890bc26c1c6958bd64bb9d46fbc29ba6a92d95
- From:
- Omar Polo <op@omarpolo.com>
- Date:
http_notification regress: prettify the json
long lines are not manegeable. split the json over multiple lines,
then use ed to join everything back in a single one.
- Commit:
9e88f9d9a5df5ab1462296b2ba998f33a1c56ea4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
regress: http-server: hide the HTTP headers
The http-server script is already validating the headers, doing so
in the regress too is not helpful.
- Commit:
3b44bdbe821e92c08ae1074b204b273b661e1941
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got-notify-http: reject 3XX status codes
At least for now, we don't support following redirects nor retrying
the post, so consider a 3XX status a failure too.
- Commit:
83fccf2ddf25d8a98b076afeb22dfa6d7f6aaad2
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add my name in the bufio sources
- Commit:
0f665edb9f45db7923e99c942364d88420f4b3f4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
adjust expected output in the regress
- Commit:
5565365ce71d431c522f98b121706b13c4bf2d22
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add got-notify-http
ok stsp@
- Commit:
f9e6537008c7344a6107b88bc19c5f293cacd793
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix gotd_parse_url()
A path of "/" is valid and trailing slashes must be preserved.
ok stsp@
- Commit:
fb5636bebb6e4d59f4bbc0fd78650714474ac681
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add a messagelen field in the notifications
Similar to the `got cat' output; it's needed to un-ambiguosly parse
the content of the notification, which is already useful to parse
the email content and invaluable for the upcoming got-notify-http.
ok stsp@
- Commit:
98297eed5b9082b66f6397a0921c8d90df72cca1
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rename got_commit_graph_iter_start() to got_commit_graph_bfsort()
This function begins a breadth-first traversal. The new name makes
it easier to distinguish from got_commit_graph_toposort().
- Commit:
371457e66c4c0ce1ae8880e2346336a14ad6cf6d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove a confusing comment
This function starts a breadth-first traversal, not necessarily first-parent.