Commits
- Commit:
ce1bfad9f1f7c6b1599e0bfed0a1b169d4a30781
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add initial support for commit notifications to gotd(8)
At present only email notifications are implemented.
Code for HTTP notifications is not yet finished, hence HTTP-related
documentation remains hidden for now.
This adds a new 'notify' process which has an "exec" pledge. It runs
helper programs which implement the notification transport layer,
such as got-notify-email which speaks SMTP. This design avoids having
to link all of gotd with network libraries and related crypto libraries.
Notification content is generated by the 'repo_write' process. Commit log
messages and diffstats are written to a file which the 'notify' process
will pass on to its helpers on stdin. The default output looks similar
to 'got log -d'. If too many new commits are present the output looks
similar to 'got log -s' instead. Tags always look like 'got tag -l'.
The session process coordinates generation of notifications. It maintains
a notification queue which holds one notification per updated reference,
and passes notification requests from this queue to the 'repo_write'
process for notification content creation and then to the 'notify'
process for notification delivery.
Only one notification can be in flight at a time to avoid file descriptor
starvation if many references get updated in a single client session.
ok op@
- Commit:
342fdad21f737bde2399231d772477d1b2221fe1
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
avoid a rename/stat race when gotd installs a new pack and then uses it
Reset the cached repository's pack directory mtime after installing a new
pack and pack index file. I have observed the mtime of the pack directory
as reported by stat(2) remaining unchanged, until some time has passed
beyond the rename(2) calls used to install the pack file and its index.
If gotd immediately tries to read objects installed in a new pack file then
the mtime reported by stat(2) might appear as unchanged. gotd will then fail
to update its cached list of pack index files and not find the newly
installed objects.
Clearing the cached timestamp forces a readdir(3) call which does expose
the newly installed pack index file as expected.
Not sure whether stat(2) is supposed to immediately expose mtime changes
after a rename(2). If so then this might warrant digging into the kernel.
Seen while running regression tests for upcoming gotd notification support.
- Commit:
e8c5d4f87401e77adfdec88437f3b973e7b47262
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
reuse existing repository struct in gotd session update_ref()
Avoids pointlessly opening and closing a separate repository instance.
- Commit:
04ddbc75ae91738a071c04bb2f2d6c9ff4dac225
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove unneded wbuf->fd = -1
There's no need to set the fd to -1 on ibufs created with imsg_create(3),
and it was probably never needed.
- Commit:
3d97effaa4fe16c79f725bf260f06220e62e5c6a
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
convert to use imsg_get_fd()
While here also fix a fd leak in got-read-pack. We were dup'ing
imsg.fd without closing imsg.fd later; instead just use imsg_get_fd()
to extract the file descriptor.
Tested by falsifian and Kyle Ackerman, thanks!
'go ahead' stsp@
- Commit:
44f875ad4b93ddb8d0e717a6ca564ce84de7f4e2
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
avoid opening objects in the gotd session process for no reason
The session process opened an object as part of a sanity check and
simply closed it again. Opening an object involves decompression
and combination of deltas. Add a new interface which checks whether
an object ID exists without such overhead and call it from gotd.
- Commit:
4efc8dcb177f6c378c12a7d91f51e6ae4e80078b
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: gotd/gitwrapper: update for libs
Bring gotd and gitwrapper closer to how libraries are detected.
- Commit:
febe25b7cf7410d2a34c127b3981acd3b98edc2d
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: gotd: listen
Include listen.c; make it portable.
- Commit:
c8b73ac1663c35b32c7f8ce4173765461b72f3fa
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make gotd flush pending messages before disconnecting the client upon success
This prevents gotd from closing the client connection before ref-update
status reports have been sent. Seen while testing gotd on Linux, though I
see no obvious reason why this race would not trigger on OpenBSD.
- Commit:
a6153ffb9ee91bb4fc544a98fae8d50cf2963841
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotd: stop logging "unexpected end of file" when a client decides to disconnect
- Commit:
7fed8fa426806e627fcf1e344e4ce134b17a0474
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
unveil repositories read-only in gotd session process while serving fetches
ok op@
- Commit:
8a9c582ba19796492dd5fa3415eccd70d406d7d4
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make gotd show relevant commit hashes in error message if ref-updates collide
- Commit:
169def413f9c30c59bd16b6ea8c65db2ccce4017
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make gotd avoid re-writing existing ref files when a ref-update is a no-op
- Commit:
8e92c55c71ddc358748f608f316cbc53b008f79f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make gotd avoid a "failed to push some refs" error from no-op 'git push'
gotsh was sending errors such as "unexpected end of file" and
"unexpected flush-pkt" to the client when the client disconnected
immediately after receiving reference announcements from the server.
As a result, 'git push' with both sides up-to-date would show an
obscure error message:
= [up to date] main -> main
error: failed to push some refs to 'ssh://example.com/git/repo.git
Now we see:
= [up to date] main -> main
Everything up-to-date
ok jamsek
- Commit:
4fccd2fe0ffbbc668b66abe63614470635f92f1b
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: configure: split out dependencies
Rather than assume all dependencies are required for all programs, split
them out.
This will make packaging easier, as well as splitting the code to use
subprojects.
Note that due to the use of config.h semantics, in most cases the
got_compat.h header file is now at the top of the .c file it is included
in, so that it can handle the system header inclusion properly.
- Commit:
98670ba726486c39efff220ab1e074c62023aae7
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: rework SHA detection
Simply the SHA detection by not predicating on libcrypto, but instead
checking individual header files.
- Commit:
4680f704353811c8bb6ce65eac3714d1bd200c26
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: remove sha1.h; found portably
Remove sha1.h as this is found portably across systems.
- Commit:
be288a59f42e0b5e203e2c5545bf3e042ff4b79f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rename lib/sha1.c to lib/hash.c
It will soon grow functions to deal with sha256 too. stsp@ agrees.
- Commit:
588a8092bc282294ee23585991e81586905a8fd4
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done
mechanically with
find . -iname \*.[cy] -exec sam {} +
X ,x/<sha1\.h>/i/\n#include <sha2.h>
- Commit:
5330ab762909f51f51f564f8b8af9eac9c8f4354
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
drop double process name from some gotd logs
i.e. "listen: listen: shutting down" -> "listen: shutting down"
the procname is already prepended by vlog()
ok jamsek
- Commit:
8cb46987fe75bb80841acf551340ae2587d35d4a
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rename a function for clarity
- Commit:
d4628c48f397550f23bd780ae898625aacda2555
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
zap trailing whitespace
- Commit:
851a5b487c47bf2fb5deec019a049ee0aa7389ca
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotd, gotadmin: install packfiles and index files as 0444
gotd used 0600 (due to mkstemps(3)), gotadmin 0644; change it to 0444
since packfiles shouldn't change once created. Mirrors what git does.
ok stsp@
- Commit:
49563dfbdbb8d9325ae207c0b1400dc6939fef40
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotd: implement the delete-refs capability
Allow clients to run "got send -d" against gotd. Clients will send a
zero-id as new id for a reference and, in the special but more common
case of just deleting and not updating, no pack file will be sent.
ok and tweaks by stsp@
- Commit:
98c7fd82fde99a5be248c7268cd52d18bb9b9c4e
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make gotd session process accept just one flush packet at a time
ok jamsek