Commits
- Commit:
def2f97048d39f24c4938a0ef92b6294480482c2
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: tog: add back _XOPEN_SOURCE_EXTENDED
As with OpenBSD, FreeBSD requires that _XOPEN_SOURCE_EXTENDED is defined
before including <ncurses.h>, otherwise things break.
On other systems (Linux), _XOPEN_SOURCE_EXTENDED is already defined, so
leaving that declared unconditionally throws an error. Keep the
definition, but only include it on !Linux systems.
Issue reported by Christian "naddy" Weisgerber
- Commit:
ac4dc26386a91b9c488d78fd7065780e1eaf33d7
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
show parent commit IDs of merge commits in the tog diff view
ok tracey
- Commit:
89a927a3b498f342fadc937425f55c337d64c796
- From:
- Thomas Adam <thomas.adam@smoothwall.net>
- Date:
tog: make blame view work
Fix the thread comparison with tog's blame view.
- Commit:
acf52a76031e15e6a2bbe327bc4291a2867ae143
- From:
- Thomas Adam <thomas@xteddy.org>
- Via:
- Thomas Adam <thomas.adam@smoothwall.net>
- Date:
ncurses: only look for widechar version
When checking for ncurses, only check against the widechar version of
the library, otherwise the code won't work correctly, despite it
compiling properly.
Helped by Thomas Dickey.
- Commit:
dd038bc6ec835ad3fd3c0b5303b8af9ad506c8cc
- From:
- Thomas Adam <thomas@xteddy.org>
- Via:
- Thomas Adam <thomas.adam@smoothwall.net>
- Date:
portable: initial Linux compilation
This commit modifies the GoT main branch to be able to compile it under
linux.
- Commit:
3da8ef855d7d7b3da96a9f1cba55df276e112f11
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
tog: use sched_yield(2) instead of pthread_yield(3) for portability
pthread_yield(3) is an optional POSIX 2001 extension while sched_yield(2)
is part of POSIX 2008. On OpenBSD they are actually equivalent, albeit not
documented as such. Using sched_yield(2) helps the -portable version.
Patch by Quentin Rameau
- Commit:
6062e8ea890c053733ec0ad3387a40da18a45cda
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
tog: document why _XOPEN_SOURCE_EXTENDED is set and don't undefine it
- Commit:
f3bc9f1df29f91c63ed334a1a9c8929209f93fdc
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
tog: when jumping to the bottom of the log view, go from the tail backwards
ok jasper
- Commit:
ea66598afcb6fd0bfa2c6cad9532450223c85054
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
tog: jump directly to first log item instead of traversing the list
ok tracey
- Commit:
e4526bf56efa8d234d206abac903deccceed4f17
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
tog: add support for navigating to first/last line of tree and ref views
ok stsp
- Commit:
4deef56fe9fdbfef7d2ecd12947ff515a0daae78
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
tog: add support for navigating to first/last line of blame view
ok tracey stsp
- Commit:
528dedf3fe0051922cb1a66083fce16ac0057753
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make tog block other keys except Backspace after End/G is pressed
This should avoid unexpected behaviour resulting from unrelated
key presses messing with the log view's state variables.
Pointed out by tracey, and also discussed with jasper.
ok tracey
- Commit:
00f6361c1e0301276370cb0c7a731cb8b99caa2b
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
remove the 'ctrl+u' shortcut in favor of just 'g' in the diff view, too
- Commit:
751490770ba7a1fe3669a4a604d7412ba8cba776
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make tog ignore Ctrl+L and B while loading all commits
Otherwise tog gets into a funky non-recoverable state if these
keys are pressed instead of Backspace while commits are loading.
bug found by + ok tracey
- Commit:
27890b182992d202636b55c305e5dc4175f4cd0b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove the 'ctrl+u' shortcut in favour of just 'g' as alias for 'Home'
Our use of ctrl+u was not consistent with vi(1) after all.
Discussed with naddy, tb, and jasper on gameoftrees@
- Commit:
fb280deb15e67b1bd8ef0f722a7430b8e9312871
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
Allow commit loading trigged by the End/G keys to be cancelled with Backspace.
ok jasper
- Commit:
912a3f7945204384e4aa755c41dd4e89a855ef38
- From:
- Jasper Lievisse Adriaanse <j@jasper.la>
- Date:
tog: add support for navigating to first/last item of log and diff views
The keybindings that we settled on are Home, Ctrl-u and g to go to the
first item and End, G to go to the last. This resembles those commonly
found elsewhere, eg vi/less.
discussed with and ok stsp
- Commit:
e385fc421f331989f2e6518465e5ead42e5a0618
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
use gmtime_r(3) instead of localtime_r(3) to display time in UTC as intended
Problem noticed by naddy due to failing regress tests at midnight, and then
analyzed with additional help from millert.
ok naddy
- Commit:
aa8b5dd032c8cba930e5be67a90069a95e0001b8
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a use-after-free in get_changed_paths() in got and tog
Once the parent commit is closed the tree_id1 pointer is no longer valid,
but the pointer was still being used. Make a deep copy to fix this issue.
- Commit:
267bb3b89907b99d17aece9890a57afe2982b782
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug a small memory leak in tog's show_diff_view() function
- Commit:
ff6cc066002c80a4503e255f3a5a974734d223af
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove now unused variable in browse_ref_tree() I overlooked; patch by naddy
- Commit:
bc573f3b85b11a3e55feecd664803f1cb71f4204
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a double-free that ocurred upon exit from 'tog tree'; found by naddy
- Commit:
dbdddfee1482b50ca8c4a0be06e4fec6a59fb9f4
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
switch from SIMPLEQ to equivalent STAILQ macros
The singly-linked tail queue macros were added to OpenBSD 6.9 and
are more widely available on other systems.
ok stsp
- Commit:
1d0f405485b02cc4480ea188879e4122e0ea32bd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
check for close(2) error in got_repo_close() and propagate errors up
ok tracey
- Commit:
ec6d1a368f4f81cda70f8517eb0dec5028b847b8
- From:
- Josh Rickmar <jrick@companyzero.com>
- Date:
Fix strftime(3) short buffer checks
strftime(3) returns 0 if the buffer was too short to write the
complete string (including NUL) and will never return more than
maxsize-1.
ok stsp