gotwebd: avoid extra strdups in got_output_repo_tree ok stsp@

gotwebd: avoid extra variable in got_output_repo_tree in_repo_path was used only to build a path, it's then assigned to path (which is NULL at that point.) Just asprintf into path. ok stsp@

Do not segfault verifying "lightweight" tags ok stsp@

gotwebd: plugs leaks in got_get_repo_commits call got_get_repo_commit only once and avoid leaking the field of repo_commit at each loop iteration. ok stsp@

gotwebd: free in_repo_path in got_get_repo_commits; ok stsp@

gotwebd: always free ref in got_get_repo_commits some code-paths may leak it. ok stsp@

gotwebd: don't close tag in got_get_repo_tags too early it's still used a bit later, so defer the free'ing at the next loop iteration or at function end.

gotwebd: free commit_msg0 only at the end of got_get_repo_tags in case of a failure between when it's allocated and when it's released it might get leaked otherwise. ok and semplification stsp@

gotwebd: plug some leaks in got_get_repo_tags ok stsp@

gotwebd: free age and reflist in gotweb_render_branches ok stsp@

switch diff output mode from "edscript" to "plain" for diff3 getchange() in diff3.c takes any line that starts with an integer and treats it as a hunk header. It doesn't actually require ed script instructions, and traditional ed script diff output would break it. Thus, changing Got's diff3 to rely on plain diff output mode paves the way for implementing traditional ed-script style output in diff.git. Patch by Tom Jones

sync files from diff.git 810479a563ffd6176105f64cb49f9829d45d36df

plug a leak in match_loose_object in the loop of match_loose_object we allocate a string per directory entry that in some case it was free(3)'d before `continue' or `goto', but not always. Instead, use a more common idiom. ok stsp@

sync files from diff.git 35eae7fa6b782ae1d000183ef2efc4383dfec4cd This removes the gcc ternary if extension (includes follow-up diff.git fix for missing '\' in wrapped macro 7a38b3a33f8b124c9c01da154dfdf711d328b01d)

gotwebd: free scandir(3) result in gotweb_render_index ok stsp@

gotwebd: free qs->headref before overwriting it

gotwebd: fix leak in gotweb_init_querystring in error path if strdup fails we fail to free the querystring Found by clang' scan-build.

gotwebd: add missing fcgi_printf return check dead store found by clang' scan-build.

gotwebd: fix assets URLs In 95a4a5a1e8d0952ee0d2523dc31df7170d80e0b3 I forgot to fix the links for the favicons and the web manifest.

fix regression in gotweb_free_repo_tag(): free(...): modified chunk-pointer problem introduced in commit 625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0

refresh our pack-index path list if the mtime of objects/pack has changed ok op@

gotwebd: free all allocated fields of repo_tag got_get_repo_tags needs some tweaking to how tag_commit is allocated too. ok stsp@

gotwebd: fix possible leaks when handling errors all very unlikely. part of a bigger diff that's ok stsp@

gotwebd: minor tweaks drop: - a tautological s[strlen(s)] == '\0' - a few duplicates checks - a lone if (error) when it's always NULL - an extra NULL check part of a bigger diff that's ok stsp@

gotwebd: plug leak in fcgi_parse_params fcgi_parse_params parses fastcgi parameters into a list. (This is a leftover from slowcgi where that list is later used to populate the environment of the CGI process.) However, this list is never looked at and its memory never released, so just drop it. Make the matching on fastcgi parameters name strictier by checking also that the length is the one we expect; otherwise we might pick up parameters with the same prefix string (i.e. FOO vs FOO_WITH_SUFFIX) While here turn some bcopy into memcpy and simplify some if-nesting too. Fix the reading from an un-initialized pointer that I introduced in a previous commit. ok stsp@