Commits
- Commit:
6f0bf9bf2208992840af747296f09053d37593f3
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove pointless repo_close with leaked error; found by florian with scan-build
- Commit:
cf1fe301a38235134f7eb246ec0258c003b76e6f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix two missing error checks in tog; found by florian with scan-build
- Commit:
2a31b33bf654723ac3cf71726e41425f7fa9ab7b
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: refactor key map -> new view initialisation
Deduplicate view initialisation boilerplate and simplify new key map view
requests with dispatch routine. Includes improvements suggested by stsp.
ok stsp@
- Commit:
1be4947a5c2d3f42e8dda37929997907d116b746
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: uppercase alpha key maps that open new views
ok stsp@
- Commit:
94ecf40da5315d7cb59ff90ac23614ac0f2a4f3a
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: reset view->offset when clearing log view state
Don't move the selection cursor due to a bogus offset after closing child views
following use of 'B', C-l, and backspace log view key maps.
ok stsp@
- Commit:
3a0139e86b2f9a57742d59dad86f8386532ba872
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: use view->resize idiom to ensure log is populated
Replace view->mode == TOG_VIEW_LOG checks for requesting commits to populate
the log view with calls to view->resize().
ok stsp@
- Commit:
f4e6231a850cc8e3edfb791f86ca3f8f4a9d6245
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: populate new child view log lines when switching split
When switching a child log view from a h- to a v-split, new log lines are
empty. Rather than (mis)trace height and (not) call request_log_commits(), let
resize_log_view() do the math and request commits if needed to draw new lines.
ok op@
- Commit:
ef944b8b4a94171b8635afaf4a8354d652f841cd
- From:
- Florian Obser <florian@narrans.de>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
Do not ignore error from format_author().
Found by llvm's scan-build (dead store).
OK stsp
- Commit:
eaeaa612f1b842e2b6769ad9cf017064bfbaa06c
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: blame view keymap to open log of annotated line
As per stsp's TODO item: open a log view of the selected line with 'L'.
helped by and ok stsp@
- Commit:
777aae211a624f0a3c1a7b286382455bd1097c8b
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: alias J and K to > and < keybindings for diff view
Use J and K to move to the next and previous commits, respectively, when the
diff is loaded from the log or blame views.
Patch by Mikhail
ok stsp@
- Commit:
f69c5a468f5e08db053b390fc00d2e2e70bf4d53
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: add key to toggle author/committer in log view
improvements and ok by jamsek and stsp
- Commit:
ea0bff0410416cb40cf1c0f069bfd6f14429cbbe
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: always request commits if log height is increased
Includes style improvements prompted by stsp. Previously, we would only call
request_log_commits() when terminal height is increased in a splitscreen view.
This fixes the case when a log view with no children is resized that can lead
to empty lines:
$ tog # 80x24
23j # move down to the last commit
*increase terminal height to ~30 lines then reduce back to 80x24*
~5j # move down to the _last_ commit
*increase terminal height to ~33 lines*
*new lines are empty*
ok stsp@
- Commit:
8b925c6ccd3968917253ea191906a1710c40ed2d
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: add back sys/queue.h
Now that the handling of including sys/queue.h is better, there's no
need to remove those lines from the source. Copy the location of those
original sys/queue.h lines from upstream at the same line number, so as
to avoid any conflicts in the future.
- Commit:
47f5fcf41317c40edd55c23ad3e89462980d2549
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
style(9) whitespace fix
- Commit:
fe731b51aaf9031ee68b950393f97f9654bee63f
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: fix sticky "loading..." status in log view hsplit
Don't request commits if the log has completed loading all commits. While here,
ensure the correct parent/child view requests commits when resizing a hsplit.
Reported by stsp:
$ tog
S # switch into hsplit mode
G # move to bottom and load all commits
Enter # open a diff showing the initial import commit
- # shrink the diff view by one line; alternatively use + to grow it
*log status stuck with "loading..." in the header*
ok stsp@
- Commit:
ae98518f6bdbf22a92bd88399deab1642b3721ca
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: only request commits when child hsplit increases
Fix bug introduced in 3c1dfe12b3 that fails to properly populate child log
views due to incorrect request_log_commits() calls: (1) when increasing the
bottom hsplit in a ref/log splitscreen; and (2) when reopening a child log
view after closing a resized child log view:
$ TOG_VIEW_SPLIT_MODE=h tog ref
return # open log view in bottom split
4+ # increase log (child/bottom) split
*new log lines are not populated*
q # close log view
return
*commits are not loaded*
ok stsp@
- Commit:
97cb21cdfaeff6052c984dd9a9bbe56f5e2deb60
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: adjust view line offset when resizing hsplit
Squish bug that can move the selection cursor offscreen when resizing
horizontal splits due to bogus offset:
$ TOG_VIEW_SPLIT_MODE=h tog # 80x24
22j
return # open diff view in a hsplit
tab # focus log (top) split
10+ # increase top split by 10 lines
22j
return # open diff view in a hsplit
F # toggle fullscreen diff view
tab # focus log (parent) view in fullscreen
*selection cursor will be off the bottom of the screen*
ok stsp@
- Commit:
4fc71f3b760478d7300692fa227470174bf71bef
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: enable moving to prev/next blame line in diff view
Blame/diff view counterpart of log/diff <,.> key maps to traverse commits
corresponding to each line of the annotated file from the diff view. Includes
fix from stsp@ to work while the file is still annotating.
ok stsp@
- Commit:
ddbc4d37d03655e34912912b916ef1db6e481fed
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: make 'S' switch split mode irrespective of the view
Always switch internal split state and redraw view according to the
constraints of the new mode.
suggested by and ok stsp@
- Commit:
f2d749db68f584041b421d0b6f6f3fb64251ff0c
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make 'tog log' error out in shallow Git repositories instead of hanging
ok op@
- Commit:
b9e3c50406aeac333955263c028944bb064a695b
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: remove stale comments
Remove comments which are no longer required.
- Commit:
53d2bdd3e37f479b355cf7c28a6d404076799570
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: implement +/- keymaps to resize the focussed split
Increase/decrease the currently active split. New dimensions persist for the
tog session, irrespective of subsequent closures and new child views.
suggested by and ok stsp@
- Commit:
644866927109ba80d819dc2b19530253fd93be58
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: implement global 'S' key map to switch split mode
If in a vertical (horizontal) split, switch to horizontal (vertical), and make
new split mode persist.
ok op@
- Commit:
634cb454457dd3f5f7de912c24fdc8abb3aaed0d
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: add C-g/backspace key map to abort compound cmds
Problem reported by stsp: 9999j would tie up tog till completed. While here,
trim trailing whitespace in tog.1 and make C-g alias existing backspace abort
key map for search and G in log view.
ok op@ and stsp@
- Commit:
444d532558298b49ff0edc7fc0376d71b5fa00b0
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: expand horizontal split support to all views
With this, hsplits are now available to the same parent/child view combinations
as vsplits. Includes OB1 log truncation fix from op@ that was reported by stsp.
ok stsp@