Commits
- Commit:
17c726049a0c49099ef0a44190264fa4b6b037fa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
backout 169b163113a6db9878c9166aa05fbd30d05eb832
pushed by mistake, wasn't reviewed.
- Commit:
169b163113a6db9878c9166aa05fbd30d05eb832
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_diff
To avoid calling functions from got_operations.c directly from a
template (which would hide the error), change got_output_repo_diff into
got_open_diff_for_output that returns a file with the diff in it, to be
then rendered by the template. got_gotweb_flushfile needs to be exposed
then.
It also bundles a smaller change: the `label' argument of
got_repo_match_object_id is optional and not used, so just pass NULL
there.
- Commit:
43d421de222216d318387afcd42a4941d2714d95
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_tree
ok tracey@
- Commit:
298f95fb39537cc43237be56aeb86ffbc21e38f0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs
binary blobs are automatically redirected to the BLOBRAW page (which is
the old BLOB.)
ok jamske
- Commit:
345b67f25dce7f6a5c981475844df01418a75cbb
- From:
- Omar Polo <op@omarpolo.com>
- Date:
change gotweb_render_content_type argument type to const char *
it's a string, `const char *' is fine (and what all the callers use
anyway.)
- Commit:
92c8ec640028151d1e92eaef79c4fcd1365998bc
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: use Content-Disposition for RSS; sets the filename
Since gotwebd serves the RSS from a path without a file name component,
browsers just make up a random string to give the file a name which can
be confusing. Furthermore, since it's served as application/rss+xml
they try to render the XML (failing.)
Use gotweb_render_content_type_file (which sets the Content-Disposition
HTTP header) to fix both: the feed is now called <repo-name>.rss and set
as attachment (thus saved and not rendered.) Change the function to
take an optional filename suffix for the occasion.
ok jamsek
- Commit:
1b18f4cd75fddf070589d9b045e083ac02d8baba
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: tweak gotweb_render_content_type_file parameters type
`type' and `file' are strings so use `const char *' for both.
- Commit:
1abb18e1777172a9f4149a0f50c4cecfd024f02c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: add an RSS feed for the tags
ok tracey@
- Commit:
d19d9fcec89a7d18ca8325b70f5edde7b4e6369a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: use DOCUMENT_URI rather than SCRIPT_NAME
the latter is empty when serving from a directory-like path prefix with
an httpd.conf(5) as per gotwebd(8).
ok tracey@
- Commit:
156a11447a870d2128d6ddce97013fca0cfd4e6a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_commits
ok tracey@
- Commit:
b4c0bd7275f121f6250964ddfdf8db160ad486df
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_navs
ok tracey@
- Commit:
03f6a843c825ee4566446557cfa33bd1ebb1827b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: drop index_page_str and page_str
gotwebd uses sprintf to update index_page_str and page_str if they were
negative. While this specific usage is safe, let's drop it. Since the
index_page_str and page_str fields are never read from, remove them.
This saves two allocations per request too.
ok tracey@
- Commit:
ed619ca07e51b9c984c8404ca2b1153efdb14d1e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: start using the template system
ok tracey@
- Commit:
270c41a2b8c0d37d0ea9710a656369efa551dfcd
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: provide maximum value for the description and cloneurl
ok stsp@
- Commit:
c127fc49cfbf532409724a0e4644f4b2539e430f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: drop unused path parameter from got_get_repo_{owner,age}
ok jamsek
- Commit:
d5996b9efcd57875669fb0b06006ecf8cf566272
- From:
- Landry Breuil <landry@openbsd.org>
- Date:
add respect_exportok flag, defaulting to off
allows to hide repositories if they have the magic git-daemon-export-ok file
ok op@ tracey@ stsp@
- Commit:
8d02314fcaebb323c9ca3b102f8a085d66ea4633
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: percent-encode generated URLs
This adds a new helper function `gotweb_link' that outputs an HTML link
with the parameter correctly escaped.
ok stsp@
- Commit:
7e0ec0529553d4a8e236cad41366f79eda5126b3
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: shrink struct server
keeping GOTWEBD_REPO_CACHESIZE * sizeof(struct cache_repo) inside the
struct server makes it too large for imsg on some platforms (linux at
least.) Instead, store a pointer and allocate the array when it's
received on the child processes.
ok stsp@
- Commit:
40a95f4f726567f73ee83d4866608f7ea0654eaa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: plug leak in fcgi_parse_params
fcgi_parse_params parses fastcgi parameters into a list. (This is a
leftover from slowcgi where that list is later used to populate the
environment of the CGI process.) However, this list is never looked at
and its memory never released, so just drop it.
Make the matching on fastcgi parameters name strictier by checking also
that the length is the one we expect; otherwise we might pick up
parameters with the same prefix string (i.e. FOO vs FOO_WITH_SUFFIX)
While here turn some bcopy into memcpy and simplify some if-nesting too.
Fix the reading from an un-initialized pointer that I introduced in a
previous commit.
ok stsp@
- Commit:
af7ccbc139100f0bb94b8d2ef998dedc122a18f5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: garbage collect the now unused GOTWEB_GOT_DIR
- Commit:
b5c757f5f816a8061f4879da9e68a39141148e40
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotwebd cache open repository handles in struct server
ok op@
- Commit:
95a4a5a1e8d0952ee0d2523dc31df7170d80e0b3
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: use SCRIPT_NAME to derive URLs
This makes gotwebd use SCRIPT_NAME instead of the DOCUMENT_ROOT fastcgi
param to generate the links to the assets and changes some links so
every page is consistently linked with a relative URL.
It allows to drop the `root "/"' in the location for fastcgi and, as a
bonus, also makes possible to run gotwebd on non "/" paths.
ok stsp@
- Commit:
6c8aa58fb8d3f1ee21b1388770cf1fd607413ed4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove fcgi_socket keyword from gotwebd.conf; "listen on" now implies it
ok op@
- Commit:
67d8de2a7e03c31bd8c93553fcb950fa7afc0db7
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
allow multiple "listen on" statements per server in gotwebd.conf
ok tracey
- Commit:
610dd8c9f454e1625b0eddc16af87b765279b0a5
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotwebd: struct socket_conf can only use a single address, so don't use a list
ok tracey