Commits
- Commit:
df9fed0915a99336775c645ff1d463846095c554
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: plugs leaks in got_get_repo_commits
call got_get_repo_commit only once and avoid leaking the field of
repo_commit at each loop iteration.
ok stsp@
- Commit:
bc4d9cc814a8013b847608d99acabf16b4caaeda
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: free in_repo_path in got_get_repo_commits; ok stsp@
- Commit:
4d0573ec49ba89483320bcbbbdf875ed936c16a6
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: always free ref in got_get_repo_commits
some code-paths may leak it. ok stsp@
- Commit:
acd4ff87e51fe0de84244536dfae7f503c4635ae
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: don't close tag in got_get_repo_tags too early
it's still used a bit later, so defer the free'ing at the next loop
iteration or at function end.
- Commit:
ddcf1d336cfcbb86f25f1d7bc1158316138b126d
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: free commit_msg0 only at the end of got_get_repo_tags
in case of a failure between when it's allocated and when it's released
it might get leaked otherwise.
ok and semplification stsp@
- Commit:
19d60ee3e107682f62ef5f79ccc2e10a28b6d533
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: plug some leaks in got_get_repo_tags
ok stsp@
- Commit:
217813df81cbe2ba47d4ed204298a3f204014340
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: free all allocated fields of repo_tag
got_get_repo_tags needs some tweaking to how tag_commit is allocated
too.
ok stsp@
- Commit:
3179741908f46f3c1711b053ad2ab839c746a5bf
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix possible leaks when handling errors
all very unlikely.
part of a bigger diff that's ok stsp@
- Commit:
6b42af1e1d379806c1ef2cccfa084a7b8de605f1
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: minor tweaks
drop:
- a tautological s[strlen(s)] == '\0'
- a few duplicates checks
- a lone if (error) when it's always NULL
- an extra NULL check
part of a bigger diff that's ok stsp@
- Commit:
6e596ed0f31b4b5a6944bb7a6d3fa433caa69314
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix dup(2) error checking in got_gotweb_openfile()
- Commit:
e2af4cd74c227f8f647bcb29631fd0cfa70d6358
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
in got_operations.c, remove error variables which were only used to return NULL
- Commit:
2f26d3340d5e3957488707d3098e6ec7a417b67a
- From:
- Tracey Emery <tracey@traceyemery.net>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
get rid of (null) on the index page. ok stsp
- Commit:
df610f472695eeed6f3a618d1833f17f767e9ed1
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix memory leak introduced in d927f8c
ok tracey@
- Commit:
255f40228747f0671ce214c468858d83c2efe8a5
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: make sure to escape possibly unsafe strings
this fixes only the HTML escaping of strings, the urlencode is still
missig.
while here also plug a memory leak in gotweb_render_branches and drop
some needless ternary operators.
ok tracey@
- Commit:
7939347171a791b258516ee7ce589dc403328c78
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: add fcgi_printf
instead of fcgi_gen_response which outputs only a fixed strings provide
a printf-like fcgi_printf: it greatly simplifies the generation of the
HTML pages.
While here also (probably) fix some HTML errors: the output was verified
with the W3C validator and it's correct (in the sense that the tags are
properly closed, there are still some other things the validator
complains about.)
ok/encouragement baseprime@, ok jamsek
Thanks for reading such a boring diff!
- Commit:
b5c076278bbb7205a9828d2ac2da41999fff4a14
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix overflow in blame callback
spotted by noticing gotwebd crashing on some blame requests.
Diff from stsp@ with a fix from tracey@, I'm committing it only because
he is short on time.
ok stsp@
- Commit:
56935ae74ff53a448ab002397a77471568b4ce20
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix alternate colors in tree entries
it was broken in 7ecc454 because now we're emitting tags with multiple
`class' attributes (by mistake) and only the first one is used.
However, instead of fixing the HTML `class' attribute, use a CSS
selector to alternate the background colors.
ok tracey@
- Commit:
9e0c279a851c5011a378217a9e693d4e75c4c106
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: switch some HTML IDs to classes
HTML IDs are meant to be unique across the page. While here fix two
small errors in the generated HTML (one missing closing div and one
extra.)
ok tracey@
- Commit:
57d4848d969f00db854acc82cd5e920532a9f809
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: simplify got_output_file_blob loop
there's no need to distinguish between plain text blob and a binary one
in the output, just send it chunk by chunk.
ok tracey@
- Commit:
f24996f19460af47ec131fd1b637b134860ae6a4
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: simplify isbinary
- Commit:
d54f10aa3fdb292115d93d868ae105413f812a7a
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix double Content-Type (and the typo)
ok tracey@
- Commit:
23794ad3ee282e996bc24eeb04eb1364a2140632
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: remove duplicate includes
Remove over-zealous additions of sys/queue.h which had snuck in from the
previous commit.
- Commit:
8b925c6ccd3968917253ea191906a1710c40ed2d
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: add back sys/queue.h
Now that the handling of including sys/queue.h is better, there's no
need to remove those lines from the source. Copy the location of those
original sys/queue.h lines from upstream at the same line number, so as
to avoid any conflicts in the future.
- Commit:
ff36aeea6fe48eb9071eccc41d2a31a47d109be3
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: gotwebd: first stab at compilation
This is not yet "clean", but does compile. A few things to consider:
* See comments beginning with "TA:"
- Commit:
3e12c1689b7d7bdebdd92107a55904e4bc9bd104
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: explicitly include <sys/queue.h>