Commits
- Commit:
6f711b103fc86abf1cc94d145c48c5a927f01527
- From:
- Omar Polo <op@omarpolo.com>
- Date:
plug mem leak in got_repo_pack_fds_open
pack_fds_tmp is not always free'd. However, while here, simplify it to
not use a temporary array.
ok stsp@
- Commit:
5d22ea52df30acf1895cb703d770514a2154b5ae
- From:
- Omar Polo <op@omarpolo.com>
- Date:
plug a leak in match_loose_object
in the loop of match_loose_object we allocate a string per directory
entry that in some case it was free(3)'d before `continue' or `goto',
but not always. Instead, use a more common idiom.
ok stsp@
- Commit:
b8a4401b8e46c0a32b824433c648ea749898616b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
refresh our pack-index path list if the mtime of objects/pack has changed
ok op@
- Commit:
794662a4547b17c0243addf37d330d39e0eb5662
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
don't leak memory allocated internally by bloom filters; ok jamsek
- Commit:
5e91dae4dd43b8024731223110ab18f505f453ac
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove trailing whitespace; patch by Josiah Frentsos
- Commit:
4fa16b393ac52eadd8159d265e31961b11a10a25
- From:
- Omar Polo <op@omarpolo.com>
- Date:
read_gitconfig: fix GOT_IGNORE_GITCONFIG case
set gitconfig_remotes to NULL to avoid a double-free, and reset the
global author name/email fields too.
ok stsp@
- Commit:
3e0f95fc704e82b2b916e10c016299e1b49e8383
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add a way to ignore author and remote repository info found in Git config files
ok op@
- Commit:
6f748833062c683ec23808460f4bb67bd18693e3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
comment tweak
- Commit:
0c41134356d52f1dd4db38637202364533f43866
- From:
- Lucas <lucas@sexy.is>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
got_repo_pack_fds_close: don't close(0)
got_repo_pack_fds_close will try to close all of the GOT_PACK_NUM_TEMPFILES fds,
even the ones that didn't manage to get a value from got_opentempfd(), which
would result in a close(0) if we do not initialize to -1 here.
- Commit:
f97edf0cbcf2ee1ea1d71a162699f0be79bd0400
- From:
- Florian Obser <florian@narrans.de>
- Date:
Make sure got_repo_pack_fds_close() frees a malloc'ed pointer.
Found by llvm's scan-build (bad free).
OK stsp
- Commit:
b5d22c386422ab4e29e05d887089fae7e446e40b
- From:
- Florian Obser <florian@narrans.de>
- Date:
Don't chug along if repo format version is unsupported.
Found by llvm's scan-build (dead store).
OK stsp
- Commit:
61af9b215c06bece11deb27d941b390b81e0f8c6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
implement support for commit coloring in got-read-pack for speed
ok op, tracey
- Commit:
d188eb1946acd5671794bb6cbdd256d7b962a669
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove pointless assignment at the end of got_repo_pack_fds_close()
- Commit:
bb711527a87bef0fc809a71d53e9bc2dad28150d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
don't look for close() errors if opentemp() failed in got_repo_pack_fds_open()
- Commit:
0ae84acc1f0a0584e4f26ccbe029c895043b3abe
- From:
- Tracey Emery <tracey@traceyemery.net>
- Date:
move got_opentempfd out of got_repo_open. ok stsp@
thanks for all the help massaging this diff
- Commit:
6a881297759a4b3c4f62093aef5fdbaad0dae8df
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
properly swap cached struct pack array elements in got_repo_cache_pack()
Avoids clobbering open files for delta base/accumulation, leaking file
descriptors, and triggering errors from close(2) during got_repo_close()
as we try to close the same file descriptor more than once.
- Commit:
13242195c28da5b721878751b7cb7beb3fa0e264
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
ensure that all open basefd/accumfd get closed in got_repo_close()
found by tracey
- Commit:
571608344a37fb96f46850a1124415ab68b1a431
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
open temporary files needed for delta application in got_repo_open()
This prepares for callers of got_repo_open() that cannot afford to
open files in /tmp, such as gotwebd. In a follow-up change, we could
ask such callers to pass in the required amount of open temporary files.
One consequence is that got_repo_open() now requires the "cpath" pledge
promise. Add the "cpath" promise to affected callers and remove it once
the repository has been opened.
ok tracey
- Commit:
d7b5a0e827bb38e5c8502f0ba8d7838fedaba19b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
inline struct got_object_id in struct got_object_qid
Saves us from doing a malloc/free call for every item on the list.
ok op@
- Commit:
f134ecfdc329a401e2e93407cce94733515f16fb
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
const-ify string table
- Commit:
c560c1f52d2adb8966e2f783ed7d3f0b37117df9
- From:
- Omar Polo <op@omarpolo.com>
- Date:
don't `goto done' if calloc fails
otherwise we call got_repo_close with repo being NULL and segfault
there.
ok stsp
- Commit:
9b576444ae8786f3cc494c57cb8e7a64b74970db
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
cache a list of known pack index files when the repository is opened
Avoids overhead due to readdir calls while searching a pack index.
ok op@
- Commit:
0e6ab4b2dda12fd56fa5ccb1cb3ff1aa12876891
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make got_repo_match_object_id_prefix() reject overlong input strings
suggested by + ok naddy
- Commit:
0ed2285b0119b293d6b77b882c707c0377e176cd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
handle reference arguments which look like short object IDs
Match command line arguments against references before matching object IDs.
This makes it possible to use reference names that happen to match a short
object ID.
For example, a branch called "11ac" could not be diffed in OpenBSD src.git
which happens to contain commit IDs that begin with hex digits 0x11ac.
A bogus error would be reported in this situation:
$ got diff master 11ac
got: ambiguous object ID
ok naddy
- Commit:
8934ea8b1b31166ea1f3f857e6f51f8dd6a999a2
- From:
- Omar Polo <op@omarpolo.com>
- Date:
factorize imsg_clear calls after imsg_flush failures
imsg_clear frees and closes resources allocated as part of enqueueing
imsgs so it's a no-op after reads.
discussed with and ok stsp@