Commits
- Commit:
faf054c3d5fbad3a55534ebe525d58156c7aad27
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make new log message modication check more robust; fixes regress fallout
ok jamsek
- Commit:
ccc835f12a86459f480a7ea4b724af67cd0889a7
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
garbage-collect redundant read_logmsg() parameter
As identified and suggested by stsp, with the previous commit,
'strip_comments' is now always set thus no longer needed.
ok stsp@
- Commit:
93436ccdaf0945f5fdb4b5cd2b90c9ac0bb14c83
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: use timestamp and emptiness to validate log message
As suggested by naddy: consider commit log messages valid provided the temp
file time stamp has changed and the file is not empty. This heuristic
provides the desired behaviour (i.e., reusing cherrypicked/backed-out log
messages) that's currently provided but is simpler to grok.
Improved by and ok stsp@
- Commit:
91a3781a11d1b2c483221d9dca87d72aea17637b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make edits made to comments count as a log message modification
This supports use of cherrypick/backout without requiring the user
to modify the log message of the original commit.
ok jamsek, op
- Commit:
704b1cf77bf5aa6f9aeed7bca0b34c53cc2183c2
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
only fetch the work tree's branch by default if it is inside "refs/heads/"
ok jamsek
- Commit:
188f8dcf2c1c15bf37859e3b587bc6331fd5a097
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix interaction of 'got fetch -b', got.conf, and work tree
Without branches in got.conf for a remote, and without -b/-R options,
the fallback to HEAD would only work when not invoked in a work tree.
With this fix 'got fetch' should behave as described in the man page.
The -b option now overrides both got.conf and the fallback to the work
tree's branch.
And fallback to HEAD works as expected when invoked in a repository.
Also, do not strictly require remote repositories to provide a branch
from the refs/heads/ namespace. In such cases users should be able to
use -R to select something to fetch.
ok jamsek
- Commit:
ccbbf026bf5917a8d66564fcce9184b29412432b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
improve 'got fetch' behaviour when work tree's branch is not on server
Only fetch the work tree's branch if the -b option is not specified.
This keeps -b functional as an override when invoked in a work tree.
Our previous changes did not consider that got.conf is also a source
of lists of branches to fetch, and that -b is supposed to work as an
override of any default behaviour. We were implicitly appending the
work tree's branch as if it was mentioned as an override on the
command line, which was wrong and based on a misunderstanding of
the intended behaviour.
Without -b on the command line we obtain a list of branches to fetch
from got.conf and use this list if it is not empty. The repository's
HEAD will be fetched only if neither the -b option, nor got.conf, nor
a work tree tell us what to fetch.
Make the man page more clear by moving the explanation of the default
behaviour into the main section of 'got fetch', leaving the -a and -b
option descriptions free of such details.
ok jamsek
- Commit:
c33c3763d3c9e005bb51d9d3a6aab3bedc50bf2e
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
fix mistaken instances returning NULL instead of err
While here, for consistency, check dup() return value for -1 rather than < 0.
ok stsp@
- Commit:
ddb2df58a374b7058f0d3044c25b821680bd3345
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: make fetch default to the work tree's current branch
As per stsp's todo item, if invoked in a work tree, make 'got fetch' default
to fetching the work tree's current branch instead of the branch pointed to
by the remote repository's HEAD.
ok stsp@ and op@
- Commit:
ef85a376d8f41068fa9c6b11bc1fff98e3e9520c
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
zap unused parameter in got_worktree_rebase_complete()
ok stsp@
- Commit:
36fdf003886958dce2c912acd082b3e9cfe88979
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
return err instead of NULL in got.c:print_backup_ref()
ok stsp@
- Commit:
3506a2b1c255a8d362e1cce0a8b594c9fb17bb37
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
free cwd in cmd_backout() and cmd_cherrypick()
ok stsp@
- Commit:
980c6786a419950816c67eb1b53e021ebdfe483c
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make 'got rebase' work when the to-be-rebased branch has no parent commit
found by and ok op@, who also provided the test case
- Commit:
b584caa3e8756aeac18e4d5b3c63cdc8b17ad9ea
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
show worktree UUID in backout/cherrypick -l output
When run from the repository, display the UUID to help the user know which
logmsg refs belong to which work tree. Also, use "backout" or "cherrypick"
in the log message header to distinguish output from 'got log'.
Suggested by stsp on irc.
ok stsp@
- Commit:
66c06eb12bec7b816963355327e0b3b53db5e881
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
add missed option conflict check for histedit -e and -f
Reviewed as part of previous commit adding histedit -d.
ok stsp@
- Commit:
f1c9fe20d35f9b64cee89491805039b13c91c8de
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: add 'got histedit -d' flag to drop all commits
Like -f, except drop all commits. Discussed with op and stsp on irc.
ok stsp@
- Commit:
7e320d3b050a09132d29db243fa3940d96707346
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: don't leave tmp "got-logmsg-*" files in the work tree
Reported by stsp on irc, and reviewed as part of the following regress
commit covering the commit aspect of logmsg refs. Delete temp merge_log
files if created during commits involving backed-out/cherrypicked changes.
ok stsp@
- Commit:
cf847b167995f9c334ac203d4817d0203a222756
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
abort commit with merged log messages if the log message is left unmodified
ok op@
- Commit:
c7ee7a0aebd0cf0ba96bd4215bd263d8f1dd8e6b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid creation of temporary file if no merged log messages will be used
- Commit:
8b3ae425fe39895d4f5d1be49b178703173e964d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rename a variable for clarity
- Commit:
378a2540886d76e663ffc65125a68c08f8a38604
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
uppercase cherrypick/backout -X progress output
ok jamsek
- Commit:
3d800fb8c5236335129e5a017113967bda6cd62c
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
improve heuristics for prepopulated log messages
Small tweak to cover the case where users specify paths to be committed such
that none of the paths modified by a backout or cherrypick operation are in
the commit. In this case, the logmsg ref will remain in refs/got/worktree to
be used when the user does run a commit involving the affected paths.
ok stsp@
- Commit:
971d0123bfde09ec62689dbf7e2d9a68e143f4b6
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
fix invalid assumption in commit_path_changed_in_worktree()
Make sure we have a parent id first to avoid dereferencing a NULL pointer
with the got_object_open_as_commit() call.
ok op@ and stsp@
- Commit:
9587e6cc5169e6d39431fd1066097fd3f04e5d51
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: load editor with backout/cherrypick commit log messages
Create new logmsg references used to populate the editor with the log messages
of backed-out and cherrypicked commits when 'got commit' is run. We use
versioned path state heuristics during revert and commit commands in an effort
to ensure the editor is only populated with the log messages of backed-out
and/or cherrypicked commits involving paths with local changes that are being
committed. This is an implementation of an initial idea and algorithm designed
by stsp.
inputs, improvments and ok stsp@
- Commit:
a003d5184726e721ca5313a722fc1a22d602e8b8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
cmd_tag: avoid unnecessary strdup of signer_id
ok jrick