Commit Diff

Commit:
1251a9e5a52510aea3b03f1228de7404e6f95a3a
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
note potential problem in the existing out-of-dateness check
Actions:
Patch | Tree
commit - d56d26cef864d03dc5104b6e38995f992a9693e4
commit + 1251a9e5a52510aea3b03f1228de7404e6f95a3a
blob - c00c98a1f41c3713dc1f2c4246a42902196dad51
blob + a4c605a756322f709713c648db7450a5fb552ae7
--- lib/worktree.c
+++ lib/worktree.c
@@ -2785,6 +2785,14 @@ check_ct_out_of_date(struct commitable *ct, struct got
 	const struct got_error *err = NULL;
 	struct got_object_id *id_in_head;
 
+	/*
+	 * XXX This should probably be checking each commit from
+	 * worktree's base_commit -> head and verify that the
+	 * same blob exists in each of these commits.
+	 * Removals+additions within this line of history could mean
+	 * that renames have occured in which case we should really
+	 * be forcing the user to run an update...
+	 */
 	err = got_object_id_by_path(&id_in_head, repo,
 	    head_commit_id, ct->in_repo_path);
 	if (err) {