Commit Diff

Commit:
5ceaed1f0361f500855854af8014994720e38c1f
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
avoid the needless check for set membership in got-read-pack as well The list of ids traversed here won't contain IDs already present in the set.
Actions:
Patch | Tree
commit - e8c72451da38cc8d8c128d34707e9011275ca413
commit + 5ceaed1f0361f500855854af8014994720e38c1f
blob - d923d003656f2ce54bcc900b0f64d745a705430f
blob + d98276ebe73aad573bc05b47c0decf9d90f1963b
--- libexec/got-read-pack/got-read-pack.c
+++ libexec/got-read-pack/got-read-pack.c
@@ -1739,11 +1739,9 @@ repaint_parent_commits(struct got_object_id *commit_id
 		if (err)
 			break;
 
-		if (!got_object_idset_contains(set, &pid->id)) {
-			err = got_object_idset_add(set, &pid->id, NULL);
-			if (err)
-				break;
-		}
+		err = got_object_idset_add(set, &pid->id, NULL);
+		if (err)
+			break;
 
 		STAILQ_REMOVE_HEAD(&repaint, entry);