Commit Diff

Commit:
675d71c4343c11708d0df6b8965cb4e6f3a42ea2
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
clean up commit list in print_commits() regardless of error
Actions:
Patch | Tree
commit - e97248b0f4809130bbab608a1fe9992702b77e38
commit + 675d71c4343c11708d0df6b8965cb4e6f3a42ea2
blob - bbfab873890ceb2606f14caf474860a375bc8575
blob + 46570b469f891b3661e5361cc7bfe505ebc3afc4
--- got/got.c
+++ got/got.c
@@ -413,14 +413,12 @@ print_commits(struct got_object *root_obj, struct got_
 		free(entry);
 	}
 
-	if (err) {
-		while (!TAILQ_EMPTY(&commits)) {
-			entry = TAILQ_FIRST(&commits);
-			TAILQ_REMOVE(&commits, entry, entry);
-			got_object_commit_close(entry->commit);
-			free(entry->id);
-			free(entry);
-		}
+	while (!TAILQ_EMPTY(&commits)) {
+		entry = TAILQ_FIRST(&commits);
+		TAILQ_REMOVE(&commits, entry, entry);
+		got_object_commit_close(entry->commit);
+		free(entry->id);
+		free(entry);
 	}
 
 	return err;