Commit Diff

Commit:
8c2f570d00be50eca117433b5e9dfdf90a4210cd
From:
Stefan Sperling <stsp@stsp.name>
Via:
Thomas Adam <thomas@xteddy.org>
Date:
Message:
in the delta-cache debug report, show the size of the largest delta seen
Actions:
Patch | Tree
commit - f2afb89d51ee41bbafec1feba57e50bf362c75dd
commit + 8c2f570d00be50eca117433b5e9dfdf90a4210cd
blob - 09b40b8dd8fc51e6f52338e23640fd344f9a41ea
blob + 80dbeec473acf23e7d088b05941b2f804b5dba45
--- lib/delta_cache.c
+++ lib/delta_cache.c
@@ -64,6 +64,7 @@ struct got_delta_cache {
 	int cache_miss;
 	int cache_evict;
 	int cache_toolarge;
+	int cache_maxtoolarge;
 	unsigned int flags;
 #define GOT_DELTA_CACHE_F_NOMEM	0x01
 	SIPHASH_KEY key;
@@ -103,9 +104,10 @@ got_delta_cache_free(struct got_delta_cache *cache)
 
 #ifdef GOT_DELTA_CACHE_DEBUG
 	fprintf(stderr, "%s: delta cache: %u elements, %d searches, %d hits, "
-	    "%d missed, %d evicted, %d too large\n", getprogname(),
+	    "%d missed, %d evicted, %d too large (max %d)\n", getprogname(),
 	    cache->totelem, cache->cache_search, cache->cache_hit,
-	    cache->cache_miss, cache->cache_evict, cache->cache_toolarge);
+	    cache->cache_miss, cache->cache_evict, cache->cache_toolarge,
+	    cache->cache_maxtoolarge);
 #endif
 	for (i = 0; i < cache->nbuckets; i++) {
 		struct got_delta_cache_head *head;
@@ -203,6 +205,8 @@ got_delta_cache_add(struct got_delta_cache *cache,
 
 	if (delta_len > GOT_DELTA_CACHE_MAX_DELTA_SIZE) {
 		cache->cache_toolarge++;
+		if (delta_len > cache->cache_maxtoolarge)
+			cache->cache_maxtoolarge = delta_len;
 		return got_error(GOT_ERR_NO_SPACE);
 	}